Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1789723ybh; Mon, 20 Jul 2020 07:18:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwDoA9Gl9XTjC7iQZZCvIFGUbfpwZplCyHdnPBsLf6g1mP2JyMcM0rHAWYIVkzvaMqi4l5D X-Received: by 2002:a17:906:a289:: with SMTP id i9mr4854678ejz.275.1595254690304; Mon, 20 Jul 2020 07:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595254690; cv=none; d=google.com; s=arc-20160816; b=extVI7K+8ucIxoRk/+DxcvdurUWMk8bWMoGOqMuwpdAEHwF+YDXT93Pxq38zDqVmTt Kuu0q8Tnv6/3RtD1gga2BwYw6Bqw4b4FZR4z925s3486ZPCI1/nZUZafNbEoD33H1BM1 P4PepCkKvSMDhZJzORNeYmZg5GIrhgymJM4ro15gi1NICzNxCml3O2Xrdsmojzd94gq4 5JurVEPdxwqbRGytrqIEZ4eIz7XYL0EF+aLnxef/PIUueWxGlYwXvWXVv8h+XVgSNpqG sgTKCr/Bc2TPyenNSO62z/WP16+7/ha6sf9A/IY8oWwuZ00s1xuEX1Ez82ohFJh3jmcK uERA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=sfDULJX5Fvi0AnSdtZ5x+Bly5Vi8m2zGpSYTEybdvqg=; b=HcFTrvoRbRQDfsnsdq8u811FRDkcIkdyDGqjoMVeD9PMqf0r51rEAWUj0swH1ZUfmw p1sn5fAMJaSXIY6gXDmUN+mIm1btcttCOxwMChiVCI2PBOtDEFbq1syZMmGDC6Bs0E6b GCbHXdTsX0SqTSThK6+4WSbNsJLjTi1wlArZP0ccM0B4IvUilYdTqVfVDHbV9Up1cJqj DbAxF/QkCQlnNHh6zk81i8DvPtdaeCW6aQmWRP431WOMhPlcEWd5TsqC8zrNH7/D/uXz KjMDfKir1G9Br9jWUaXLArCbZ9dqzk/cMviprIkr+hCgPEzpMeDw8WajYWAwnViw3R2U 2I4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X8CKmrpK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co19si10359505edb.605.2020.07.20.07.17.44; Mon, 20 Jul 2020 07:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X8CKmrpK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgGTOPb (ORCPT + 99 others); Mon, 20 Jul 2020 10:15:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgGTOPb (ORCPT ); Mon, 20 Jul 2020 10:15:31 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA5EC0619D2 for ; Mon, 20 Jul 2020 07:15:30 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id j11so20402578ljo.7 for ; Mon, 20 Jul 2020 07:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sfDULJX5Fvi0AnSdtZ5x+Bly5Vi8m2zGpSYTEybdvqg=; b=X8CKmrpKIRDTR+391ddqGlixEfo0VQi97P2ADPs7vuh5NP9YgZk7+L7U6CmkKa6OY3 hPVuGIju545zlwUnlWzs/vPd64g/P8uOifPACHN95/KPV6ng3T6XTFavh9K7dtwhiifD Tmekf23hliYhrzOx//efBGMF3o9ekZ1HjTeQPye6OUtK0YBNMXZ27znaM61e7FRrSlnO hrbaXMIZ+Sw3y5dXT3zbl18epj326Su4k08b4C9xGpjCWrc4Dxa4Mubf/gVYifOMq5gh 0y2dJA0UPEhTyN3WepdWepfYWQeLp4mJbMPVNpMFivC3aURIOpFYhxxr5gMHBBvo1Pze kC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sfDULJX5Fvi0AnSdtZ5x+Bly5Vi8m2zGpSYTEybdvqg=; b=sy49vEHEolLbUcbQZyi91czMDpqM7tcXu8PQ5+2w9GzzFSga4b1FDp8m7FCQF+jQAq SDu7roKZG34qRh/I7tuHccyJPmKb7Xft/ZoOu+FifShh5HkYpu1MNoVPTQ6luztyybRI hTvIaTQkC4SO3swXoqWHhmFC86dGBwtrUkRTc+m9J6YOFiFsXrR3RJL/Z2w5XdtE+ais /M6LoOmpdOJNYZmRZFSUVTi3a7ImmDByk025yBtx2mKihzNeNrZu2qFgr7pnyBJ/vmgN voAazKNfr06nCiDsL1kMlYc3HBemTkBp5f2NKP0N1q8iIyxwnQYyaQhSucvnmZuxdNch xVpg== X-Gm-Message-State: AOAM5332ej+Hr5EGzCRcwOxZgm9o+sk2kdLgpKeqOmjaA1hIcIR3zYfN BwQfLbRcTCYgucFfuiWPahGSuqFOYfnpj693GLx6Wg== X-Received: by 2002:a2e:8597:: with SMTP id b23mr9748320lji.338.1595254529367; Mon, 20 Jul 2020 07:15:29 -0700 (PDT) MIME-Version: 1.0 References: <20200706070259.32565-1-ricky_wu@realtek.com> In-Reply-To: <20200706070259.32565-1-ricky_wu@realtek.com> From: Linus Walleij Date: Mon, 20 Jul 2020 16:15:18 +0200 Message-ID: Subject: Re: [PATCH] misc: rtsx: Add support new chip rts5228 mmc: rtsx: Add support MMC_CAP2_NO_MMC To: ricky_wu@realtek.com Cc: Arnd Bergmann , Greg KH , Ulf Hansson , rui_feng@realsil.com.cn, Bjorn Helgaas , kdlnx@doth.eu, Rui Miguel Silva , "linux-kernel@vger.kernel.org" , linux-mmc , Lee Jones Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 6, 2020 at 9:03 AM wrote: > drivers/misc/cardreader/Makefile | 2 +- > drivers/misc/cardreader/rts5228.c | 740 +++++++++++++++++++++++++++++ > drivers/misc/cardreader/rts5228.h | 168 +++++++ > drivers/misc/cardreader/rtsx_pcr.c | 89 ++-- > drivers/misc/cardreader/rtsx_pcr.h | 5 + This drivers/misc/cardreader business is a big confusion for my mind. Is it really that fantastic that it needs to be a unique special case? To me it looks like a drivers/mfd thing which should have separate drivers/regulator/rts5228.c (LDOs) drivers/clk/rts5228.c (clocks) subdrivers. See for example drivers/mfd/sta2x11-mfd.c thay spawns a few devices off a PCI card. Yours, Linus Walleij