Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Jul 2020 07:29:23 -0700
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc:     linux-kernel@vger.kernel.org, Joel Fernandes <joelaf@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Marco Elver <elver@google.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        "Paul E. McKenney" <paulmck@kernel.org>, rcu@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>,
        "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Subject: Re: [PATCH RFC] rcu/segcblist: Add counters to segcblist
 datastructure
Message-ID: <20200720142923.mrudcweyttlmnhqp@linux-p48b>
References: <20200719034210.2382053-1-joel@joelfernandes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200719034210.2382053-1-joel@joelfernandes.org>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 18 Jul 2020, Joel Fernandes (Google) wrote:

>+/* Move from's segment length to to's segment. */
>+static void rcu_segcblist_move_seglen(struct rcu_segcblist *rsclp, int from, int to)
>+{
>+	long len = rcu_segcblist_get_seglen(rsclp, from);
>+
>+	if (!len || from == to)
>+		return;

Nit: You probably wanna do the parameter sanity checks before the
atomic_read.

Thanks,
Davidlohr