Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1808598ybh; Mon, 20 Jul 2020 07:46:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfrenMUpzR4ZrOlGScMN/duHTpYDgY8d+csG8q1ZtPUxahq9AJbjEGDOligRItmnanxBPs X-Received: by 2002:aa7:d5da:: with SMTP id d26mr10390098eds.248.1595256360780; Mon, 20 Jul 2020 07:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595256360; cv=none; d=google.com; s=arc-20160816; b=Tie+N+ZAVTFLPetx7tvmwBrij7K2OhONKyA0C93Jhu6pNTtOUVl0IRZBIXCzVpPuxm zFecKhlhE0XTxPE2I+kTgQOxKzGOzMYWgTYdWbSlLOjIdgqqlRSb7UG6U6ib9r4Uiaz7 KijfTUTDT8Ap3EDaWZ7W02fduvzL5VMNk6H9tNRuQA52AaI0zbB5YqeLTmAdnFnJVOAB LGZPa85xbx+PpxxW9/0pDza0Er3tBmESikqXtRutkE9XXX4zgC6Er59nigmWfsRqyk4I gAxku83gsZWw4nc7ugkWRgQz56RrdKSXoTd/hYDa/wHb3HRm+6iVga12VjS4YEhb+w6x 5hnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=C3fAHcvVg4jnZtoaiivjfSSE8o0hNzpTD9CyVyYtzCQ=; b=gOIfPWo0v/bFdnH8WhdcLFa1FQOQ1le96ZnAyo+MZfBdYJIohU4KgDMHQtlAXLjReo NDhs8Wdvivt4iAejPSuZLSKxG2PL6IfbG35oWujG4M/gcKwNJqcrQINgDbYbbQiNrlCz vIxue/39PKjsEy5EJHgFzrfn+vLtzqwSzpkkXrMKRn/Oc9e94yS1E7+2MaoylUTN70vR vHHGCzrewTwbXMdpgj7Z+cHe6CVJTeva17frtoIzdSakYWg/t84X96r3uTGg0+zGB76c 4K6lsvrcvK2LXlebaC2Rzc9RmhuZSN5thYSO5tuCarMSnYhyz0KD2pys2CAr8G6uubZd p3Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=sOlzDOWu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si10605855edn.164.2020.07.20.07.45.36; Mon, 20 Jul 2020 07:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=sOlzDOWu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbgGTOpH (ORCPT + 99 others); Mon, 20 Jul 2020 10:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgGTOpG (ORCPT ); Mon, 20 Jul 2020 10:45:06 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36205C061794 for ; Mon, 20 Jul 2020 07:45:06 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id 1so9152759pfn.9 for ; Mon, 20 Jul 2020 07:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C3fAHcvVg4jnZtoaiivjfSSE8o0hNzpTD9CyVyYtzCQ=; b=sOlzDOWuF+3RlEwNt2F5CrcNZqj5ddpZi3faZ9Bj9LGVNS+/HCg4ITjur/s9KGE8Um EErcgyT0YlA/Vt27osM+RlWCRgnYCvOrQ4GBds6LxWSoJswfyVQlYLuQQF68Dnlzhh/N R5CGaKX23fe1yNWLrh5YvObKYO5WeaPhCwMYmozzfak8l+EpGDYvzvQuF63JZrikisuH t2WnZ2wHL5+DY+e3BM/WH3zvaVAgJ9zjG/bN4CyIVFyvC8agiGULf1HyIpIdADzX9Ynj DqpxiUkonBkuuVA5KnJj8zC2eJ2/k5gQw5WXImWBYghWgRi1nRfPXZ1n3fOvYnehUEz7 56BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C3fAHcvVg4jnZtoaiivjfSSE8o0hNzpTD9CyVyYtzCQ=; b=eTtXCNl0lKWYoSxnK+SWF0UyYzBS58ttbrXnC4EFkZ1rOKu6NQ2AlteRyAvm4wKozU irmYFo34fB5SD7x6PyR45nyhGzCjMeTPKA/evbmX9/vcHfRZzzZIpcVSQq3+tdNWTDfm /cXo6Zv8m3MM5AIEpAVOwDmtYkiJyGe7h8n1LoRTG1nv520YrSRw0c/SFkakFF+vWw1r sXmuWa0v9zsWYaVOoCugZ94lUavd63a9Kx3oIJt6Pc27mIrzoJlqyhIXW0eqLta8HzDV cFLBxNeUhDRXLJp9LDqWArDwhhvrBvPnt6gSxspZU77iG1EtdV+cS1iTb3trKFvpZYYO pTlw== X-Gm-Message-State: AOAM530hT1j6YAF4LqPVeIIXFwVI38/58QFwKxZmrNXa2uvUOuBqDD5w WJfeChz0YMcqb7ugTT6YSl4s9Q== X-Received: by 2002:a63:7e55:: with SMTP id o21mr19414072pgn.263.1595256305771; Mon, 20 Jul 2020 07:45:05 -0700 (PDT) Received: from localhost.localdomain ([103.136.221.73]) by smtp.gmail.com with ESMTPSA id t13sm11951338pjs.17.2020.07.20.07.45.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jul 2020 07:45:04 -0700 (PDT) From: hexin To: dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, christian.koenig@amd.com, daniel@ffwll.ch, airlied@linux.ie, kraxel@redhat.com, Markus.Elfring@web.de, sumit.semwal@linaro.org Cc: linux-kernel@vger.kernel.org, hexin , Liu Qi Subject: [PATCH v2] drm/virtio: fixed memory leak in virtio_gpu_execbuffer_ioctl() Date: Mon, 20 Jul 2020 22:44:07 +0800 Message-Id: <20200720144407.13706-1-hexin.op@bytedance.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit synchronization") deleted dma_fence_put(), which will cause the memory leak. To balance the reference count initialized when allocating fence, dma_fence_put() should not be deleted. Fixes: 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit synchronization") Signed-off-by: Liu Qi Signed-off-by: hexin --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index 5df722072ba0..19c5bc01eb79 100644 --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c @@ -179,6 +179,7 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, vfpriv->ctx_id, buflist, out_fence); + dma_fence_put(&out_fence->f); virtio_gpu_notify(vgdev); return 0; -- 2.21.1 (Apple Git-122.3)