Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp33355ybh; Mon, 20 Jul 2020 09:38:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFs2WFhfsUWcRjh4NlgBSdeEDllp1aFmq70O9deqHjMOQTRkfkd0DsL78DUQRb+fIXoJMk X-Received: by 2002:a05:6402:30b2:: with SMTP id df18mr22480344edb.229.1595263110391; Mon, 20 Jul 2020 09:38:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595263110; cv=none; d=google.com; s=arc-20160816; b=oPPJH+Ho4x8xBN6rDDA7x5D4lA0HAhQLg/Mcjw68colcW/G4T+Ueq0Cj4vt5NJn3Uf zUxU7gQ7CJwhtErIWG9EwvrrQjSHKAqCskqHpkbl7XimjOvtVwcqZn/l6y8c6h2DKMKg vjcWcOf0jr21LIh7EmA6LO2Nd8diXeC1a64Pl0erC5DhTF8JHHSObmxSJQOTfEIib7WV VlX10d7TLNdOXS3yl0MjF2zo43+SZzbAZ/Q9f0N7jOEaR6q3curVgV18X998NVb9osiX hbB2BpdTOLoLEuRlOkGKZhnvAuMbWFIk0yg+v/spidbEAq06zJS9Zfk/MuLOb5uYjupc /7kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=FNFbiBPENBEfe71XEJ6gFCWMcE5oolIikIpymSXLtU8=; b=rbsIZe+6Nq2p49KcHUrqXabISyvaAmJaMdaeOfji4ws7SkXkKB9fhQHOu/AOFNmKhy GrcQn1BDis/Zql4E4wmKqlCVqo8J88xZr2DRpA3EWVc85PfxGTmg/GrgVPEHFOXJ6RE5 TDIKrq1q8x71BC2irBaZgCHoEzN4+ArZYseL5U9m2QMJBdRQ7CnVmSIG2qunCl4bBzFN 43fB6o5Rq/C1B/Vm4pSUvZ99g8Wf+KeRrC9KyBMDxr86SbFI/ys/xBtT8RIraZk2TwFv 7/JPUt8pZRQ0nGg/mGpIC4M1qbhf7+pBjSyDWHhP0zqGB5YfGQZBCyaYBrhclf2RFBFM 9Nbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ymSphsWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t27si7797157eji.205.2020.07.20.09.38.07; Mon, 20 Jul 2020 09:38:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ymSphsWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732214AbgGTQe1 (ORCPT + 99 others); Mon, 20 Jul 2020 12:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388992AbgGTQeN (ORCPT ); Mon, 20 Jul 2020 12:34:13 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 508C0C061794 for ; Mon, 20 Jul 2020 09:34:13 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id k6so13835833ili.6 for ; Mon, 20 Jul 2020 09:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FNFbiBPENBEfe71XEJ6gFCWMcE5oolIikIpymSXLtU8=; b=ymSphsWOGHRzYUqQryxfK6qsfrnfujA5wee3Do2OlMVkDKr0Gp5K3Y38NOoKGre2GR O1ajgs627gAJuTjFk+29V6vz9GtS1aGP33HNVJTZZeMYNhSOzoecUXvrRrVUGgRiVntF HimAl7avf1aE8KrJcJv9Q/5M6VbjdMoiigl6Lu0Xx+fGsClPF8ycOP9KoOC3mGHFlXUt X/5UAvigI8KnzOSKq4s6EpQ0fmO9/Tj+3Sr32irPtVPRy+By0RG4h9a8xkHIx3GE7VV6 4EAOcZAlOycxB+PZm0VsCikFb0OInGLzplxcj8yVySgNRXLBLqplmzWZUduyqc1BrWWy RdKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FNFbiBPENBEfe71XEJ6gFCWMcE5oolIikIpymSXLtU8=; b=DM4o98M7h5hnslB7cJ42DeopwoTYZIH2tykLLiuoSvmcoHWJiQZYGWjCKDLYAF4nVv F5tV4FPOvZQpqQfaZx1fA88UNM5s9FgnQZP3O5Qj187Lkge0ledFi/js+VOMtGraC1LS 7TlxhrtpEYsfCCYIWt6mt/IJNQ/lqxo/4Iy2sboY0X+Qd606b80hbSa1uhzKaJQ3dhtb lr4sQaU1rz9O7clJvc6JewpXsEU7lVmUOsTcCkC8nNERRKhhNrgzA4/114suL+fjgeKR ZF50bTxRmLnkyb8qCHGTsIr/YimoM1y9f2Koj1i1LdDGL3jVLGblriz5W1WctvGFMioc Stqw== X-Gm-Message-State: AOAM531NGtlzsfNuWnXDw85EreTS8SJ3NpBfUkfug6hRhnSA8hMvJiCA 5vxFSiYPCwxNbfT/ezAuJObmMA== X-Received: by 2002:a92:8982:: with SMTP id w2mr24108525ilk.163.1595262852660; Mon, 20 Jul 2020 09:34:12 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id n1sm9046568ilo.68.2020.07.20.09.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 09:34:12 -0700 (PDT) Subject: Re: [PATCH] bfq: fix blkio cgroup leakage To: Dmitry Monakhov , Paolo Valente Cc: LKML , linux-block@vger.kernel.org References: <20200702105751.20482-1-dmonakhov@gmail.com> <429E50C6-83BA-4A3F-BE9C-06C7C762AF33@linaro.org> <87k0zdrj7s.fsf@dmws.yandex.net> <545F1ABF-B2B2-4523-9259-D3F93A9BB330@linaro.org> <87h7uhqewn.fsf@dmws.yandex.net> <22087F19-BC93-447E-848A-109392E0622D@linaro.org> <87tuy2ml9j.fsf@dmws.yandex.net> From: Jens Axboe Message-ID: Date: Mon, 20 Jul 2020 10:34:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87tuy2ml9j.fsf@dmws.yandex.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/20 6:19 AM, Dmitry Monakhov wrote: > Ok you right, we should drop the group reference inside > __bfq_bfqd_reset_in_service() as we do for queue's entities. Please > see updated patch version. Can you please send that out as a proper v2? -- Jens Axboe