Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp33917ybh;
        Mon, 20 Jul 2020 09:39:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyRGUm1beTw9UVFMcypv1aaBg2dxzy1/KFMu9mmDAs1kS6mX81NTTzHEq+a30x3+GCiknkz
X-Received: by 2002:a17:906:4015:: with SMTP id v21mr4147696ejj.63.1595263162977;
        Mon, 20 Jul 2020 09:39:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1595263162; cv=none;
        d=google.com; s=arc-20160816;
        b=hQIqoYyutRvQdftEPTgmw41s9q4E9zoAucjrXt8QeJQAqwDiY3NtrQqkvElKxakXCu
         fI6da3VRhNfJjDnXR6TjgYgaqrcAyCFs6o8fEyAPfkq93KxbKojkv9jvVR1DOp8gMWeX
         fjz1yFucrAO8CFZvqnxBPkkSNsGqMdYaZl4czMZjERfm7R0HjgRO2cp1A0pfAolcynQt
         m1pW4kK6cmG5CC6GCYuNw5/EsXa71KznVP1H0lm0fQwu7ynIx9sGvpWweSIFQkwto0pK
         eBfJqph1yjW53pJ0NAOM5ImCBSqN5PSEBE2Tzx3YPitn6tlGNxXKr/0mTuEhkpF04iiX
         RCyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Y0bZYOg1d1EJBOpSBHiUjDo02WQDRKDZBBBZtcRjU7Y=;
        b=YACFlW4A+4H41GOswAYnVPbIj+wgFgq75wuIkKDNTwKNjioguZj6fHrui99OXGKPSD
         e3YLtVViTTvVrXWaeuZZoIxe2tO4nkdGjXJ3WKVgM8OFEMfnzw79EcoaSH35AT1+zNS9
         onFkMdyQjfaATdIhHNXZo2l97ydmWB4Bi3X/C+A2NMW3TPee40mYitQzIhwYVauCb0G2
         jPKoewyAP4bVC5ULKBD4SlR11YGmj39j+72tMOiziWr7s+SRqKJJbQsqOMHB9mIsXxaZ
         P3HvxihurR7pnxxMJa5A/5wrd8mlhfUxmQ8D6GpMf0qLTWkKnhQtyWWLF40C0NYJuSsu
         wvWA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=FYBCbTFU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id x6si11350297ejw.73.2020.07.20.09.39.00;
        Mon, 20 Jul 2020 09:39:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=FYBCbTFU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389010AbgGTQfQ (ORCPT <rfc822;huangweiredhat@gmail.com>
        + 99 others); Mon, 20 Jul 2020 12:35:16 -0400
Received: from mx4.wp.pl ([212.77.101.12]:33678 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731573AbgGTPye (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Jul 2020 11:54:34 -0400
Received: (wp-smtpd smtp.wp.pl 16606 invoked from network); 20 Jul 2020 17:54:30 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a;
          t=1595260471; bh=Y0bZYOg1d1EJBOpSBHiUjDo02WQDRKDZBBBZtcRjU7Y=;
          h=From:To:Cc:Subject;
          b=FYBCbTFUnDIBtbI8nTQmeLGktKbYGctKcXLK3jORi7mXETEucsm7LCdpr4Bf1uKX8
           bbYHCWx/1KOkegDqDqRBH/pctdGFLWPUKKjFjq5ON0hd/U10aiHTiJHn9vsPgTrx73
           9GR+tLSiaIUzFWokKbrx3Qq3gQwhVaQ05ylNKn3E=
Received: from unknown (HELO kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com) (kubakici@wp.pl@[163.114.132.7])
          (envelope-sender <kubakici@wp.pl>)
          by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP
          for <navid.emamdoost@gmail.com>; 20 Jul 2020 17:54:30 +0200
Date:   Mon, 20 Jul 2020 08:54:22 -0700
From:   Jakub Kicinski <kubakici@wp.pl>
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mt7601u: add missing release on skb in
 mt7601u_mcu_msg_send
Message-ID: <20200720085422.40539aa4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200718052630.11032-1-navid.emamdoost@gmail.com>
References: <20200718052630.11032-1-navid.emamdoost@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-WP-MailID: 86ad31f636f93e20d39630a6dd07675f
X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski
X-WP-SPAM: NO 0000001 [geJz]                               
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 18 Jul 2020 00:26:29 -0500 Navid Emamdoost wrote:
> In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be
> consumed on all execution paths. Release skb before returning if
> test_bit() fails.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>

Acked-by: Jakub Kicinski <kubakici@wp.pl>