Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Pg8cNMBg7YL1NxpdOMRjhqQS6Q4pss68FBPaUeE58a6HS7JifNypGtfcm4UwT3H3hl2k6Hxy0H
 eTSnu6C4o/Qg==
IronPort-SDR: FeV1Ux5i1iem2vnc64dDKx6Ziqs6/sZsAG1bw7r3/Zla48JOlEHvYoTxkUi6ekPk9jnWywChIw
 91yOKYw6dVdA==
From:   "Eads, Gage" <gage.eads@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>,
        "Topel, Bjorn" <bjorn.topel@intel.com>
Subject: RE: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Topic: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Index: AQHWWGU9Tth4ik4BzU63g7CSJsQmkakKx86wgAIl3ACAA+YfQA==
Date:   Mon, 20 Jul 2020 19:02:05 +0000
Message-ID: <SN6PR11MB25746161DC8D54AD5BD30F96F67B0@SN6PR11MB2574.namprd11.prod.outlook.com>
References: <20200712134331.8169-1-gage.eads@intel.com>
 <20200712134331.8169-2-gage.eads@intel.com>
 <20200712155810.GC186665@kroah.com>
 <SN6PR11MB2574E9B6F6957D765BC18F29F67C0@SN6PR11MB2574.namprd11.prod.outlook.com>
 <20200718064656.GB245355@kroah.com>
In-Reply-To: <20200718064656.GB245355@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fd26abda-deb0-4900-b2f7-08d82cdf6539
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 19:02:05.9275
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w+aq4dneuRZ2C7BL18IY1ISxjEDfRWVeExUn146vDcnydJgc6nocNF0vTUyyKxfrDMHF+iUQUp4TkqSYOm2qfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3534
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Saturday, July 18, 2020 1:47 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
>=20
> On Fri, Jul 17, 2020 at 06:18:46PM +0000, Eads, Gage wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Sunday, July 12, 2020 10:58 AM
> > > To: Eads, Gage <gage.eads@intel.com>
> > > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> > > <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> > > Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
> > >
> > > On Sun, Jul 12, 2020 at 08:43:12AM -0500, Gage Eads wrote:
> > > > +static int dlb2_probe(struct pci_dev *pdev,
> > > > +		      const struct pci_device_id *pdev_id) {
> > > > +	struct dlb2_dev *dlb2_dev;
> > > > +	int ret;
> > > > +
> > > > +	dev_dbg(&pdev->dev, "probe\n");
> > >
> > > ftrace is your friend.  Remove all of your debugging code now, you do=
n't
> need
> > > it anymore, especially for stuff like this where you didn't even need=
 it in
> the
> > > first place :(
> >
> > I'll remove this and other similar dev_dbg() calls. This was an oversig=
ht on
> my part.
> >
> > I have other instances that a kprobe can't easily replace, such as prin=
ting
> structure contents, that are useful for tracing the usage of the driver. =
It looks
> like other misc drivers use dev_dbg() similarly -- do you consider this a=
n
> acceptable use of a debug print?
>=20
> Why can't a kernel tracepoint print a structure?

I meant the command-line installed kprobes[1], but instrumenting the driver=
 is
certainly an option. We don't require the much lower overhead of a tracepoi=
nt,
so I didn't choose it. This driver handles the (performance-insensitive)
device configuration, while the fast-path operations take place in user-spa=
ce.

Another reason is the "hardware access library" files use only non-GPL exte=
rnal
symbols, and some tracepoint functions are exported GPL. Though it's probab=
ly
feasible to lift that tracing code up into a (GPLv2-only) caller function.

But if tracepoints are the preferred method and/or you think the driver wou=
ld
benefit, I'll make the change.

Thanks,
Gage

[1] https://www.kernel.org/doc/html/latest/trace/kprobetrace.html