Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp210897ybh; Mon, 20 Jul 2020 14:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcPGHz2SSbDEYQGG4s0yijGU/idfzSKK1xPsweEa7Aef1d9ADSSb7c4Tt3iP4IKfELQR/8 X-Received: by 2002:a05:6402:3064:: with SMTP id bs4mr23696589edb.350.1595281269470; Mon, 20 Jul 2020 14:41:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595281269; cv=none; d=google.com; s=arc-20160816; b=KmfQv9Ru8LYdf0+3ZsGeQD/OExbCsWEsrW0BNbAeL+7GVnmHHwk3UGjC0IN7bVjYwV W9Y/HCE3hAxt5Z820jQUXgfbWhn3OsLUBfNHZVWOt30JRRxoe3Q7n+ukgsoWQOqWIvhX aWNmEMbHV3g+k4WsVvrwNSyT6+zgPO8LwGCumbeUSkkyGsr0msYd02lnupyJe0cLFwjR l8OlnGxPGZpYvEMFlTQV4z8TYT4jAXiEWUqu2G8a5g91Mk7v1t8Y4q843MknvriJWfEQ R8+1GUfJh4W3ArDa2977g+h7fD1KYn92KK9S+d2TBtHacBbb3d1eA/iaD92aMsZ0RiNS YP5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+g2gp8qBPZq78TsIE6FdPXe3Sq/yWzgsxRT8xRfUf4o=; b=J6H2OqhZQe5wYv6T9xoT5t0cCg0hbqimWlYInEqTL9ZNmufZIJ7VUQ3N2Sx0Z4t8ZM PFdgkMExriSbga8GLndTL6uKksSiTAgkNLN78xrICLlJv3I0B/6+TJE1blg4iR+kf9PS k1XjrGIZU2Lw/OjsQhgJkzHPgUFMZW9+7NJgqMi7IuUUb31J0czpM4w1AMGSiA6w9e8/ H/HFu5F/qCjkeE0N54FXMJke76pkbaQt0eW+k1mbQReczB23mtdgr4yEEZ+VVoizHKVI l9HmKZsly93WNMFhSCr9OE+XImvCq3mWEte2skDe5CRhKRss2AZelP1Kcc43rbtNKBIC PRuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rH4yzy1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 12si11814887edx.70.2020.07.20.14.40.40; Mon, 20 Jul 2020 14:41:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rH4yzy1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728565AbgGTVjs (ORCPT + 99 others); Mon, 20 Jul 2020 17:39:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:58430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728391AbgGTVjM (ORCPT ); Mon, 20 Jul 2020 17:39:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E4F722CF7; Mon, 20 Jul 2020 21:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595281151; bh=kB41gXh/gK69Ub+thQTzV8vVMeVaJNEl8ZZLFyl95ZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rH4yzy1O0XQ9lMJKN+65EnrxjxJ2gGKtiIZAn4WMR38YIDRB1WV5u864WYW+L2vD0 imBJH9LkJOVk6FOOx8/JaecNG15o2NDVILFdlcClAC8pyV+mMFdK1K+BdTfE6Tm7ET kphsrzsnuCdGmL18BNNn2WF/mYqDPH+H9DB1Ocqg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Thomas Gleixner , Nick Desaulniers , Sasha Levin , clang-built-linux@googlegroups.com Subject: [PATCH AUTOSEL 4.19 17/19] x86: math-emu: Fix up 'cmp' insn for clang ias Date: Mon, 20 Jul 2020 17:38:48 -0400 Message-Id: <20200720213851.407715-17-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200720213851.407715-1-sashal@kernel.org> References: <20200720213851.407715-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 81e96851ea32deb2c921c870eecabf335f598aeb ] The clang integrated assembler requires the 'cmp' instruction to have a length prefix here: arch/x86/math-emu/wm_sqrt.S:212:2: error: ambiguous instructions require an explicit suffix (could be 'cmpb', 'cmpw', or 'cmpl') cmp $0xffffffff,-24(%ebp) ^ Make this a 32-bit comparison, which it was clearly meant to be. Signed-off-by: Arnd Bergmann Signed-off-by: Thomas Gleixner Reviewed-by: Nick Desaulniers Link: https://lkml.kernel.org/r/20200527135352.1198078-1-arnd@arndb.de Signed-off-by: Sasha Levin --- arch/x86/math-emu/wm_sqrt.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/math-emu/wm_sqrt.S b/arch/x86/math-emu/wm_sqrt.S index f031c0e193565..515cdee90df72 100644 --- a/arch/x86/math-emu/wm_sqrt.S +++ b/arch/x86/math-emu/wm_sqrt.S @@ -209,7 +209,7 @@ sqrt_stage_2_finish: #ifdef PARANOID /* It should be possible to get here only if the arg is ffff....ffff */ - cmp $0xffffffff,FPU_fsqrt_arg_1 + cmpl $0xffffffff,FPU_fsqrt_arg_1 jnz sqrt_stage_2_error #endif /* PARANOID */ -- 2.25.1