Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20200720082709.252805-1-pihsun@chromium.org>
References: <20200720082709.252805-1-pihsun@chromium.org>
Subject: Re: [PATCH] scripts/decode_stacktrace: Strip basepath from all paths.
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Pi-Hsun Shih <pihsun@chromium.org>, Shik Chen <shik@chromium.org>,
        Sasha Levin <sashal@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        linux-kernel@vger.kernel.org
To:     Pi-Hsun Shih <pihsun@chromium.org>
Date:   Mon, 20 Jul 2020 16:01:49 -0700
Message-ID: <159528610934.3847286.7269726046959428266@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Pi-Hsun Shih (2020-07-20 01:27:07)
> Currently the basepath is removed only from the beginning of the string.
> When the symbol is inlined and there's multiple line outputs of
> addr2line, only the first line would have basepath removed.
>=20
> Change to remove the basepath prefix from all lines.
>=20
> Fixes: 31013836a71e ("scripts/decode_stacktrace: match basepath using she=
ll prefix operator, not regex")
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> Co-developed-by: Shik Chen <shik@chromium.org>
> Signed-off-by: Shik Chen <shik@chromium.org>

I thought Co-developed-by and the other SoB came before your SoB.

> ---
>  scripts/decode_stacktrace.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

>=20
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index 66a6d511b524..0869def435ee 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -87,8 +87,8 @@ parse_symbol() {
>                 return
>         fi
> =20
> -       # Strip out the base of the path
> -       code=3D${code#$basepath/}
> +       # Strip out the base of the path on each line
> +       code=3D$(while read -r line; do echo "${line#$basepath/}"; done <=
<< "$code")
> =20
>         # In the case of inlines, move everything to same line
>         code=3D${code//$'\n'/' '}

Given that there's a while loop now maybe this line above could be
removed and the echo above replaced with a printf.