Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp266504ybh; Mon, 20 Jul 2020 16:18:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEKER4ngKpNDnUfE2JFM8YEoP57RbopNt/eTO10C8miEPNTJrNuOosH0Ox4q5rMO9Y25Ej X-Received: by 2002:a17:906:3a9b:: with SMTP id y27mr22628434ejd.38.1595287131250; Mon, 20 Jul 2020 16:18:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595287131; cv=none; d=google.com; s=arc-20160816; b=f5pQemhEqkN2ETBvdmifQWS2Jh9wAsAs60k26q17bFsLWwoXvbK9cw3NG8vtmOerc9 Cv4s+OQVHKdKLfNwCH244uA+d4acmlQROpnPDQxsjfsspf3e7nEZodZcLH/UAodqYYI0 N8w4zM9eysiXrUvak6fa9C6Ionh82GFDg1KU52Ul4GuQ1k30zfI8lU8FFovK7U3/hEJu g4Zp+9APah3BK1O8nswIT4X/sLXgJq3dB9YNn95sKM1qpPMV7W7UcPId2FHf3eNXfPwE iCTeUwho06srgPGodq5fcALD6ADS9GNdeqBP2ksIp72PePg07NHWS2nbslRW3hVmUusJ s/MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8mcYe68lcI9kFxF0lJH1BEeSrdP7/q4zDpyELU4MH/E=; b=GxmspJ5e5nKckkvcCVu6pTbR0Rq1rdM7g/gr4xwS84viZ3/HWPndl/Ak15gh5Vqldq 86m+2SRwWn9xlXvbCVaGZbwSknOcdaf0uvSrrxlKUafH/vR5HHf0EpYYcHiVz9+vCj4r BP5nxp0VpZ6N1MA6AMO/XP70rcijEQ7M4wiucVGrdNkbmPDhnwhCHd33bgloHNQ36x1P D/MAf8J0wjGcrPHAYahbkolxR8rlTITuJxJznaGE31DKfdxd2FHzQs/lvKxzsj1AAXdI wa72gfV6CHypBInGEYpOOQECs8sYmX9/cAVej8RolDX3hoc0fEM2u8MYhEVtYptXz5qT +rkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wJgArWmS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b21si10996031ejz.710.2020.07.20.16.18.28; Mon, 20 Jul 2020 16:18:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wJgArWmS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbgGTXQP (ORCPT + 99 others); Mon, 20 Jul 2020 19:16:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:44608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbgGTXQO (ORCPT ); Mon, 20 Jul 2020 19:16:14 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAFE6208E4; Mon, 20 Jul 2020 23:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595286974; bh=qn5ImIArU+1HeITNc4gt1jj04T1eJdhUcXyemQaZ9zs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wJgArWmSlPuVivt2wShIUZEM5HH922U1b3M/Nn9baMRmfs0ukwTdz0TCJvNeCQh6E 89kbI7ym0PHfy7lgBxSAyp1ggb4BDrYdwwQ8wrBpx63RsIN6YI7g1bN8XL2q2wtN9r KCo+2ge4lgy1J4nTAhc1amHVmMUW7YZ0YQqlaxbk= Date: Mon, 20 Jul 2020 16:16:13 -0700 From: Andrew Morton To: js1304@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm/page_alloc: fix non cma alloc context Message-Id: <20200720161613.15cddfdc2247377347f5471f@linux-foundation.org> In-Reply-To: <1595220978-9890-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1595220978-9890-1-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2020 13:56:15 +0900 js1304@gmail.com wrote: > Currently, preventing cma area in page allocation is implemented by using > current_gfp_context(). However, there are two problems of this > implementation. > > First, this doesn't work for allocation fastpath. In the fastpath, > original gfp_mask is used since current_gfp_context() is introduced in > order to control reclaim and it is on slowpath. > Second, clearing __GFP_MOVABLE has a side effect to exclude the memory > on the ZONE_MOVABLE for allocation target. > > To fix these problems, this patch changes the implementation to exclude > cma area in page allocation. Main point of this change is using the > alloc_flags. alloc_flags is mainly used to control allocation so it fits > for excluding cma area in allocation. What are the end user visible runtime effects of this change? This is pretty much essential information when proposing a -stable backport.