Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp270476ybh; Mon, 20 Jul 2020 16:26:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0oxpu+5EJOXYroIbtnAUD9PeWfSup4A6E5pVyHfzuJlC6B48yY0qYcWIEt3ButRfd5MoD X-Received: by 2002:a05:6402:1ef:: with SMTP id i15mr23498583edy.378.1595287560647; Mon, 20 Jul 2020 16:26:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595287560; cv=none; d=google.com; s=arc-20160816; b=LUsdgsh4DNhW73tC1OE0ZDaUXj9t3hW4aLVZrEvt+1m0CUj9v0W/oaED0ygOZugViw 8FcRmU68BsYgjTssGeLwNLFRIGlUzImnZ7jdtHqZY+x8n70M6TYB02rKtiIvqq+3uldR CEcmQAfDrEjSYJMzVH0FeSDwn5S4zsN7pswtw5SpNKgjdu3o8lFzca9OfMGysgWLM38B APAMfOtvNj3ClIFeLeshG8kIHUgAFI0oKYu6dNJWuSMXhNxHwgxTgMN1dsWBOAy1y08H 8Bo3lA5ZfDC+I/t54ROH9roTpNEvzyjbhrnN7wU3mP4WyPU1PPZ1ymLtJwyB+ZoALWO4 beCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=V+Vj4xLbBEE81s8rjMR9CO6Ug04gPKi1vTOJFJBASoI=; b=MCttjtGuhutaz4bQRduBCr6NVO+pn5vjOMZLsdUUlbC0l5kbO7bp9f5r3JxTY24Pjg dSTzpithwsnt/InPQKDMEJff9vnC7KhWvUD/5NLI27/m28zUpzdfA/Xg2YopMgoDqpMr JFTHF+xUOdYuz9waunC0NPUPLzpWDek2foP2DmQ19uVIkOuJ+K1Wt3go0+R7FXPIzRLu UY/ZS9EFEpubRIIIZ9qESnfeHpNpAuaR2a4tx/C1zHDrNG0o/Ec+pEaTZbWkT0fkPhBl nnCt15e8T1kCpTp5KAJcPInZ3jUDR6RmZ4BMCDRTk8lQhun8bT/LOQ4KwYcTsqGPnAQ7 MLZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jzXMKwtf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rs1si11407749ejb.64.2020.07.20.16.25.36; Mon, 20 Jul 2020 16:26:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jzXMKwtf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgGTXXP (ORCPT + 99 others); Mon, 20 Jul 2020 19:23:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:50194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgGTXXP (ORCPT ); Mon, 20 Jul 2020 19:23:15 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 497C32080D; Mon, 20 Jul 2020 23:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595287394; bh=CmjiBtNa6KB4IjS9/V99TRrvKhtZXBHGyuXzHFKf9oI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jzXMKwtfn5KFI0f04Uvy84IaDuRB8NTrky6Xp9lzKW3GFzqjGlpfUF0RVQRmSEpsD d5XeamDDBR0ktCVRI9C11mNj7NVPRE8sOHpSnsydSzAHnoGp+xmt7oEHXw/RG+PXyq 0SLcONObYH9PwSUwuqyBpGuAtUlwuDiEpghdysNA= Date: Mon, 20 Jul 2020 16:23:13 -0700 From: Andrew Morton To: js1304@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Michal Hocko , "Aneesh Kumar K . V" , Joonsoo Kim , stable@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm/page_alloc: fix non cma alloc context Message-Id: <20200720162313.1381e1ec82daa6a92ae4cda7@linux-foundation.org> In-Reply-To: <1595220978-9890-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1595220978-9890-1-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2020 13:56:15 +0900 js1304@gmail.com wrote: > Currently, preventing cma area in page allocation is implemented by using > current_gfp_context(). However, there are two problems of this > implementation. > > First, this doesn't work for allocation fastpath. In the fastpath, > original gfp_mask is used since current_gfp_context() is introduced in > order to control reclaim and it is on slowpath. > Second, clearing __GFP_MOVABLE has a side effect to exclude the memory > on the ZONE_MOVABLE for allocation target. > > To fix these problems, this patch changes the implementation to exclude > cma area in page allocation. Main point of this change is using the > alloc_flags. alloc_flags is mainly used to control allocation so it fits > for excluding cma area in allocation. > > Fixes: d7fefcc8de91 (mm/cma: add PF flag to force non cma alloc) > Cc: This patch is against linux-next (or -mm) and has a lot of issues applying to mainline. If we indeed wish to backport it to -stable, it should be against mainline, please.