Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp271622ybh; Mon, 20 Jul 2020 16:28:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGhKxO926ABiFa3+tE15eV1b9iWooC+vSS9GOavtGP83i/Gi2u5AvgUYk6sC28G1+VfOxF X-Received: by 2002:a05:6402:8da:: with SMTP id d26mr23938281edz.109.1595287691175; Mon, 20 Jul 2020 16:28:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595287691; cv=none; d=google.com; s=arc-20160816; b=UnFPhDXdl2J81FVwS5xiPfg7WsYbmerUazhDcWZgtMK52AFH1ER0AjTvwg6OYwSRZm JPyRD72fSSSV/x71/AubIFh9D/SXS7UcRVb8Jjv7edXUZroFU+o4I8BdmleFLRDp8/rp 7xfkVEuXd++tHx1oHARKQf6lT938t9ui2FrV6U+BDXIC1P0DmKBh+FgdshpmlECIT+p1 4Ok+r8s6Bm1ihB3Ap5FxpGLJ9OerTVahK4DpKXc6jYNbxXcVL4ryZgFhBpfbASepxxAf wPuy2MPSNPlK7YEqnqvqOnBtKVaEVAXd4Qp8Cjhv7ZOGJsLeuVmY5ESOZV9kYTZdToWG y9mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=UbGTV9A1S5gYzXuEuCHbDgZeIunIQsQAjbdAq03+QHI=; b=oLNLiiAsgNZ4/AVgqoOIxbpbd0IJG7/t2N+HCeuCONVt8HjKDXP77QjVsu8ud0QjEj lYTvv19iuuDFZQhvcmsiBnffrAhF8G9aBwOQ9c+RiXY3JgAGDJN/VI6wxU58ErdhAz1R yPOCOno6dur3a2V4qiOczF+dJ9CUPWAI0501eoP+JKrmATknmCcsJ3Y3G7Y7CsQykbaX sg8IPABjkooqOmiwba66ITE3czkOtjNCjPBLoHNByc+He2g17+ekzHaQkehNYsCsjVin wP8DNhXJEsaguKKuPgpGR+GYmtfzRd9aNrQaD2wYgZ9nl5vN5cKsS/rIzWxdJkbco2Pi V++g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rs1si11407749ejb.64.2020.07.20.16.27.48; Mon, 20 Jul 2020 16:28:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726782AbgGTX12 (ORCPT + 99 others); Mon, 20 Jul 2020 19:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgGTX12 (ORCPT ); Mon, 20 Jul 2020 19:27:28 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBD7DC061794; Mon, 20 Jul 2020 16:27:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1C82311E8EC0A; Mon, 20 Jul 2020 16:27:27 -0700 (PDT) Date: Mon, 20 Jul 2020 16:27:26 -0700 (PDT) Message-Id: <20200720.162726.1756372964350832473.davem@davemloft.net> To: srirakr2@cisco.com Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, mbumgard@cisco.com, ugm@cisco.com, nimm@cisco.com, xe-linux-external@cisco.com, kuba@kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver From: David Miller In-Reply-To: <20200720164551.14153-1-srirakr2@cisco.com> References: <20200720164551.14153-1-srirakr2@cisco.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 16:27:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sriram Krishnan Date: Mon, 20 Jul 2020 22:15:51 +0530 > + if (skb->protocol == htons(ETH_P_8021Q)) { > + u16 vlan_tci = 0; > + skb_reset_mac_header(skb); Please place an empty line between basic block local variable declarations and actual code. > + netdev_err(net,"Pop vlan err %x\n",pop_err); A space is necessary before "pop_err".