Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp312898ybh; Mon, 20 Jul 2020 17:45:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUIgaPUAomqZouPrMp4cPjF24Vv7EyJ6lNnZAoJ6XWb8YveN4rHDjDgZTyLNd0hSYxwF6R X-Received: by 2002:a17:906:2b52:: with SMTP id b18mr23501388ejg.158.1595292308265; Mon, 20 Jul 2020 17:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595292308; cv=none; d=google.com; s=arc-20160816; b=GkRqijcXW0wVuzjYQykbLr7Qk6m8WNgt4m2QYvhW1sVSgkchOlgxsS3tSDA1QDMDZz pmBSe5sOwNKcoDNgqwE6eVTpfFaaeueWzTzdHaVvQMW928O5P5poYROAE0ffQkeBz+/U VpwAaJh/4hLU69uV2SvdUzOQg21pRfz+aWleS2k/sENoJOaWnvhyPZITUSY2nrNp4bgy WhTBHE4dniEmViCfnmmiCKKEvAPzceRHen+aEJzqx2zPmCVfaizyD0f7wIiWvTVltpNs 5ZEi6N6/1zveRFLKmS1Y5bEAyGjznhW7V85Gx4bZnDG3lL3YeVbLZy1SYqlymfQrcdOh ocfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=G8h0rN4ACweZJTW2ex4FcEkf4yRht74fiM/V6S7LraU=; b=ejlqhm1WS03iwfVbpB8GzSMbPWeZqJXsHvwt2nBqA/26ueHrvpk8Qep6YLp1nJK2Il 94Q5/XuaI3kCHR//XSQZzd8ssneNB2AFgN/DDJZcprEMOxWZg2eucAxOh0fl3lyUP3SE YOPBmIfmTJMtJ06kysVaYIdDasvEwhXwscvfahLxuwASjyNi7j6Ie82mA3DsOOtWLcXZ Q25ZoQ7h2IzwQH6zemYk9yHApyIO0meoWduzLIHg8euhEZPa1E+W3ZbWIcFwjdoXMPAD LL/HANozmJoZat9nkXcZNMg1iRpU7WjrBwc6GlcJDGvgPL3n/XNMtQ7nxVTPXlnNif4e 8jog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si11414713ejs.541.2020.07.20.17.44.45; Mon, 20 Jul 2020 17:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbgGUAoe (ORCPT + 99 others); Mon, 20 Jul 2020 20:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgGUAoe (ORCPT ); Mon, 20 Jul 2020 20:44:34 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36E3FC061794; Mon, 20 Jul 2020 17:44:34 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D651311E8EC0A; Mon, 20 Jul 2020 17:27:48 -0700 (PDT) Date: Mon, 20 Jul 2020 17:44:32 -0700 (PDT) Message-Id: <20200720.174432.702526374205425580.davem@davemloft.net> To: wangxiongfeng2@huawei.com Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs From: David Miller In-Reply-To: <1595243869-57100-1-git-send-email-wangxiongfeng2@huawei.com> References: <1595243869-57100-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 17:27:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang Date: Mon, 20 Jul 2020 19:17:49 +0800 > - return sprintf(buf, "%lu", trans_timeout); > + return sprintf(buf, "%lu\n", trans_timeout); Better to replace it with 'fmt_ulong'.