Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     "Franck Lenormand (OSS)" <franck.lenormand@oss.nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux@rempel-privat.de" <linux@rempel-privat.de>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: RE: [PATCH 1/7] firmware: imx: scu-rm: Add Resource Management APIs
Thread-Topic: [PATCH 1/7] firmware: imx: scu-rm: Add Resource Management APIs
Thread-Index: AQHWXnUJI44NmvM5HEauy2uyJtPrIqkRPiZQ
Date:   Tue, 21 Jul 2020 01:24:08 +0000
Message-ID: <DB6PR0402MB27605C7B70DCB03EDE3BF6A588780@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <1595235977-106241-1-git-send-email-franck.lenormand@oss.nxp.com>
 <1595235977-106241-2-git-send-email-franck.lenormand@oss.nxp.com>
In-Reply-To: <1595235977-106241-2-git-send-email-franck.lenormand@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b70fc30-e790-4670-e98b-08d82d14c401
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 01:24:08.2741
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U1VYPi8d/mPE3MHtCXjPmgZypBuXyK7BjVmdZxWE9llkLt+7XwjTJCQoEz7ddqPHKqHNp7U3G2gDyOu6KhkkNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3128
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Franck,

> Subject: [PATCH 1/7] firmware: imx: scu-rm: Add Resource Management APIs

Are you using an old base? This was already in tree.

Regards,
Peng.

>=20
> From: Franck LENORMAND <franck.lenormand@oss.nxp.com>
>=20
> This patch adds the imx_sc_rm_is_resource_owned indicating if a specific
> resource is owned by the caller.
>=20
> Signed-off-by: Franck LENORMAND <franck.lenormand@oss.nxp.com>
> ---
>  drivers/firmware/imx/Makefile       |  2 +-
>  drivers/firmware/imx/rm.c           | 44 +++++++++++++++++++++++
>  include/linux/firmware/imx/sci.h    |  1 +
>  include/linux/firmware/imx/svc/rm.h | 69
> +++++++++++++++++++++++++++++++++++++
>  4 files changed, 115 insertions(+), 1 deletion(-)  create mode 100644
> drivers/firmware/imx/rm.c  create mode 100644
> include/linux/firmware/imx/svc/rm.h
>=20
> diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefil=
e
> index 08bc9dd..17ea361 100644
> --- a/drivers/firmware/imx/Makefile
> +++ b/drivers/firmware/imx/Makefile
> @@ -1,4 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_IMX_DSP)		+=3D imx-dsp.o
> -obj-$(CONFIG_IMX_SCU)		+=3D imx-scu.o misc.o imx-scu-irq.o
> +obj-$(CONFIG_IMX_SCU)		+=3D imx-scu.o misc.o imx-scu-irq.o rm.o
>  obj-$(CONFIG_IMX_SCU_PD)	+=3D scu-pd.o
> diff --git a/drivers/firmware/imx/rm.c b/drivers/firmware/imx/rm.c new fi=
le
> mode 100644 index 00000000..a397c6b
> --- /dev/null
> +++ b/drivers/firmware/imx/rm.c
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2020 NXP
> + *
> + * File containing client-side RPC functions for the RM service. These
> + * functions are ported to clients that communicate to the SC.
> + */
> +
> +#include <linux/firmware/imx/svc/rm.h>
> +
> +struct imx_sc_msg_rm_rsrc_owned {
> +	struct imx_sc_rpc_msg hdr;
> +	u16 resource;
> +} __packed __aligned(4);
> +
> +/**
> + * imx_sc_rm_is_resource_owned() - Checks @resource is owned by current
> + * partition or not
> + *
> + * @ipc: IPC handle
> + * @resource: resource the control is associated with
> + *
> + * Return:
> + * 0 - OK
> + * < 0 - error.
> + */
> +bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource)
> +{
> +	struct imx_sc_msg_rm_rsrc_owned msg;
> +	struct imx_sc_rpc_msg *hdr =3D &msg.hdr;
> +
> +	hdr->ver =3D IMX_SC_RPC_VERSION;
> +	hdr->svc =3D IMX_SC_RPC_SVC_RM;
> +	hdr->func =3D IMX_SC_RM_FUNC_IS_RESOURCE_OWNED;
> +	hdr->size =3D 2;
> +
> +	msg.resource =3D resource;
> +
> +	imx_scu_call_rpc(ipc, &msg, true);
> +
> +	return hdr->func;
> +}
> +EXPORT_SYMBOL(imx_sc_rm_is_resource_owned);
> diff --git a/include/linux/firmware/imx/sci.h
> b/include/linux/firmware/imx/sci.h
> index 3fa418a..3c459f5 100644
> --- a/include/linux/firmware/imx/sci.h
> +++ b/include/linux/firmware/imx/sci.h
> @@ -14,6 +14,7 @@
>=20
>  #include <linux/firmware/imx/svc/misc.h>  #include
> <linux/firmware/imx/svc/pm.h>
> +#include <linux/firmware/imx/svc/rm.h>
>=20
>  int imx_scu_enable_general_irq_channel(struct device *dev);  int
> imx_scu_irq_register_notifier(struct notifier_block *nb); diff --git
> a/include/linux/firmware/imx/svc/rm.h
> b/include/linux/firmware/imx/svc/rm.h
> new file mode 100644
> index 00000000..9924216
> --- /dev/null
> +++ b/include/linux/firmware/imx/svc/rm.h
> @@ -0,0 +1,69 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright (C) 2016 Freescale Semiconductor, Inc.
> + * Copyright 2017-2020 NXP
> + *
> + * Header file containing the public API for the System Controller (SC)
> + * Power Management (PM) function. This includes functions for power
> +state
> + * control, clock control, reset control, and wake-up event control.
> + *
> + * RM_SVC (SVC) Resource Management Service
> + *
> + * Module for the Resource Management (RM) service.
> + */
> +
> +#ifndef _SC_RM_API_H
> +#define _SC_RM_API_H
> +
> +#include <linux/firmware/imx/sci.h>
> +
> +/*
> + * This type is used to indicate RPC RM function calls.
> + */
> +enum imx_sc_rm_func {
> +	IMX_SC_RM_FUNC_UNKNOWN =3D 0,
> +	IMX_SC_RM_FUNC_PARTITION_ALLOC =3D 1,
> +	IMX_SC_RM_FUNC_SET_CONFIDENTIAL =3D 31,
> +	IMX_SC_RM_FUNC_PARTITION_FREE =3D 2,
> +	IMX_SC_RM_FUNC_GET_DID =3D 26,
> +	IMX_SC_RM_FUNC_PARTITION_STATIC =3D 3,
> +	IMX_SC_RM_FUNC_PARTITION_LOCK =3D 4,
> +	IMX_SC_RM_FUNC_GET_PARTITION =3D 5,
> +	IMX_SC_RM_FUNC_SET_PARENT =3D 6,
> +	IMX_SC_RM_FUNC_MOVE_ALL =3D 7,
> +	IMX_SC_RM_FUNC_ASSIGN_RESOURCE =3D 8,
> +	IMX_SC_RM_FUNC_SET_RESOURCE_MOVABLE =3D 9,
> +	IMX_SC_RM_FUNC_SET_SUBSYS_RSRC_MOVABLE =3D 28,
> +	IMX_SC_RM_FUNC_SET_MASTER_ATTRIBUTES =3D 10,
> +	IMX_SC_RM_FUNC_SET_MASTER_SID =3D 11,
> +	IMX_SC_RM_FUNC_SET_PERIPHERAL_PERMISSIONS =3D 12,
> +	IMX_SC_RM_FUNC_IS_RESOURCE_OWNED =3D 13,
> +	IMX_SC_RM_FUNC_GET_RESOURCE_OWNER =3D 33,
> +	IMX_SC_RM_FUNC_IS_RESOURCE_MASTER =3D 14,
> +	IMX_SC_RM_FUNC_IS_RESOURCE_PERIPHERAL =3D 15,
> +	IMX_SC_RM_FUNC_GET_RESOURCE_INFO =3D 16,
> +	IMX_SC_RM_FUNC_MEMREG_ALLOC =3D 17,
> +	IMX_SC_RM_FUNC_MEMREG_SPLIT =3D 29,
> +	IMX_SC_RM_FUNC_MEMREG_FRAG =3D 32,
> +	IMX_SC_RM_FUNC_MEMREG_FREE =3D 18,
> +	IMX_SC_RM_FUNC_FIND_MEMREG =3D 30,
> +	IMX_SC_RM_FUNC_ASSIGN_MEMREG =3D 19,
> +	IMX_SC_RM_FUNC_SET_MEMREG_PERMISSIONS =3D 20,
> +	IMX_SC_RM_FUNC_IS_MEMREG_OWNED =3D 21,
> +	IMX_SC_RM_FUNC_GET_MEMREG_INFO =3D 22,
> +	IMX_SC_RM_FUNC_ASSIGN_PAD =3D 23,
> +	IMX_SC_RM_FUNC_SET_PAD_MOVABLE =3D 24,
> +	IMX_SC_RM_FUNC_IS_PAD_OWNED =3D 25,
> +	IMX_SC_RM_FUNC_DUMP =3D 27,
> +};
> +
> +#if IS_ENABLED(CONFIG_IMX_SCU)
> +bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc *ipc, u16 resource);
> +#else static inline bool imx_sc_rm_is_resource_owned(struct imx_sc_ipc
> +*ipc, u16 resource) {
> +	return true;
> +}
> +#endif
> +#endif
> --
> 2.7.4