Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     "Franck Lenormand (OSS)" <franck.lenormand@oss.nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux@rempel-privat.de" <linux@rempel-privat.de>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: RE: [PATCH 2/7] firmware: imx: scu: Support reception of messages of
 any size
Thread-Topic: [PATCH 2/7] firmware: imx: scu: Support reception of messages of
 any size
Thread-Index: AQHWXnUKNidKtJvMjkK/gc7U1xxq1akRPnhg
Date:   Tue, 21 Jul 2020 01:25:17 +0000
Message-ID: <DB6PR0402MB27609873F3C0183D022674A088780@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <1595235977-106241-1-git-send-email-franck.lenormand@oss.nxp.com>
 <1595235977-106241-3-git-send-email-franck.lenormand@oss.nxp.com>
In-Reply-To: <1595235977-106241-3-git-send-email-franck.lenormand@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0229f830-2473-4083-43c3-08d82d14ed0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 01:25:17.1435
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lg7X/o+bJhMvralnwJsU3ZGFtKpQO2gUCX7qTzaQP+FB1DLzdyPaxBj2y1iItYMbEbX5gJDP1M0M42ZqajD9dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3128
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH 2/7] firmware: imx: scu: Support reception of messages of
> any size

Could fast_ipc be used for your case? I am not fans to use the legacy metho=
d
which is error prone.

Thanks,
Peng.

>=20
> From: Franck LENORMAND <franck.lenormand@nxp.com>
>=20
> The word of a message can arrive in any order and the current driver cann=
ot
> receive more than 4-word message.
>=20
> To fix this, a new variable rx_pos is added to imx_sc_chan structure to s=
ave
> the position at which the word receive must be stored.
>=20
> The position is initialized by the index of the channel.
>=20
> The position is incremented by SCU_MU_RX_CHAN_NUM each time a word
> is received on the channel.
>=20
> This allow the words to be received in any order and be stored in the
> expected order.
>=20
> Signed-off-by: Franck LENORMAND <franck.lenormand@oss.nxp.com>
> ---
>  drivers/firmware/imx/imx-scu.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-sc=
u.c
> index 2ab0482..7c13595 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - * Copyright 2018 NXP
> + * Copyright 2018,2020 NXP
>   *  Author: Dong Aisheng <aisheng.dong@nxp.com>
>   *
>   * Implementation of the SCU IPC functions using MUs (client side).
> @@ -19,6 +19,8 @@
>  #include <linux/of_platform.h>
>  #include <linux/platform_device.h>
>=20
> +#define SCU_MU_TX_CHAN_NUM		4
> +#define SCU_MU_RX_CHAN_NUM		4
>  #define SCU_MU_CHAN_NUM		8
>  #define MAX_RX_TIMEOUT		(msecs_to_jiffies(30))
>=20
> @@ -29,6 +31,7 @@ struct imx_sc_chan {
>  	struct mbox_chan *ch;
>  	int idx;
>  	struct completion tx_done;
> +	u8 rx_pos;
>  };
>=20
>  struct imx_sc_ipc {
> @@ -136,16 +139,14 @@ static void imx_scu_rx_callback(struct mbox_client
> *c, void *msg)
>  		return;
>  	}
>=20
> -	if (sc_chan->idx =3D=3D 0) {
> +	if (sc_chan->rx_pos =3D=3D 0) {
>  		hdr =3D msg;
>  		sc_ipc->rx_size =3D hdr->size;
>  		dev_dbg(sc_ipc->dev, "msg rx size %u\n", sc_ipc->rx_size);
> -		if (sc_ipc->rx_size > 4)
> -			dev_warn(sc_ipc->dev, "RPC does not support receiving over 4
> words: %u\n",
> -				 sc_ipc->rx_size);
>  	}
>=20
> -	sc_ipc->msg[sc_chan->idx] =3D *data;
> +	sc_ipc->msg[sc_chan->rx_pos] =3D *data;
> +	sc_chan->rx_pos +=3D SCU_MU_RX_CHAN_NUM;
>  	sc_ipc->count++;
>=20
>  	dev_dbg(sc_ipc->dev, "mu %u msg %u 0x%x\n", sc_chan->idx, @@
> -205,6 +206,7 @@ int imx_scu_call_rpc(struct imx_sc_ipc *sc_ipc, void *ms=
g,
> bool have_resp)
>  	uint8_t saved_svc, saved_func;
>  	struct imx_sc_rpc_msg *hdr;
>  	int ret;
> +	int i;
>=20
>  	if (WARN_ON(!sc_ipc || !msg))
>  		return -EINVAL;
> @@ -212,6 +214,13 @@ int imx_scu_call_rpc(struct imx_sc_ipc *sc_ipc, void
> *msg, bool have_resp)
>  	mutex_lock(&sc_ipc->lock);
>  	reinit_completion(&sc_ipc->done);
>=20
> +	/* Set the indexes for the reception chans */
> +	for (i =3D SCU_MU_TX_CHAN_NUM; i < SCU_MU_CHAN_NUM; i++) {
> +		struct imx_sc_chan *sc_chan =3D &sc_ipc->chans[i];
> +
> +		sc_chan->rx_pos =3D sc_chan->idx;
> +	}
> +
>  	if (have_resp) {
>  		sc_ipc->msg =3D msg;
>  		saved_svc =3D ((struct imx_sc_rpc_msg *)msg)->svc;
> --
> 2.7.4