Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp338706ybh; Mon, 20 Jul 2020 18:32:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg8wbuRG2RITZX1D7BJQvfWyWZxawsF5o8tuiPjjgwBQdtA0ChoqqEXBO0aNVjJn01hHig X-Received: by 2002:a05:6402:31ad:: with SMTP id dj13mr23868570edb.88.1595295130718; Mon, 20 Jul 2020 18:32:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595295130; cv=none; d=google.com; s=arc-20160816; b=Hp8QDsIsUby6mWpef+E4wsNA6ANE5Tzf6gtP/16VH2PTZUi8yqVEXfOM0hkvK0NI7/ wUgkZdnBxDw3GdPzH4pB+Z5/SsqPOilpsjrtRSLmCagU7iRsVCFL1pWkyBoAv76/NQ8l IdAyMQW+8RLmcF3gO9fexupjTlKbsGKAM8Doags69pNwfaVLBso4xBv+1UP6YJ4ofaXX WFsaAZS2B6+uSCxnvOiFbyP1gJMIyTjT7XBqsMVy02QPo4xDBqyj01Aqxm6epOhXaNv9 GJ0IS0llJk5RNsjKeqH4r9fxVrzUK9rVMQMcehmzSAGdlKVvVTAfro7U6N2+uE9ri5G9 oSuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=KRg0SqS8TPwBtkUTkA0949a96gZskSGGdpjsgd0er7Q=; b=vvRsoG7hdKmkC35dQb/9VoVTSmlda4g40TWFgyqdzKR9Ho2e68acV19VULzEc60YGF ymQbx+6HeS+CzlJKMVaOEsvwjC4d7Th3a8yBZoBEvKPntDMmlH4GUz/FzB9laIR8G/HL JdiJnLDxAgTIhJ1avq6VEQCjrNrnAUpLGS93A7uYF1cKQs8eMgA/c51rYuI7JIJHLW1K Umn5higqjQd4XYDYeGhDCdmpCfYEuoQjyR95xOe2/ncOfCM8egCVixy6pLT477PN0ZZ3 pYfXbbleL3WJCGkZt1wylosuoidU50jGOVdfV9rGrZqHoZ7sul7QoX1a6smJa2VYHi23 ZZTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq21si11814255ejb.301.2020.07.20.18.31.47; Mon, 20 Jul 2020 18:32:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgGUBbO (ORCPT + 99 others); Mon, 20 Jul 2020 21:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgGUBbO (ORCPT ); Mon, 20 Jul 2020 21:31:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B408C061794; Mon, 20 Jul 2020 18:31:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E513011FFCC36; Mon, 20 Jul 2020 18:14:28 -0700 (PDT) Date: Mon, 20 Jul 2020 18:31:13 -0700 (PDT) Message-Id: <20200720.183113.2100585349998522874.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: vishal@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu Subject: Re: [PATCH] cxgb4: add missing release on skb in uld_send() From: David Miller In-Reply-To: <20200718051845.10218-1-navid.emamdoost@gmail.com> References: <20200718051845.10218-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 18:14:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Sat, 18 Jul 2020 00:18:43 -0500 > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c > index 32a45dc51ed7..d8c37fd4b808 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c > @@ -2938,6 +2938,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb, > txq_info = adap->sge.uld_txq_info[tx_uld_type]; > if (unlikely(!txq_info)) { > WARN_ON(true); > + consume_skb(skb); > return NET_XMIT_DROP; > } > This is a packet drop so kfree_skb() is more appropriate here.