Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp342109ybh; Mon, 20 Jul 2020 18:39:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8FfHAsnkMCAtLsZrlWrw16insFK9UJpf0PEO9/euMZDXm2TcnMFYa/178aDwvN+dxikml X-Received: by 2002:a17:906:f94c:: with SMTP id ld12mr24023902ejb.426.1595295566996; Mon, 20 Jul 2020 18:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595295566; cv=none; d=google.com; s=arc-20160816; b=wTeOGDBBV9H+q74XxbSKlUjyMiCVhxITjjmEyHZAv4BBJzepGyiYCn4ydHTJsOmjQx u2lJoGGoGsQ17C/dm709HpuJGzp8l5kEm2U/9ZJmm6ZEoFZ66Po7jLkVMzLHONfG6kWx 10X2zNn68an2+RAmQARdZ2c2kg4koBz4DTGJbmfwmgvD8eCfHyTtFkkwJRqZXcSLPtvF Zj2KXi3Fwh1gLUsx+90efw0tpLG/L/I5/9SUuzDcxhLna4yCPtXqwiUH0jaJUlu5wR/h JRWZ2ffUm77X0pANZruKhOBV3FDx7yVBdWTEaURMFj95hU4IgDsUPuSiJHbQsEnJviJX 1p5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=0TukXZSIzjBhtPFZz7DMunTkocui6aLaAFwZF2doq+A=; b=XP15+ooWrtyUHLNEg3Y2ssuueAlmaPzzqNbaLrwabq0hl3eb3oi9EjO80NLANtSkfI pE6D20+CNsF3aDD/kGLIgTrhbbKF26nnioFS0O4gpo8232eVlTfwcJTEimAV/FNB5C1z yoDGxgbM2Xq7/y4x9j6OklsyNzMI86yAMLZvQveKpn86EyCD2/oeRjW318zq6Be/IKl5 lv3sOANgk00UMGrSqceGIrhWhC2AcjFjN9P2dK/euqT0CiLSJWnEut3b7a2l3M2ve2dy Ecnl7KWhcka3Yc3KOWA48x0/7DudY11hbGM3PzGemp6b6YFzb1xTZF74LvWxoIjs1231 MhWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op20si7760857ejb.717.2020.07.20.18.39.03; Mon, 20 Jul 2020 18:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726673AbgGUBiv (ORCPT + 99 others); Mon, 20 Jul 2020 21:38:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgGUBiv (ORCPT ); Mon, 20 Jul 2020 21:38:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F28ACC061794; Mon, 20 Jul 2020 18:38:50 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9016811FFCC52; Mon, 20 Jul 2020 18:22:05 -0700 (PDT) Date: Mon, 20 Jul 2020 18:38:49 -0700 (PDT) Message-Id: <20200720.183849.626605331445628040.davem@davemloft.net> To: cuibixuan@huawei.com Cc: stephen@networkplumber.org, kuba@kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jdmason@kudzu.us, christophe.jaillet@wanadoo.fr, john.wanghui@huawei.com Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX From: David Miller In-Reply-To: <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> References: <20200716173247.78912-1-cuibixuan@huawei.com> <20200719100522.220a6f5a@hermes.lan> <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 18:22:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bixuan Cui Date: Mon, 20 Jul 2020 09:58:39 +0800 > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056 bytes is larger than 1024 bytes > > Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't > have much impact on performance and functionality. > > Signed-off-by: Bixuan Cui > Signed-off-by: Stephen Hemminger > --- > v2: Dropping the NR_SKB_COMPLETED to 16. Applied.