Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1595214246.git.huangqiwu@xiaomi.com> <20200720082100.GA720171@kroah.com>
In-Reply-To: <20200720082100.GA720171@kroah.com>
From:   ivan <yanziily@gmail.com>
Date:   Tue, 21 Jul 2020 11:12:32 +0800
Message-ID: <CAPtXDt39QMWE5jYeszBD8z9P_BHgwZ86wArpCEafC_Xx+hjKLQ@mail.gmail.com>
Subject: Re: [PATCH v4 0/4] add some power supply properties about
 wireless/wired charging
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com,
        Qiwu Huang <huangqiwu@xiaomi.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Greg KH <gregkh@linuxfoundation.org> =E4=BA=8E2020=E5=B9=B47=E6=9C=8820=E6=
=97=A5=E5=91=A8=E4=B8=80 =E4=B8=8B=E5=8D=884:20=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, Jul 20, 2020 at 01:47:13PM +0800, Qiwu Huang wrote:
> > From: Qiwu Huang <huangqiwu@xiaomi.com>
> >
> > quick_charge_type reports quick charge type based on charging power.
> > tx_adapter shows wireless charging adapter type.
> > signal_strength shows degree of coupling between tx and rx when wireles=
s charging.
> > reverse_chg_mode supply interface to enable/disable wireless reverse ch=
arging.
> >
> > Qiwu Huang (4):
> >   power: supply: core: add quick charge type property
> >   power: supply: core: add wireless charger adapter type property
> >   power: supply: core: add wireless signal strength property
> >   power: supply: core: property to control reverse charge
>
> What changed from the previous versions of this series?  Normally you
> either include that in the 0/X email, or in the individual patches.  I
> don't see that in either place in this series :(
>
> See the many examples of how this is done by looking at other patches on
> the mailing lists and in the submitting patches documentation.

Sorry =EF=BC=8CI will add it in new version

This patchset aims to provide power supply properties about
wireless/wired charging.
 =E2=80=9Cquick_charge_type=E2=80=9D reports different types of quick charg=
e based on
the charging power;
 =E2=80=9Ctx_adapter=E2=80=9D shows the type of wireless charging adapter;.
 =E2=80=9Csignal_strength=E2=80=9D shows the coupling level between TX and =
RX;.
 =E2=80=9Creverse_chg_mode=E2=80=9D provides the interface of enabling/disa=
bling
wireless reverse charging.

 Changes in v5
  - Add details in 0/X email

 Changes in v4
  - Exclude the patch of =E2=80=9Cpower: supply: supply battery soc with de=
cimal form=E2=80=9D
  - Fix some typo

 Changes in v3
  - Add enumederated for quick charge type
  - Add enumederated for tx adapter type
  - Update the return type and description in ABI

 Changes in v2
  - modify to capital letters for =E2=80=9Cpower_supply_attrs=E2=80=9D
  - Update the return type and description in ABI

 Qiwu Huang (4):
   power: supply: core: add quick charge type property
   power: supply: core: add wireless charger adapter type property
   power: supply: core: add wireless signal strength property
   power: supply: core: property to control reverse charge

  Documentation/ABI/testing/sysfs-class-power | 71 +++++++++++++++++++++
  drivers/power/supply/power_supply_sysfs.c   |  4 ++
  include/linux/power_supply.h                | 31 +++++++++
  3 files changed, 106 insertions(+)


> thanks,
>
> greg k-h


--=20
Thanks

Qiwu