Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp403107ybh; Mon, 20 Jul 2020 20:45:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+STKCPJbcudDnu+YlHPDfcN5IYKiDA6Z1xknO7KqpgWHRm3lseTQagbFv6/M1GVO8MYe5 X-Received: by 2002:a05:6402:363:: with SMTP id s3mr23435113edw.238.1595303158455; Mon, 20 Jul 2020 20:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595303158; cv=none; d=google.com; s=arc-20160816; b=rcHfbegm+3RuEctcPXtpEEpAhxTBESmxYPUbKVE4AKe8XgxcGrn8ZRscTGLNSkx2G1 OxzsF3HI0NjRVjw+qmA3bciPDaEIRd9pWVAoThVRhJ5A5ykMaVRWOfoD8mUONx22AQG2 ygd0FbZVrLhqrtuhd6/G5D7FpByJYtVZxWerdLIHnJmtamO4+xlVO5zI7G1lUTMy8O6u sx4S/HozWvAuLiXXKKd0FZTGaEm9Z9X3pkvmB2IRTRh/BR2zj24AtYzoExcSn8lqw13M wKA7vw++ARn9RLVfo3AZ12Jv6FglRgymYH8jApjaWpKwIU3yxo0peOKWdBY8x8/hrIaL p5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=neQ4XfqsxRwdm6YAtu4KmClGsgD9mTg2Tn9ai9iUPZE=; b=rLg0EAPS40ej9xs7R5X93a/Y4msQ/voWPsc/ABmAdHbspL0gsz+I5GqjJTl3QQCvia I85TwM/9LDr8sgjHyC+0P7G4aQm0wB7Vsy37GLboap3QUTk7bDNg4+XAguyJIvmvyeBb x3SoTEUrv8U2S1mSg2rowPx7/Jxi3VTNASgBmdjk+5StFsBaQbJXNyGmiYFEc42bRio8 zQtqXBUJGrg6D7lJ0ndW4zYE2jy+G3Ne69h5JhQ4VERCLy3gjb3NIbK1Yq8B8yyBTJX1 +FKJWo1ExzovxMKo7keVWFk8UWjbZu0MVTQT1NaPLxlOjgj1Z6Yasite63kzVNtdhzrz 94dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VZHdCFFg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si11284916ejt.487.2020.07.20.20.45.35; Mon, 20 Jul 2020 20:45:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VZHdCFFg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728303AbgGUDo2 (ORCPT + 99 others); Mon, 20 Jul 2020 23:44:28 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:43748 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgGUDo2 (ORCPT ); Mon, 20 Jul 2020 23:44:28 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06L3iEK8127778; Tue, 21 Jul 2020 03:44:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=neQ4XfqsxRwdm6YAtu4KmClGsgD9mTg2Tn9ai9iUPZE=; b=VZHdCFFgjFbh42TbNSVn4ExE6480VECyAGb4qLnol4rdBCJvPKg3QHlfv8TGC0VDTpr6 yPkbWxUi8oF2sFobG/rD/a/iYhC8UDlsIElqcj+ID8CrVpZzuGX1ATxpRSrJnfC4NgH/ gOdAfwwGPDAdfA+pr1HNxDBXdEmwFXkQuTYVeLd09hSX9Q4ImVWVoQrZKa25tXoJA6WG WQUVWRew61ldDpgVVZVVbKBvV5exmAFd9eCQgZg1tvgtcfFN6ueTeUL6LCHngIULUsWw XpM73FuyQuZe/dsVqgQxE4PgDYGm1zHBKTiSTg/AI2n1epbarylVoLI6KHF1SEgPJ9pl 3Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 32bs1mae4u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Jul 2020 03:44:17 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06L3cFIY150340; Tue, 21 Jul 2020 03:42:16 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 32dnfnqr90-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jul 2020 03:42:16 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 06L3gEqL015562; Tue, 21 Jul 2020 03:42:15 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Jul 2020 03:42:14 +0000 From: "Martin K. Petersen" To: jejb@linux.ibm.com, john.garry@huawei.com, Xiongfeng Wang Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, guohanjun@huawei.com Subject: Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs Date: Mon, 20 Jul 2020 23:42:09 -0400 Message-Id: <159530290480.22526.16753171296577291668.b4-ty@oracle.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <1594975472-12486-1-git-send-email-wangxiongfeng2@huawei.com> References: <1594975472-12486-1-git-send-email-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9688 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=845 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007210023 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9688 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=862 malwarescore=0 clxscore=1011 spamscore=0 mlxscore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007210024 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2020 16:44:32 +0800, Xiongfeng Wang wrote: > When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. > It's better to add a newline for easy reading. > > [root@localhost ~]# cat /sys/devices/pci0000:00/0000:00:0d.0/0000:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable > 1[root@localhost ~]# Applied to 5.9/scsi-queue, thanks! [1/1] scsi: scsi_transport_sas: Add missing newline in sysfs 'enable' attribute https://git.kernel.org/mkp/scsi/c/38364267251f -- Martin K. Petersen Oracle Linux Engineering