Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp475273ybh; Mon, 20 Jul 2020 23:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn9Ugs+Zi/kz9LSKREXrZd3KoNkiAzILmc56mEd4jzJvqFuu4KOkqP/Pgk/i46ECRwfPQG X-Received: by 2002:a17:907:1051:: with SMTP id oy17mr24925595ejb.394.1595312243217; Mon, 20 Jul 2020 23:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595312243; cv=none; d=google.com; s=arc-20160816; b=X3OLCWYSHl16WWZN7oZv0kzojVmmj3veU38QlsMK2tXrXJE46OmiVSyDIuAWHg7ZEE TpVmpXNQTEop564D93dUm4zwwMCmr1+QtPdJ9nlRnuluqFKU6Hw9v8A5x9bgnsAX7ZXJ 487p7UBobCPZLIkEev/t7pgJuKLQqKyCGBDaB9vl/TRC2KF/LXGwKINnVTM67L0s5z2v +RyUacrTwdM/jNlR3uR23VL5ePRjj31EZ7FlE1elKWLLg6+2xOEpXWFyZdEnye/vLoAz w9zZj2KUvF4aZAD0w8isU/1oU0ekeNgTsgoulwFmlFlEagZfPVUqwT3sR9kGzbFlfhXZ VXGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=SZbPR8PF3bBskKOnuuEIuV6lOk/CEKXUBUrHAjVkFXY=; b=QaS++T1HUQCtWiVWLOvCJwCLIYcxG33qRt4YD2BkO3QU3B7qkHcl+Xx8fZ3YBeUhag xHBntvF3TbnrtS/d7Qt1WcVkkaWzWxSBcOQVTZ1en4tl8CXYmq/Kg1Yjuh6LIvLrZmNe YjQZo9tnpMbzzom+5j8kdAPl1zHiwKxo8Fludr9SA+2FpkmrosFNMU4FulzRc8QH3/MV oHmTOZKCGSEGo5gKihDfYvICzxU+Jw/aSZf8Z2H4m0i0fOqXKYjkZHXba89qOUlNIiI1 saCtOQG43Ebaj9n/tMf2Kw3FTUp3m26xLkO/SRKHHtMSOo2BlNMujiDjknpt/kvA0yX/ SjaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si12218358edq.393.2020.07.20.23.16.59; Mon, 20 Jul 2020 23:17:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbgGUGQf (ORCPT + 99 others); Tue, 21 Jul 2020 02:16:35 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7802 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725294AbgGUGQf (ORCPT ); Tue, 21 Jul 2020 02:16:35 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 60ACBE0D13EC4424A248; Tue, 21 Jul 2020 14:16:32 +0800 (CST) Received: from [127.0.0.1] (10.174.178.16) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Jul 2020 14:16:28 +0800 Subject: Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs To: David Miller CC: , , References: <1595243869-57100-1-git-send-email-wangxiongfeng2@huawei.com> <20200720.174432.702526374205425580.davem@davemloft.net> From: Xiongfeng Wang Message-ID: Date: Tue, 21 Jul 2020 14:16:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200720.174432.702526374205425580.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.16] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2020/7/21 8:44, David Miller wrote: > From: Xiongfeng Wang > Date: Mon, 20 Jul 2020 19:17:49 +0800 > >> - return sprintf(buf, "%lu", trans_timeout); >> + return sprintf(buf, "%lu\n", trans_timeout); > > Better to replace it with 'fmt_ulong'. Thanks for your advice. I will change it in the next version. Thanks, Xiongfeng > > . >