Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp575905ybh; Tue, 21 Jul 2020 02:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4n4DW4uVfkve0NvzbCTwPgZri1uET1lRVH5suVLvwS1N0svdDHVFC6QRHEBPIaqp7afUE X-Received: by 2002:a17:907:20f8:: with SMTP id rh24mr209385ejb.309.1595324360181; Tue, 21 Jul 2020 02:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595324360; cv=none; d=google.com; s=arc-20160816; b=CSU5pkS8iscThqAna2HjGr+YLrdExvJUP/8YdcWlwf93oNQkNX02M0dB7RsOsw7JYQ uFDS+KnDrfDuTAbrVoI+nTTXFE+07PNL5F6g+YmJKqfnimCLLtFDdrZkNCpUUgU6NEpk 8KqPZTvpmZRQxznAVWY83UOfM4vLM6/ww12JM2y0BgWqDKUbEJLVu4pjCsSc13Flj2qz zD+Hs/Qr5dYq7G6KSYsNzKCjhbYqJ7j09OM7uYXNDfFtgY7Rlu9CoN1ah2wQtaW5BosS VWV3lBJnsT/Vje4DAujlld3hxFqqqKORya08r1pGFEhWyw9u+UhDoSSa5tBhlBcNsXUe RQ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rlfZOGrG0Y0g+jvfYXyQSQK2g13qrRx8rGSIeVgX6ck=; b=Bqb74W+phSllA1WvAmQVJOeo6esIxfSu3V4NHxRbEp1kg9HFUPj2U6LxFZyJo7CqhS 4/hYMbJToG0TNvMt5adUFCtjW5toaqckuoca1o1B716qAmQMEjNf7zr5uPmkwkMNnA5j S47v5po3RnaOK6/UsHAFSksvp1SH8Hmxv5aWs5ZF2buEltm5NqJsf02lFIMfpRedjFMp xJ25CRDwXWlQa3djc2y4whdQLgRxVsxxw3bzyMM79F0nMxj6ZmeEmtNZN82F2LOLVyNZ hp1hnEQELsS9IINrK13w08UVNZahRNWhIW5jgbiQjJ0oZS1+DBAnTEr/hoGcSKjIDb7c 1o5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RTnMrToA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si12815023ejr.470.2020.07.21.02.38.57; Tue, 21 Jul 2020 02:39:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RTnMrToA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728904AbgGUJf6 (ORCPT + 99 others); Tue, 21 Jul 2020 05:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgGUJfz (ORCPT ); Tue, 21 Jul 2020 05:35:55 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8119BC0619D8; Tue, 21 Jul 2020 02:35:55 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id s10so20445107wrw.12; Tue, 21 Jul 2020 02:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rlfZOGrG0Y0g+jvfYXyQSQK2g13qrRx8rGSIeVgX6ck=; b=RTnMrToASJ8SSq+foC+yfYpXpCrjb/b2iWaLnfA94cKjgQAEfn6b3grnhH7uLNLk86 4b8krhKft2HT3mIHSwvS0nUkZMndajX4R81dAsup+enEMOVcv7GFF9BNVSFnW1gjjGpv mpsfHwwrpx69LkvtFIajJ1zGX5GkPc0yKSrf5EIERCYKuz7bXLJwxxNXPumN96Letuu9 UZeevIUN1WlI9GOa+YYWqPyqBDJjPGLIUe50EXLaYbezqtXWPCbg2sZrXMzL3kYsL8px Z/fgazAxGc9zUIVMUgTwYH4ywPgabUzvIG/ZI9S8YuUt6ohUjCbgRuD0qnr6OgnRVKHb jzCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rlfZOGrG0Y0g+jvfYXyQSQK2g13qrRx8rGSIeVgX6ck=; b=gg+E0QLAFpoFf/1VhyC2JHDz76WlR/hD5arz/j4VuAPVNfDi6rQKNehAtI8OPrKOhI Pjii5/ByZgo/Mseob6egOFBxpTNPfU60+B5x+YaZBGvSUIW+TzAxat5q4J6QqeOQqn4s aGMVDgRLBo2YLGHAmVbUadNa9Tk1uywcFIgT0aykie68GUy+OjOSNRDLFbUoMyAuXySt QJ3rHZVGkEZlXv9mebZPbq4uuLJjgXN3Wx8Xrxr84CxVfzsScCW4UXivpa2uQ7Lfa5J/ T6+ltAsL8ch6LVdlKvimepJjNju14Clyuq9IrXc3McWWxvAYF1PgE/Wu/KjsmPZ8iiI9 XbYw== X-Gm-Message-State: AOAM5306bYyBwu1vZ0k0U4EU6xOVVn8Yfn0zv3cHGkmF26Vb5ETv3fiL Gxx94n6b/cFFb9/jgtlki80= X-Received: by 2002:a5d:68c7:: with SMTP id p7mr27321548wrw.16.1595324154292; Tue, 21 Jul 2020 02:35:54 -0700 (PDT) Received: from localhost ([41.37.22.226]) by smtp.gmail.com with ESMTPSA id u20sm2649645wmm.15.2020.07.21.02.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 02:35:53 -0700 (PDT) From: Abanoub Sameh X-Google-Original-From: Abanoub Sameh To: andy.shevchenko@gmail.com Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Abanoub Sameh Subject: [PATCH 6/7] gpio: fixed coding style issues in gpio-pch.c Date: Tue, 21 Jul 2020 11:35:21 +0200 Message-Id: <20200721093522.2309530-6-abanoubsameh@protonmail.com> X-Mailer: git-send-email 2.28.0.rc0 In-Reply-To: <20200721093522.2309530-1-abanoubsameh@protonmail.com> References: <20200721093522.2309530-1-abanoubsameh@protonmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Abanoub Sameh --- drivers/gpio/gpio-pch.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index e96d28bf43b4..039822978eaf 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -95,7 +95,7 @@ struct pch_gpio { spinlock_t spinlock; }; -static void pch_gpio_set(struct gpio_chip *gpio, unsigned nr, int val) +static void pch_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) { u32 reg_val; struct pch_gpio *chip = gpiochip_get_data(gpio); @@ -112,14 +112,14 @@ static void pch_gpio_set(struct gpio_chip *gpio, unsigned nr, int val) spin_unlock_irqrestore(&chip->spinlock, flags); } -static int pch_gpio_get(struct gpio_chip *gpio, unsigned nr) +static int pch_gpio_get(struct gpio_chip *gpio, unsigned int nr) { struct pch_gpio *chip = gpiochip_get_data(gpio); return !!(ioread32(&chip->reg->pi) & BIT(nr)); } -static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, +static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned int nr, int val) { struct pch_gpio *chip = gpiochip_get_data(gpio); @@ -146,7 +146,7 @@ static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, return 0; } -static int pch_gpio_direction_input(struct gpio_chip *gpio, unsigned nr) +static int pch_gpio_direction_input(struct gpio_chip *gpio, unsigned int nr) { struct pch_gpio *chip = gpiochip_get_data(gpio); u32 pm; @@ -196,9 +196,10 @@ static void __maybe_unused pch_gpio_restore_reg_conf(struct pch_gpio *chip) iowrite32(chip->pch_gpio_reg.gpio_use_sel_reg, &chip->reg->gpio_use_sel); } -static int pch_gpio_to_irq(struct gpio_chip *gpio, unsigned offset) +static int pch_gpio_to_irq(struct gpio_chip *gpio, unsigned int offset) { struct pch_gpio *chip = gpiochip_get_data(gpio); + return chip->irq_base + offset; } -- 2.28.0.rc0