Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Lee Jones <lee.jones@linaro.org>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Ben Dooks <ben@simtec.co.uk>
Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
In-Reply-To: <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com>
References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com>
Date:   Tue, 21 Jul 2020 12:43:57 +0300
Message-ID: <87blk9p5ia.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:

> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> value.  Looks like this has been broken since
>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>=20
>> Also fixes the following W=3D1 warning:
>>=20
>>   drivers/usb/dwc2/gadget.c: In function =E2=80=98dwc2_gadget_wkup_alert=
_handler=E2=80=99:
>>   drivers/usb/dwc2/gadget.c:259:6: warning: variable =E2=80=98gintmsk2=
=E2=80=99 set but not used [-Wunused-but-set-variable]
>>   259 | u32 gintmsk2;
>>   | ^~~~~~~~
>>=20
>> Cc: Minas Harutyunyan <hminas@synopsys.com>
>> Cc: Ben Dooks <ben@simtec.co.uk>
>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert inte=
rrupt")
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Acked-by: Minas Harutyunyan <hminas@synopsys.com>

Should I apply the entire series or only 1/8?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8WuN0ACgkQzL64meEa
mQacAQ//a/P5SYnBnlVVnSmY6/+H5xaTyA0frND1g+cvwxNLc8oWt8WK97bow8mn
gHNkRsPUfur72sCbsHhbOczv7Kc2ea3d+0KJNTv0idAgr8zUG0we/lYewX7+YCDc
x911DeDk19uqC84Xbt9LmC9iBJbqPA+IlzckS2CwunqNws57n01+/p+txsNOEwXc
EfCJBfEljT+W8u+yoeAu2FDdL3etFHZuIEE/aSLYC5qTqtM8dnUcoci0NDb3J+If
uhJ0U0E8S9u3D8vGaL78cZHvMCvY6C4NLj+CdwkTFIGh3wx0uYSyOGnvrd2mlupS
UV0oUqJj6vqDZ0MjpUYpAYd9tqSiucigXy13vId9QOSgTGsVKYNHevUlUOLq8lYC
q29fZ4qNprDyKdc/JRuzkqanRqVfP7+HArMOXajAbCb1Qbk+qoYp12LuDs4yFWBW
cBe1/yy9ItxJAjp7oMBiuMsjWdn/Di7mf3HMt5fTti0jNptDq1BPGsksUudJ656I
OewK0YelUC6ptvxRfE4YwI7MUoG5EciU9tonBpFGkU2euzs6VrIpIF9haDIKEuC8
8eafrA9+yamuhElBP0xix/Bbif/Lk6oxK6yXVIwdB5qCNEgHRPjLzDEQykO1QBwp
BMykpU5UXXpdqYD9kuT3k/hHTLq8GeO2o3bHVWoWZTvw7ZumzMk=
=1ehQ
-----END PGP SIGNATURE-----
--=-=-=--