Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1595301250.git.huangqiwu@xiaomi.com> <b383d79629d0afca00838fcbaad4458e383d7262.1595301250.git.huangqiwu@xiaomi.com>
 <20200721082000.GD1655283@kroah.com>
In-Reply-To: <20200721082000.GD1655283@kroah.com>
From:   ivan <yanziily@gmail.com>
Date:   Tue, 21 Jul 2020 18:21:20 +0800
Message-ID: <CAPtXDt2CXYJNoqnu3r7+vV2BZzT3fMR_G1yOyu1v0dgS8EkjNg@mail.gmail.com>
Subject: Re: [PATCH v5 3/4] power: supply: core: add wireless signal strength property
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com,
        Qiwu Huang <huangqiwu@xiaomi.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 21, 2020 at 4:19 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 21, 2020 at 01:59:36PM +0800, Qiwu Huang wrote:
> > From: Qiwu Huang <huangqiwu@xiaomi.com>
> >
> > reports wireless signal strength.
> > The value show degree of coupling between tx and rx.
> >
> > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> > ---
> >  Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
> >  drivers/power/supply/power_supply_sysfs.c   |  1 +
> >  include/linux/power_supply.h                |  1 +
> >  3 files changed, 12 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > index 03ab449fae8a..75ec7de2fe78 100644
> > --- a/Documentation/ABI/testing/sysfs-class-power
> > +++ b/Documentation/ABI/testing/sysfs-class-power
> > @@ -757,3 +757,13 @@ Description:
> >                       13: ADAPTER_VOICE_BOX,
> >                       14: ADAPTER_PRIVATE_PD_50W.
> >
> > +What:                /sys/class/power_supply/<supply_name>/signal_strength
> > +Date:                Jul 2020
> > +Contact:     Fei Jiang <jiangfei1@xiaomi.com>
> > +Description:
> > +             In PING phase, RX transmits a signal strength packet as the first
>
> What does "PING phase" mean?

The Qi Wireless Power Transfer System is published by the Wireless
Power Consortium.
The ping phase is the necessary stage for matching transmitter and
receiver. In this phase,
the Power Transmitter executes a Digital Ping, and listens for a
response. If the
Power Transmitter discovers a Power Receiver, the Power Transmitter
may extend the Digital Ping,
i.e. maintain the Power Signal at the level of the Digital Ping. This
causes the system to proceed to the
identification & configuration phase. If the Power Transmitter does
not extend the Digital Ping, the
system shall revert to the selection phase.

>
> Other than that, seems sane to me, thanks for the changes.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


-- 
Thanks

Qiwu