Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp615332ybh; Tue, 21 Jul 2020 03:51:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxARmZCnLa4cfpJlVsdpLQK9ImS112epGk2W+YD3loIzBSgaWe5xb5LHjXzdD/PPkI/Gf8f X-Received: by 2002:a17:906:970a:: with SMTP id k10mr23054919ejx.236.1595328673984; Tue, 21 Jul 2020 03:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595328673; cv=none; d=google.com; s=arc-20160816; b=VeXlO9ziJIx+Fz1DF05oXD8QMxOLuoDeua9VoDpn04Gg6jFfxo/SgEKYk2+K8iIMDt 6iO1ZVrMsPFjKylbNNGU7B4phTRmtYHMpHya6s3hs7SIWvr/mPBVmj792Dw8A/WoBpA4 QxpUcdM/exE9Aqw9LAIAh6pXshQLDe4b+YAeBxRS7/jZHg2wzpujStQsli4VYLSs2RfV aPitVy7CUHdUIx3t3V55WKbzbNVrDtW6rQJiUnIfpYUNRUvBqHh5nG2GLjdhivCB7kMh ErKGnpk1GXOd6MjGRkDdn3Isf+xaZB5yL+CMRVZVV5ifnR0/ggmC7H+knXlZgbQpXw75 5VKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Mq+/oZmJHKNxNLqfBH78yn3pkWtDXKt6O59loeeGP3Y=; b=tnEa0iZZq4GcUQjT5pmHfc2PgxfqnsZLVunQBeh27MtsUQ8bb+sWYEBsks0Dwe9xEl bwzY3ikUVu3qKE5tP2TnAXNsjiHPQnuz8OFDUwvBAriMUKAGgm5SJJqxHGkn2d8DlcTs zPCSNIu4OFDsQqTA9qzccm14feuSt/sIA/OZUPdhuvuLc/Fe38xRi9Z9dMUX5SwZ+u5R ysuyXtZvUuibCtS0rXP7mbGRKmBxAgWAOwiyILbCtrp/z2Xpylir3FeFbC27Tb0uXVIv AGT+d9Vdwgr3BSCIaP3TxSkNXns/URbQl4dqzZHqfQsbrCZLWB1njFX+dI1qCIF0qVJW A+vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lZyHoXWx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ml21si12013365ejb.261.2020.07.21.03.50.51; Tue, 21 Jul 2020 03:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lZyHoXWx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbgGUKup (ORCPT + 99 others); Tue, 21 Jul 2020 06:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgGUKup (ORCPT ); Tue, 21 Jul 2020 06:50:45 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BEA8C061794; Tue, 21 Jul 2020 03:50:45 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id k71so1393513pje.0; Tue, 21 Jul 2020 03:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mq+/oZmJHKNxNLqfBH78yn3pkWtDXKt6O59loeeGP3Y=; b=lZyHoXWxzQG/BnBBXBQ21pSle5hxdB1B9yJETOVyQThMylzRiwpSYvKbjWdYWFiIzF 1f7QDvsIv9yNIcZ/zj+JqrT0jkubICMrsiqdVmp58L+elx5nmmuXg3noPPfF2J6bIAoa Xe/Oa1ButCrY1RyydJLlS/gIFDtra6AQ9rzgDfzbNfjtyLe/VacjL/XvpGvbEISxyqRd OWiAkGx/fSZCzO6lEHK32aYCu3ST3l5fpltu8jHWtPXHxTSWTq82FSzMX79cs+uLIEUW KM/J4idFh+sTKBv3nJFCS7t1vfAWUuWUN/sCmKS8KiwTwmb1gP4y2aELcLelBzOnV+3D 3GSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mq+/oZmJHKNxNLqfBH78yn3pkWtDXKt6O59loeeGP3Y=; b=KXA9dAZZilcSrLMmGVqECcZy4QYfWqzJV80oeoEzwQ8mRl2y3SaG4RYpBN0lVOISpU pYwJIXAnbebwg2KdYAU4mWrXxIQEf6g/KbPWSdZiSK2E6Yd3t//wDJfmLpPN86t79Pk+ 7GrDRNwfZmoaA2pODPgm+SD2upidIiWdaHMMDPRPy9PiLOkT5DE3vmzSU2+HRskm/zha Ln0EaXHntD7ighS3B6X3C+lDdfj2f1Bal+lFTDmTBOiM7/m+Fy2p+JY0/LlDqzdJrEiD oGBy0X1To9kD0DNC21c39LKYKjO24TgvwCyCTESoesGmL6puJnBso2qahfUH30qY65Nz mqwA== X-Gm-Message-State: AOAM533OvPrIgHX/Ox1E/wL/KIpwZur4iowduBbz/mvQZwlk4jGA9D3Z o9Lq3RBdAdB6YKBNhdGSgfMLlhqJuAamR1gMp9o= X-Received: by 2002:a17:90b:3547:: with SMTP id lt7mr4091894pjb.181.1595328644648; Tue, 21 Jul 2020 03:50:44 -0700 (PDT) MIME-Version: 1.0 References: <20200721093522.2309530-1-abanoubsameh@protonmail.com> In-Reply-To: <20200721093522.2309530-1-abanoubsameh@protonmail.com> From: Andy Shevchenko Date: Tue, 21 Jul 2020 13:50:30 +0300 Message-ID: Subject: Re: [PATCH 1/7] gpio: fixed coding style issues in gpio-crystalcove.c To: Abanoub Sameh Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Abanoub Sameh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 12:35 PM Abanoub Sameh wrote: Thanks for an update. In each patch you unfortunately missed: - driver prefix, should be gpio: crystalcove: here and similar in the rest - commit message (even one line of why this change is done) Waiting for v2. > Signed-off-by: Abanoub Sameh -- With Best Regards, Andy Shevchenko