Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Jul 2020 16:40:07 +0530
From:   B K Karthik <bkkarthik@pesu.pes.edu>
To:     syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com, gregkh@linuxfoundation.org,
        skhan@linuxfoundation.org,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Mike Isely <isely@pobox.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] i2c: fix WARNING in pvr2_i2c_core_done
Message-ID: <20200721111007.hwwdveqxeqcry4wn@pesu.pes.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ut3ssk6bs5fsawxc"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ut3ssk6bs5fsawxc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

#syz test: https://github.com/google/kasan.git usb-fuzzer

fix WARNING in pvr2_i2c_core_done by
unregistering device in the release handler
instead of the disconnect handler.

Reported-by: syzbot+e74a998ca8f1df9cc332@syzkaller.appspotmail.com
Signed-off-by: B K Karthik <bkkarthik@pesu.pes.edu>
---
 drivers/i2c/i2c-core-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 26f03a14a478..2d377d2e89f1 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -462,6 +462,7 @@ static void i2c_device_shutdown(struct device *dev)
=20
 static void i2c_client_dev_release(struct device *dev)
 {
+	i2c_unregister_device(to_i2c_client(dev));
 	kfree(to_i2c_client(dev));
 }
=20
@@ -1527,7 +1528,6 @@ void i2c_del_adapter(struct i2c_adapter *adap)
 		dev_dbg(&adap->dev, "Removing %s at 0x%x\n", client->name,
 			client->addr);
 		list_del(&client->detected);
-		i2c_unregister_device(client);
 	}
 	mutex_unlock(&adap->userspace_clients_lock);
=20
--=20
2.20.1


--ut3ssk6bs5fsawxc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEIF+jd5Z5uS7xKTfpQZdt+T1HgiEFAl8WzQ4ACgkQQZdt+T1H
giHdCgv/R4BJLHuPsoUuC8vZDeVvtdVKXC5EZyGFmlVFnlBontVfMBrg5azCTEXv
QtjdDpjpmJ5fK6KOcS0nk9AWqRueMGg8eW1pkE8uiCR30ERA9ZEdsW5SyH9d3BzS
2jOp5WQvbnEsdub+adY4DTQHXusNoly5+F/Dd2eT2wJGXMsiYySrwQ3TeQwgNZhn
EQJbMTjEoHWYEMcB6CgnIKSjRjfGT6tD4Rn9EKSNypQri0L8HbbdFd46br6dXvKp
FOYheMB5HHGWhgVjBSztTz+YZyHgogM+oVTLVU2AQCSZ7lHFpN+0ImfFeh5qOiQN
F5qK0soYYB7+ffuCABF+qwChK6lUzX5baavMoFNSsFmY6ZnHnF6Lmg+DJh4t9oku
4/qqn8JctjgZqqfzErKGou7LbZvqOzvo5+iDDHi9skxa8tlrCEF0oTYgdkROqGzq
RGhTMRZY2pS8sd5I2h6daK7UV4dboBOB9SJGtv6QLoBwR4WTfQuMrEj3FQeaQDpa
iRRFHUV5
=aiG8
-----END PGP SIGNATURE-----

--ut3ssk6bs5fsawxc--