Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: reEsHghl/F31AXlteyNCYMjQ5zx97sDuWeIMzp+BFL8jRZQP15aj6c22zPEUqOYHgW2kyqrVFi
 GooVKRHEiC8iyWovYYdxzqJPRaNSZuyyL6FzMmJ9I1DT+zLIreG22+WWTp+kZGDchs7TQMNdah
 3AEeFg9KqkHxChyuS7aQ7/+3Yd6KxIRpnM8dOwpaNKXW30ay/Hgw8QQ51H7cUCPiXijFncEwLR
 AszeJKeshTGc8rc4Gg1kepnK04bJbu1p9uenor73X1HQJvRL3GcScYqC4o3uP8M/W23L/6Dv1p
 IhU=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Keith Busch <kbusch@kernel.org>,
        Josef Bacik <josef@toxicpanda.com>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        "open list:SCSI CDROM DRIVER" <linux-scsi@vger.kernel.org>,
        Tejun Heo <tj@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jason Wang <jasowang@redhat.com>,
        Maxim Levitsky <maximlevitsky@gmail.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Colin Ian King <colin.king@canonical.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Ajay Joshi <Ajay.Joshi@wdc.com>,
        Ming Lei <ming.lei@redhat.com>,
        "open list:SONY MEMORYSTICK SUBSYSTEM" <linux-mmc@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Satya Tangirala <satyat@google.com>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@other.debian.org>,
        Hou Tao <houtao1@huawei.com>, Jens Axboe <axboe@fb.com>,
        "open list:VIRTIO CORE AND NET DRIVERS" 
        <virtualization@lists.linux-foundation.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 06/10] block: ms_block: use
 blk_is_valid_logical_block_size
Thread-Topic: [PATCH 06/10] block: ms_block: use
 blk_is_valid_logical_block_size
Thread-Index: AQHWX01g75TdosEsGkWUbpiStX7SFw==
Date:   Tue, 21 Jul 2020 11:17:01 +0000
Message-ID: <CY4PR04MB37515103AF92B1BB196ED494E7780@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <20200721105239.8270-1-mlevitsk@redhat.com>
 <20200721105239.8270-7-mlevitsk@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef6f962-47ab-4516-44b9-08d82d679771
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 11:17:01.6380
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0RX/r26b2DneM+l0Evdbfr4LLXOUXFGC+xfIj3TmpzCzA5dss9pFwKdCjh8ROzjAUX9L8waPQiOTAID4JHNZZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0969
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/07/21 19:54, Maxim Levitsky wrote:=0A=
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>=0A=
> ---=0A=
>  drivers/memstick/core/ms_block.c | 2 +-=0A=
>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_=
block.c=0A=
> index d9ee8e3dc72da..e4df03e10fb46 100644=0A=
> --- a/drivers/memstick/core/ms_block.c=0A=
> +++ b/drivers/memstick/core/ms_block.c=0A=
> @@ -1727,7 +1727,7 @@ static int msb_init_card(struct memstick_dev *card)=
=0A=
>  	msb->pages_in_block =3D boot_block->attr.block_size * 2;=0A=
>  	msb->block_size =3D msb->page_size * msb->pages_in_block;=0A=
>  =0A=
> -	if (msb->page_size > PAGE_SIZE) {=0A=
> +	if (!(blk_is_valid_logical_block_size(msb->page_size))) {=0A=
>  		/* this isn't supported by linux at all, anyway*/=0A=
>  		dbg("device page %d size isn't supported", msb->page_size);=0A=
>  		return -EINVAL;=0A=
> =0A=
=0A=
Looks good to me.=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=