Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: D93AF5g/SQzDKNfgZq5thyukwAJElqnYMMXZhM66HsKCgktM6K540n4yKSESIiccVb4XsjUyEl
 xTIvdzRuIUVoWmLn77z2tY/jHI0kb9meuTaex1iJeqokbzrbMDSjpKc6An8fkoKa141uQUR8/0
 AQCA4w60h/oa3Xa2/5fbSo9VYE5f8cusLBM+Th1zBKN/TzHgl0NeRXxUL2LAjKVkEmODsJpcVd
 tt9nJVKqmfEWoU+bzZzrf0kSTmAjT/Qo9lS6n8oyiHL2DZkpaCFEcnWOrXjVQwF6H7M8Ko92TD
 KzI=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Keith Busch <kbusch@kernel.org>,
        Josef Bacik <josef@toxicpanda.com>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        "open list:SCSI CDROM DRIVER" <linux-scsi@vger.kernel.org>,
        Tejun Heo <tj@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jason Wang <jasowang@redhat.com>,
        Maxim Levitsky <maximlevitsky@gmail.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Colin Ian King <colin.king@canonical.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Ajay Joshi <Ajay.Joshi@wdc.com>,
        Ming Lei <ming.lei@redhat.com>,
        "open list:SONY MEMORYSTICK SUBSYSTEM" <linux-mmc@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Satya Tangirala <satyat@google.com>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@other.debian.org>,
        Hou Tao <houtao1@huawei.com>, Jens Axboe <axboe@fb.com>,
        "open list:VIRTIO CORE AND NET DRIVERS" 
        <virtualization@lists.linux-foundation.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 09/10] block: scsi: sd: use
 blk_is_valid_logical_block_size
Thread-Topic: [PATCH 09/10] block: scsi: sd: use
 blk_is_valid_logical_block_size
Thread-Index: AQHWX013XUfOciPpqUa+Od1IzTz9Vw==
Date:   Tue, 21 Jul 2020 11:25:06 +0000
Message-ID: <CY4PR04MB375113B7D781BF2949FE5B33E7780@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <20200721105239.8270-1-mlevitsk@redhat.com>
 <20200721105239.8270-10-mlevitsk@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 22318541-8eb1-42be-2a55-08d82d68b85c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 11:25:06.2683
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YwLUMBdiktOCfxMEtamPgamaGsVgenMpvGnn4ZPKps4PQWO/W5fIc8a8CYi8P4PLIXS2X5j4+jo4622b1P6vFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB1176
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/07/21 19:55, Maxim Levitsky wrote:=0A=
> Use blk_is_valid_logical_block_size instead of hardcoded list=0A=
=0A=
s/hardcoded list/hardcoded checks./=0A=
=0A=
> =0A=
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>=0A=
> ---=0A=
>  drivers/scsi/sd.c | 5 +----=0A=
>  1 file changed, 1 insertion(+), 4 deletions(-)=0A=
> =0A=
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c=0A=
> index d90fefffe31b7..f012e7397b058 100644=0A=
> --- a/drivers/scsi/sd.c=0A=
> +++ b/drivers/scsi/sd.c=0A=
> @@ -2520,10 +2520,7 @@ sd_read_capacity(struct scsi_disk *sdkp, unsigned =
char *buffer)=0A=
>  			  "assuming 512.\n");=0A=
>  	}=0A=
>  =0A=
> -	if (sector_size !=3D 512 &&=0A=
> -	    sector_size !=3D 1024 &&=0A=
> -	    sector_size !=3D 2048 &&=0A=
> -	    sector_size !=3D 4096) {=0A=
> +	if (!blk_is_valid_logical_block_size(sector_size)) {=0A=
>  		sd_printk(KERN_NOTICE, sdkp, "Unsupported sector size %d.\n",=0A=
>  			  sector_size);=0A=
>  		/*=0A=
> =0A=
=0A=
With the commit message fixed, looks OK.=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=