Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp640637ybh; Tue, 21 Jul 2020 04:28:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCB4q8pNDsIQFgnY0gnJmFRnsWbETWW21+bq5ZBh3+moPfx0ZoR7rsAtEUS3lSJM55fKX5 X-Received: by 2002:a50:cd53:: with SMTP id d19mr25947508edj.300.1595330893219; Tue, 21 Jul 2020 04:28:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595330893; cv=none; d=google.com; s=arc-20160816; b=lra24D7U3f/sHMM0WcQQj5RkBgpByd9TXT/OL2T1Ur8L6JURcFMZRJLqYDZ1e4qOS5 HzzDDZihs6OpyWNCYxa4ZCqIWA14yJd4kEiOvbUoJQXVW5wQjWeJPIfu6Z7fWoGWx0bW /xcoce+nozwYReSlmS4PADQ9XRpLO9aGHN0EHEOgiq+sC9/Y/6h1ABo5C9gbY5YvAVNp ibVsTIf7U0K49MK9gs50nBF1sXUz+nUOUPW0W+gkS0JbKI5xp9X3XKs+93jvS/D+sjkL 07Y/Kh9Hp8G4/ggNG8A1azvgkRJax6JlmEEpxyaJlV8SA7qVKWMwpw8l35oO2YoYPumm LhNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eDTdOZ1dDPKD1UqSkexaZR5dMf1fmObppvOA9WWtcgo=; b=OX9UXOSfgGcaKvoa74ndeh0iMBHYhaHrRaCP2ZSb/w3sGMVopAj5x/IOuYoZVHtBtK LPAoDbNgE+VJjv1G0xMzGtBzFkr8ksCz6KpFqOPkk1JzOMQFVpK45gzzgHfvl4gYDfEO qG9KLvkbaALsqDoUXHU5xyApbXar2a9dNu2ZIi5Fto4rvGlA9wWbAqKGRNtBWwDHQJTi lXT953z4BcoOaczDjcHWJS/LKM2CDzWJjMWGAxGN9PZKSx/rs7o8AiufpEtGqSm3t472 XIo7uhMomf9Y7YpJRuYGnVK8UmskPYvaV4fXdTQC6gj34ORKGN4paOCzuTuurawuXgyc m0Ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si11702144ejx.100.2020.07.21.04.27.50; Tue, 21 Jul 2020 04:28:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729472AbgGULZd (ORCPT + 99 others); Tue, 21 Jul 2020 07:25:33 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46008 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728108AbgGULZd (ORCPT ); Tue, 21 Jul 2020 07:25:33 -0400 Received: by mail-wr1-f66.google.com with SMTP id s10so20773972wrw.12 for ; Tue, 21 Jul 2020 04:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eDTdOZ1dDPKD1UqSkexaZR5dMf1fmObppvOA9WWtcgo=; b=oyiOxy2/AXmOtGdpulNKvZqs63SrUho3mMqn10p/Rg8TxTq2vsHPwHjOaVGGgzboxq ccmU6ET2WiVAmiD8N+fMdgmtLg21QxmtN0bCE83cSATqOVo6KhcSU4X835UBVdT4GaSe xooh8ZRzKG1CqxJx519zEU+BPg1/R3UDEqiK5Fc+G1NKz0OUzytwM/QmxhibrM38s9PF 5KexqlnBLiNCI3G8xWaGZM3XKPEK6J9GmMwnkKY+zluvmmNfBl6oz7+xTysz/T7u/s06 kfykmNcuyQJVkf5eyvoZNft86cS7LjTrEfE7BUTw0t5YYwIekZDhtlPpoGmvHWO9Tlhk dVBA== X-Gm-Message-State: AOAM5338e80JIIqfMWMtgQ/YdxqA2ik7i4X2XPoXolX2OzpOlgUGPoLe Cl3xhKquGpCmkccy24Vk3WQ= X-Received: by 2002:a5d:4b0c:: with SMTP id v12mr17163309wrq.199.1595330731618; Tue, 21 Jul 2020 04:25:31 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id o21sm3068116wmh.18.2020.07.21.04.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 04:25:30 -0700 (PDT) Date: Tue, 21 Jul 2020 13:25:29 +0200 From: Michal Hocko To: Qian Cai Cc: linux-mm@kvack.org, LKML , Andrew Morton , Linus Torvalds , Tim Chen Subject: Re: [RFC PATCH] mm: silence soft lockups from unlock_page Message-ID: <20200721112529.GJ4061@dhcp22.suse.cz> References: <20200721063258.17140-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 21-07-20 07:10:14, Qian Cai wrote: > > > > On Jul 21, 2020, at 2:33 AM, Michal Hocko wrote: > > > > on a large ppc machine. The very likely cause is a suboptimal > > configuration when systed-udev spawns way too many workders to bring the > > system up. > > This is strange. The problem description is missing quite a few > important details. For example, what systems exactly are those? How > many CPUs, memory and NUMA nodes were you talking about? Are these really important? I believe I can dig that out from the bug report but I didn't really consider that important enough. > Which kernel version was it reported? It is a SLES 4.12 based kernel with the said commit backported. The page lock internals are thus in line with the upstream kernel. > How many workers from systemd-udev was “misconfigured”? I do not know that information. I believe that it used whatever systemd comes with as a default. And that can be a lot. Do you have any actual feedback to the patch? -- Michal Hocko SUSE Labs