Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Lee Jones <lee.jones@linaro.org>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Ben Dooks <ben@simtec.co.uk>
Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
In-Reply-To: <5862f649-8058-7e39-cb43-2a4b09303333@synopsys.com>
References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> <87blk9p5ia.fsf@kernel.org> <5862f649-8058-7e39-cb43-2a4b09303333@synopsys.com>
Date:   Tue, 21 Jul 2020 14:32:07 +0300
Message-ID: <875zahp0i0.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:

> Hi Felipe,
>
> On 7/21/2020 1:43 PM, Felipe Balbi wrote:
>> Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:
>>=20
>>> On 7/15/2020 1:32 PM, Lee Jones wrote:
>>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>>>> value.  Looks like this has been broken since
>>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>>>>
>>>> Also fixes the following W=3D1 warning:
>>>>
>>>>    drivers/usb/dwc2/gadget.c: In function =E2=80=98dwc2_gadget_wkup_al=
ert_handler=E2=80=99:
>>>>    drivers/usb/dwc2/gadget.c:259:6: warning: variable =E2=80=98gintmsk=
2=E2=80=99 set but not used [-Wunused-but-set-variable]
>>>>    259 | u32 gintmsk2;
>>>>    | ^~~~~~~~
>>>>
>>>> Cc: Minas Harutyunyan <hminas@synopsys.com>
>>>> Cc: Ben Dooks <ben@simtec.co.uk>
>>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert in=
terrupt")
>>>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>>
>>> Acked-by: Minas Harutyunyan <hminas@synopsys.com>
>>=20
>> Should I apply the entire series or only 1/8?
>>=20
> In this series only 2 patches are related to dwc2, which I'm already Acke=
d:
>
> [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
> [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control=20
> register
>
> I can't acked other patches from this series, because they are not=20
> related to dwc2.

heh, I saw that after sending the email, sorry :-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8W0jcACgkQzL64meEa
mQYkNA//SvFqXwJajGIbMxt0zxlYlwOUMXjMJAoVSgOROAwJX1x/7BU9NfjuPv1C
Ndy4KfZIOKX/QZVpFbVSAtK23AE5nS3dtPLuP1xhpX6ZDu6vKkwfRuXHPlotTx16
Na9Xq1u2sh9FGa1HeeCEwWVTad672OOsRuqA3ueS+K1bU3GjgbL/dyKcp435CQeP
oLw45QRIWWnOhmc+I1cs0dON4Xl6mCQwX+j7T3ztGUSLXjs8L+DOjBdo/ACBAdTp
yJuvTETyDU11uuckNRywwAxAIdw0AxypK2gLInoYGdyLhxrvE4STtMIF5MT4Ts8J
jnzD2ddDKLRS4mw2vpn1iKqKLt65loqJg7flcSAfV+wmcDIDpLOjWq5iYWl2Wto+
iTbAZO9PQnWVrPtIB7ghVfIG0d/QYxOphGHBnVhrNPq6g0F0ZmHG7KipWUMXBcbQ
v8pHE5cSh+R6SiWt8Exif0CeApworGdYb7bm8Cwe1pNSGWnjzzwphK1Dz4CSqjVI
PE30gykBihvQD+pR3I92HidcLDzDlMKKp8BHwYqzthdNg+TPQO3sWanucJJGCQno
FeGpLOiOX/8/TmMWZxILr+MEBsq8DI7ByxkQwqlqjXaRuVCFvQKQ5KBhSCpKlgOQ
ve/gQG2kHf2q35Kj3VhW0YYznwZv+zufDws7NJ2jvgLWSo9H7XM=
=Tbrc
-----END PGP SIGNATURE-----
--=-=-=--