Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rGJQAhneiP4UshgKM2y+mLpjqpW0XWJqEjwQ7dF6PNQk70Z7Fyp/kQ2rGuE+rKifz1+OtlAyeb
 nBpJshpiYXegznq5wlzTlnPCA7mRyoF0e/02JHqAtEvNQz2quP0KwsHJ4CSUXKV1eJDb0HTWl8
 CfA6AAn77Agspv0e4FDiUzVDTGV8kRfXlDhUR4sVyFUfct+Gz4sB9+9Bpy174WT45hal06Idzo
 WOeYO1L5t1e8BJdtP2+QMKlnd5smn8YC6PdaATNMRHyKb19Q4abkhyOr084iWrM8gNbTlYgxUw
 lDs=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Keith Busch <kbusch@kernel.org>,
        Josef Bacik <josef@toxicpanda.com>,
        "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
        Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        "open list:SCSI CDROM DRIVER" <linux-scsi@vger.kernel.org>,
        Tejun Heo <tj@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jason Wang <jasowang@redhat.com>,
        Maxim Levitsky <maximlevitsky@gmail.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Colin Ian King <colin.king@canonical.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Ajay Joshi <Ajay.Joshi@wdc.com>,
        Ming Lei <ming.lei@redhat.com>,
        "open list:SONY MEMORYSTICK SUBSYSTEM" <linux-mmc@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Satya Tangirala <satyat@google.com>,
        "open list:NETWORK BLOCK DEVICE (NBD)" <nbd@other.debian.org>,
        Hou Tao <houtao1@huawei.com>, Jens Axboe <axboe@fb.com>,
        "open list:VIRTIO CORE AND NET DRIVERS" 
        <virtualization@lists.linux-foundation.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 01/10] block: introduce blk_is_valid_logical_block_size
Thread-Topic: [PATCH 01/10] block: introduce blk_is_valid_logical_block_size
Thread-Index: AQHWX00wSEUVG8TRcky47gGqEX5tBw==
Date:   Tue, 21 Jul 2020 11:31:10 +0000
Message-ID: <CY4PR04MB37515A4950060845E5860755E7780@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <20200721105239.8270-1-mlevitsk@redhat.com>
 <20200721105239.8270-2-mlevitsk@redhat.com>
 <CY4PR04MB37512BDEFD7B977FCD32A10AE7780@CY4PR04MB3751.namprd04.prod.outlook.com>
 <cef747910431d81524e455e6380df1c610d1884c.camel@redhat.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7864c567-2879-4189-aa3c-08d82d699125
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 11:31:10.0297
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g3Rd0N9ktRlPFO/TECg2ASTK1CZUx2R6MZpF2OFQGAjh4bqEhlnqapi5PcTtjsKrpBCSjOg53ljVr68j8axx8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB1176
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/07/21 20:09, Maxim Levitsky wrote:=0A=
> On Tue, 2020-07-21 at 11:05 +0000, Damien Le Moal wrote:=0A=
>> On 2020/07/21 19:53, Maxim Levitsky wrote:=0A=
>>> Kernel block layer has never supported logical block=0A=
>>> sizes less that SECTOR_SIZE nor larger that PAGE_SIZE.=0A=
>>>=0A=
>>> Some drivers have runtime configurable block size,=0A=
>>> so it makes sense to have common helper for that.=0A=
>>=0A=
>> ...common helper to check the validity of the logical block size set by =
the driver.=0A=
> Agree, will fix.=0A=
>>=0A=
>> ("for that" does not refer to a clear action)=0A=
>>=0A=
>>> Signed-off-by: Maxim Levitsky  <mlevitsk@redhat.com>=0A=
>>> ---=0A=
>>>  block/blk-settings.c   | 18 ++++++++++++++++++=0A=
>>>  include/linux/blkdev.h |  1 +=0A=
>>>  2 files changed, 19 insertions(+)=0A=
>>>=0A=
>>> diff --git a/block/blk-settings.c b/block/blk-settings.c=0A=
>>> index 9a2c23cd97007..3c4ef0d00c2bc 100644=0A=
>>> --- a/block/blk-settings.c=0A=
>>> +++ b/block/blk-settings.c=0A=
>>> @@ -311,6 +311,21 @@ void blk_queue_max_segment_size(struct request_que=
ue *q, unsigned int max_size)=0A=
>>>  }=0A=
>>>  EXPORT_SYMBOL(blk_queue_max_segment_size);=0A=
>>>  =0A=
>>> +=0A=
>>> +/**=0A=
>>> + * blk_check_logical_block_size - check if logical block size is suppo=
rted=0A=
>>> + * by the kernel=0A=
>>> + * @size:  the logical block size, in bytes=0A=
>>> + *=0A=
>>> + * Description:=0A=
>>> + *   This function checks if the block layers supports given block siz=
e=0A=
>>> + **/=0A=
>>> +bool blk_is_valid_logical_block_size(unsigned int size)=0A=
>>> +{=0A=
>>> +	return size >=3D SECTOR_SIZE && size <=3D PAGE_SIZE && !is_power_of_2=
(size);=0A=
> Note here a typo, made in last minute change which I didn't test.=0A=
> It should be without '!'=0A=
=0A=
Oh ! Indeed. I missed that.=0A=
=0A=
> =0A=
> Best regards,=0A=
> 	Maxim Levitsky=0A=
> =0A=
>>> +}=0A=
>>> +EXPORT_SYMBOL(blk_is_valid_logical_block_size);=0A=
>>> +=0A=
>>>  /**=0A=
>>>   * blk_queue_logical_block_size - set logical block size for the queue=
=0A=
>>>   * @q:  the request queue for the device=0A=
>>> @@ -323,6 +338,8 @@ EXPORT_SYMBOL(blk_queue_max_segment_size);=0A=
>>>   **/=0A=
>>>  void blk_queue_logical_block_size(struct request_queue *q, unsigned in=
t size)=0A=
>>>  {=0A=
>>> +	WARN_ON(!blk_is_valid_logical_block_size(size));=0A=
>>> +=0A=
>>>  	q->limits.logical_block_size =3D size;=0A=
>>>  =0A=
>>>  	if (q->limits.physical_block_size < size)=0A=
>>> @@ -330,6 +347,7 @@ void blk_queue_logical_block_size(struct request_qu=
eue *q, unsigned int size)=0A=
>>>  =0A=
>>>  	if (q->limits.io_min < q->limits.physical_block_size)=0A=
>>>  		q->limits.io_min =3D q->limits.physical_block_size;=0A=
>>> +=0A=
>>=0A=
>> white line change.=0A=
>>=0A=
>>>  }=0A=
>>>  EXPORT_SYMBOL(blk_queue_logical_block_size);=0A=
>>>  =0A=
>>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h=0A=
>>> index 57241417ff2f8..2ed3151397e41 100644=0A=
>>> --- a/include/linux/blkdev.h=0A=
>>> +++ b/include/linux/blkdev.h=0A=
>>> @@ -1099,6 +1099,7 @@ extern void blk_queue_max_write_same_sectors(stru=
ct request_queue *q,=0A=
>>>  		unsigned int max_write_same_sectors);=0A=
>>>  extern void blk_queue_max_write_zeroes_sectors(struct request_queue *q=
,=0A=
>>>  		unsigned int max_write_same_sectors);=0A=
>>> +extern bool blk_is_valid_logical_block_size(unsigned int size);=0A=
>>>  extern void blk_queue_logical_block_size(struct request_queue *, unsig=
ned int);=0A=
>>>  extern void blk_queue_max_zone_append_sectors(struct request_queue *q,=
=0A=
>>>  		unsigned int max_zone_append_sectors);=0A=
>>>=0A=
>>=0A=
>>=0A=
> =0A=
> =0A=
> =0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=