Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp684504ybh; Tue, 21 Jul 2020 05:35:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3A28y6AInD3mJDoy+lQkzLA6N+6tZUj4qKyjnOdigMChVHyciU03HJO9S9XgcN6WbncHM X-Received: by 2002:aa7:cf82:: with SMTP id z2mr24520208edx.15.1595334929129; Tue, 21 Jul 2020 05:35:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595334929; cv=none; d=google.com; s=arc-20160816; b=vrvVf+IabUa4aWSMVSB617tKq/oQsKtuRLTUXAsGivfWfTRrBY8a9GeAHdPU+Hdeuy S01OCf7Ir2LugMNNi9TUbW8sobIkW2dnvYJD3VC9R8XWUI8z/g0VOlxGzCCLMWtyJiC6 zm9avOrIR0Bp3Y0DNxFwUMIoSt9I9XxKziWTlRLaVQhY0qYWtoOAp0Ln2DnSq1wo+nZY ysCxoddXvlFlABbaaDVZuSsZoqiOHEL6wS2B9P2qi9CGrrLmt09LJfdJRDFg3rSFG2UH wdXjhPhxvAPAdy1cS9lm83m1SzkK7AW9zCX7BE3sH3TSZ/87h3u7c11Ij5LpIz/4VIl/ 2auA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=xcrj1EvZ0npkXORX0xqJdoPGLAvb3EgMBNkxtaYbSj8=; b=ENwYbBR4GygHH8BAAGIhcYy28DXWq/LlTCRHdQkpUrlxr7tTicnqRDXuDdk20uimvQ RtdQWf+Xi0qExOWPHxvQlxq3NkKtxZfZ5y+9fg206BFGQt2Ffn3nevOH/UxoVH8h4jW6 Uymu69FwXKGvlR105Fi9vTXIhiOvQ+p2u2ouDysdK3ML93ynYERDfutOlHvtB5HVfFUN YE/qG17h5j2qHcxsjuJZkyFXZbOsx3XHJ87koXYOWFhNYVbdkp8JsM3aVmEZrQRQfZ/R dR20j36wbxTsRJlPu/ZxSWjiUJVyXHNY7FUSBBdyBOU4e+Txxqf7R+7Iqu2R4HyLdSnn MQEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co17si11671153edb.437.2020.07.21.05.35.06; Tue, 21 Jul 2020 05:35:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729183AbgGUMef (ORCPT + 99 others); Tue, 21 Jul 2020 08:34:35 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49670 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728557AbgGUMee (ORCPT ); Tue, 21 Jul 2020 08:34:34 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E8E19B16BE2F347E0C0B; Tue, 21 Jul 2020 20:34:30 +0800 (CST) Received: from [127.0.0.1] (10.174.179.238) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Jul 2020 20:34:22 +0800 Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX To: David Miller CC: , , , , , , , References: <20200716173247.78912-1-cuibixuan@huawei.com> <20200719100522.220a6f5a@hermes.lan> <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> <20200720.183849.626605331445628040.davem@davemloft.net> From: Bixuan Cui Message-ID: <16aa9f4a-583e-2fd1-c14f-a3b2a6228436@huawei.com> Date: Tue, 21 Jul 2020 20:34:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200720.183849.626605331445628040.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/21 9:38, David Miller wrote: > From: Bixuan Cui > Date: Mon, 20 Jul 2020 09:58:39 +0800 > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37': >> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: >> warning: the frame size of 1056 bytes is larger than 1024 bytes >> >> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't >> have much impact on performance and functionality. >> >> Signed-off-by: Bixuan Cui >> Signed-off-by: Stephen Hemminger >> --- >> v2: Dropping the NR_SKB_COMPLETED to 16. > Applied. thanks.