Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp708979ybh; Tue, 21 Jul 2020 06:11:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy29IuuHI4YUjAulmW/aAAQwd/Cvs1kxxHIUbzT5oWF4TjgIcqZIQzOJzjZbybW9YGLplVV X-Received: by 2002:a05:6402:49:: with SMTP id f9mr19333957edu.112.1595337092462; Tue, 21 Jul 2020 06:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595337092; cv=none; d=google.com; s=arc-20160816; b=axEkXJfGm2Jgsfmai7Zr8kSH9nHCdxTwymAaOIb+jCNIYStePCMCnOWqTq+cbpcaip E/Y1O2qnTCEBjCXIoXZZHHA2ZbCq2RqlMe0Il9EyXiHDZZ6QYvpfSZ8NGFbofVpveHgL owDUymWmxI84jeKAdeqJc9L08C5B4QoQCiVbQogFjqWX7TaR7WRo635Rs/S2tah/UGJf IW+gqY882TVOw+mpIwqIlbESaQj6wN3sqDBUHg/uk+TAxfxWyFj31g+8mAwdBOJhjmaX wIsh5uMGVa6nA7huQA8xWc0YMLohIltwKSwYuypeTe7Cci/BEsCtM4dOF4z/t7XctaFy o5PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=uspFApc8puM1BUiw5XeOPxdzPCrzz+1diVlKTsT1F/c=; b=O/7bjFqllEb08jkk0mO46dpzv3rVohlXHkQ8QUm/x/ib1kEYsEoojUlj0DtZGNZsyk NDYeh4TiMHlfKnqR1uiGYRPKAvVqcCsKpvdbIa8zaOYPkc6Ufy7oeYQNAPu4U3gBraEM 48sjtGiAzr9bqn47O3gkR+uUmsxtUmyuXliHoAp9j6zOpg5j+G0xwMcjQ3L/ZlpgR2Yb 86GlNJMlARPOMhZNiClaoSJDbJlgq1R0rvJeiUEWVRwNt6pfNJep+8u+K8yE9BNopBO8 212xigDnws6aoQjX8P0NRplfsIfEyMr+Oan999sSqeMdjbJ787yXybDAXea27ej3G5Au DyYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si13045394ejw.73.2020.07.21.06.11.08; Tue, 21 Jul 2020 06:11:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbgGUNIx (ORCPT + 99 others); Tue, 21 Jul 2020 09:08:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:7211 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgGUNIw (ORCPT ); Tue, 21 Jul 2020 09:08:52 -0400 IronPort-SDR: 7Puqgciov1Y2cQvXkpK7HqKoiWHRsA7ZXQe1PwdsF7rLr8kwgWPsOqUsdAD1i+kMNCKVjdWg36 d2UCubrrC1xA== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="137610798" X-IronPort-AV: E=Sophos;i="5.75,378,1589266800"; d="scan'208";a="137610798" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 06:08:51 -0700 IronPort-SDR: FscKyFSJYpwm0edcPqe8S2lioAjregQkXbQ0CxU62nEOHXi0ZBMcv3DeLh85gLVtyKSo/Tichb A0h4lCsEzetA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,378,1589266800"; d="scan'208";a="392343948" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 21 Jul 2020 06:08:47 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 21 Jul 2020 16:08:47 +0300 Date: Tue, 21 Jul 2020 16:08:47 +0300 From: Mika Westerberg To: Lukas Wunner Cc: Lyude Paul , Bjorn Helgaas , Karol Herbst , Sasha Levin , Patrick Volkerding , Linux PCI , linux-kernel@vger.kernel.org, dri-devel , Kai-Heng Feng , Ben Skeggs , nouveau , Bjorn Helgaas Subject: Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms" Message-ID: <20200721130847.GK5180@lahna.fi.intel.com> References: <20200716235440.GA675421@bjorn-Precision-5520> <20200717195209.vmtyfmgweoo645lh@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717195209.vmtyfmgweoo645lh@wunner.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 09:52:09PM +0200, Lukas Wunner wrote: > On Fri, Jul 17, 2020 at 03:04:10PM -0400, Lyude Paul wrote: > > Isn't it possible to tell whether a PCI device is connected through > > thunderbolt or not? We could probably get away with just defaulting > > to 100ms for thunderbolt devices without DLL Link Active specified, > > and then default to the old delay value for non-thunderbolt devices. > > pci_is_thunderbolt_attached() That only works with some devices. I think we should try to keep the fact that some PCIe links may be tunneled over TBT/USB4 transparent to the PCI core and try to treat them as "standard" PCIe links if possible at all :)