From: Herbert Xu <herbert@gondor.apana.org.au>
To: chrisw@sous-sol.org (Chris Wright)
Subject: Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device	driver.
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
       Christian.Limpach@cl.cam.ac.uk, xen-devel@lists.xensource.com,
       netdev@vger.kernel.org, ian.pratt@xensource.com
Organization: Core
In-Reply-To: <20060509085201.446830000@sous-sol.org>
User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Message-Id: <E1FdQoP-0007iN-00@gondolin.me.apana.org.au>
Date: Tue, 09 May 2006 21:55:33 +1000
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 29

Hi Chris:

Chris Wright <chrisw@sous-sol.org> wrote:
>
> +/** Send a packet on a net device to encourage switches to learn the
> + * MAC. We send a fake ARP request.
> + *
> + * @param dev device
> + * @return 0 on success, error code otherwise
> + */
> +static int send_fake_arp(struct net_device *dev)

I think we talked about this before.  I don't see why Xen is so special
that it needs its own gratuitous arp routine embedded in the driver.
If this is needed at all (presumably for migration) then it should be
performed by the management scripts which can send grat ARP packets just
as easily.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/