Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200721140233.2063475-1-drew@beagleboard.org> <20200721141034.GA2064533@x1>
In-Reply-To: <20200721141034.GA2064533@x1>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Jul 2020 17:17:10 +0300
Message-ID: <CAHp75VdfjYuau0cPES7LUy-jN_RLX-L3kspVRMP+1OSZVocmFA@mail.gmail.com>
Subject: Re: [PATCH v3] pinctrl: core: print gpio in pins debugfs file
To:     Drew Fustini <drew@beagleboard.org>
Cc:     Tony Lindgren <tony@atomide.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jason Kridner <jkridner@beagleboard.org>,
        Robert Nelson <robertcnelson@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 21, 2020 at 5:10 PM Drew Fustini <drew@beagleboard.org> wrote:
> On Tue, Jul 21, 2020 at 04:02:34PM +0200, Drew Fustini wrote:
> > If there is a gpio range mapping for the pin, then print out the gpio
> > chip and line index for the pin in the debugfs 'pins' file with the
> > format: "[gpiochip-label]:line-[index] "
> >
> > For example, here is a section of 'pins' the PocketBeagle (AM3358):
> > /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pins
> >
> > pin 25 (PIN25) gpio-32-63:line-25 44e10864 00000037 pinctrl-single
> > pin 26 (PIN26) gpio-32-63:line-26 44e10868 00000037 pinctrl-single
> > pin 27 (PIN27) gpio-32-63:line-27 44e1086c 00000037 pinctrl-single
> > pin 28 (PIN28) NA 44e10870 00000036 pinctrl-single
> > pin 29 (PIN29) NA 44e10874 00000006 pinctrl-single
> > pin 30 (PIN30) gpio-32-63:line-28 44e10878 00000027 pinctrl-single
> > pin 31 (PIN31) gpio-32-63:line-29 44e1087c 00000037 pinctrl-single
> > pin 32 (PIN32) gpio-32-63:line-30 44e10880 00000037 pinctrl-single
> > pin 33 (PIN33) gpio-32-63:line-31 44e10884 00000037 pinctrl-single
> > pin 34 (PIN34) gpio-64-95:line-0 44e10888 00000037 pinctrl-single
> > pin 35 (PIN35) gpio-64-95:line-1 44e1088c 00000037 pinctrl-single

Because line is integer and label is string it is better (from parsing
of view) to put it other way around, i.e.

%u:%s, label, line

...

> Apologies - I should not have put the change log in the commit message.
> Please let me know if I should resubmit.

Since the above comment, I guess it would be good.
Thanks for doing this!

-- 
With Best Regards,
Andy Shevchenko