Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200721022324.21898-1-fengping.yu@mediatek.com>
 <20200721022324.21898-3-fengping.yu@mediatek.com> <87ft9l3v2l.fsf@baylibre.com>
In-Reply-To: <87ft9l3v2l.fsf@baylibre.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Jul 2020 17:23:03 +0300
Message-ID: <CAHp75VcnfF3ucuAJXDDy8pit5-LE42d4ROkL2y3QZroK6RU4Rw@mail.gmail.com>
Subject: Re: [PATCH v15 2/3] drivers: input:keyboard: Add mtk keypad driver
To:     Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc:     Fengping yu <fengping.yu@mediatek.com>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 21, 2020 at 3:38 PM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
> Fengping yu <fengping.yu@mediatek.com> writes:

> > This adds matrix keypad support for Mediatek SoCs.

...

> > +     keypad->regmap = devm_regmap_init_mmio(&pdev->dev,
> > +                                            keypad->base,
> > +                                            &keypad_regmap_cfg);
> > +     if (IS_ERR(keypad->regmap)) {
> > +             dev_err(&pdev->dev,
> > +                     "regmap init failed:%ld\n", PTR_ERR(keypad->regmap));
> > +             return PTR_ERR(keypad->regmap);
> > +     }

Okay, because another comment appeared, I would suggest to switch to
%pe at the same time.

            dev_err(&pdev->dev,   "regmap init failed: %pe\n", keypad->regmap);

-- 
With Best Regards,
Andy Shevchenko