Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp771083ybh; Tue, 21 Jul 2020 07:35:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQOq1C1IyXE1NJdlrTYDY9zyosAe6o1y2IXoyMJBnzjeh6eYc3BYkV875AjqQjPczSiAyq X-Received: by 2002:a50:ee01:: with SMTP id g1mr25391534eds.264.1595342109020; Tue, 21 Jul 2020 07:35:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595342109; cv=none; d=google.com; s=arc-20160816; b=ttcpOyMUjfv3jYw2q6R8kTZ4LAe93wbXD0X2IPiGAnzBH0DuqMA6j05navAXicUF9e PGEydUpe8HwsGIc+ZFc5gTpqhjyiaqF7w3aGZ1Eui2u0RH//u3F7C0j49mo2VgN7zfvR kCv7pZhR02I+FWSFXA1dilUmCJi0U90rB7/N4gNYvznI+Q/4Ws2GdVdrkosaRYiB1xQn 7tszYnWS8ChBN0aEIOFr95ckSDLA6TIrDdbzC6rcKpX53Vev+jXJNX02dqAE4rmeOhqs n7U5/OGvcgb3+0V8l70lZIAH94VBMj2ukpIRZnhbdJILQcniB7ye/TihYJTVI11rGvJ/ j3Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Hi6P4Qs50oKPaCKO+GKE9jAaYPLC88y2se+OEd+o/uY=; b=JjWmU0lGVi5zYUVYDPe/wOmTrquNsNTwHyAbZ4cj2Db8YC6thnhrHk32iP1YynxfZ+ yQzQtkhOYka60+2UcI9f6W4itGmG4fH0Gfnv02xC/5FVdrleuHtzUnGnG2lI352Tboys Fq5CB7be2r13hRV8gfC3ykARM9dS1UNCn5AQl5CCfo/KS3FK+F6bMYir5tnBPP2EPUtN j0LBP83ewYFdTaxCRlc/xiSbA/EsIOdd4Afs2zWp4NGFePNIQ8ada2rWQAHqFVfO4PQT Zl7ENXS7k0JA7gZ5VL8AeqVqq9Xm6+QxzouLpObVOt85tfF5mfnMeWGMfcG8A4uQ28xL SN/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si12669540edo.320.2020.07.21.07.34.45; Tue, 21 Jul 2020 07:35:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbgGUOeP (ORCPT + 99 others); Tue, 21 Jul 2020 10:34:15 -0400 Received: from verein.lst.de ([213.95.11.211]:52411 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbgGUOeP (ORCPT ); Tue, 21 Jul 2020 10:34:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6186C68AFE; Tue, 21 Jul 2020 16:34:12 +0200 (CEST) Date: Tue, 21 Jul 2020 16:34:12 +0200 From: Christoph Hellwig To: Andy Lutomirski Cc: Christoph Hellwig , Jens Axboe , linux-arch , Linux API , LKML , io-uring@vger.kernel.org Subject: Re: io_uring vs in_compat_syscall() Message-ID: <20200721143412.GA8099@lst.de> References: <8987E376-6B13-4798-BDBA-616A457447CF@amacapital.net> <20200721070709.GB11432@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 07:31:02AM -0700, Andy Lutomirski wrote: > > What do you mean with "properly wired up". Do you really want to spread > > ->compat_foo methods everywhere, including read and write? I found > > in_compat_syscall() a lot small and easier to maintain than all the > > separate compat cruft. > > I was imagining using a flag. Some of the net code uses > MSG_CMSG_COMPAT for this purpose. Killing that nightmarish monster is what actually got me into looking io_uring and starting this thread.