Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp771322ybh; Tue, 21 Jul 2020 07:35:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzodEe60W3ZKAl9RZQkjdZrNgnqLOOYmXvDv/atcGoWOo7vh8mF07yWtwP2ZaLKoPIXi73D X-Received: by 2002:a05:6402:b9b:: with SMTP id cf27mr26816601edb.84.1595342126743; Tue, 21 Jul 2020 07:35:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595342126; cv=none; d=google.com; s=arc-20160816; b=McK35BpvB65257elBs0A9F1dPUpdu0J3dqhK7q4UIcaZiW4yV9KdRAdbIT12QeYNGo Tf9v2YUFnmgOlB70e7mCbcZeX1mpZzjVY+xz9SOQT9ewkGDGwk3oe1j4GiQO0jOW+iTO gWXDd/drxDgfTZ/fYF0r+d3yjYbdctijy+vrraayYLFIv9x/4jvRlnQKgVLeC/VhCH6g UX+m6tsJ32qj4vLRO5uPo0hh6G3TOrkiXQkdhoJidXNDnA8EGANwzUBeJDCY6vlIyQuD vLWIP7PyG8fI8XePF7F/czdFmo33cdsV6fJiwOKdOASsjVU/NwH6lGuBJLsqRI8bpHOz oh0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=awvO/AxzZMb5RICr1smsNlHEgfMyuxuSrzQI8mKeLw0=; b=dYXVcg8mUded+XfHu20+Bwu7iR4Vigb1Q0Qbi4evckeugtDzUXeVAuXtzc6rVhFIy0 8e+bgC9h0xjvw+Tsijob/sPUVXbpezqef+E7o1+XKK7+/Ton2b8ViiynX5WYjrYZZ6fN IrQwyIJOpGPte1KtJyUFr0euzglsqVrJI1jUKB04/kC8D0E+j5TmifR7EEIizcmYPinF Q7F+J1deBSJVkqe6hCIhlHAjwgj7jWAQ9LDgUnt19zJbwytdI55YXQPL4bQjM/C4fvGO 23znn4PPe0dNly1aGLaruihNT26GV9w9iP4hqhiMtuKi71KEePiobIoWKvJd00tAtNft cT8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="QdO/VkrL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk3si13640976ejb.323.2020.07.21.07.35.04; Tue, 21 Jul 2020 07:35:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="QdO/VkrL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbgGUOem (ORCPT + 99 others); Tue, 21 Jul 2020 10:34:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726412AbgGUOel (ORCPT ); Tue, 21 Jul 2020 10:34:41 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43D3CC061794; Tue, 21 Jul 2020 07:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=awvO/AxzZMb5RICr1smsNlHEgfMyuxuSrzQI8mKeLw0=; b=QdO/VkrL9Ut3AyXGXc0eOxFwZf ydHUDTMC0Sz0h8xQjhpBJVcOhUGVHhOy655jDK/cQtB4ES3xAREo1eJbUmQ5/HyJlPVUtUddajOG7 NUg5n96enPPuq7Q/+xgrA1/hZ89vAvsqyTGvbmZGLAcaRVflMKjWRy1dfJJ9dpzlpI4MIT55qCuIb XVwaqFVRBhNxhDapqdfK9kQV9kEhj/bQkVmNMZa2lKZJM0QpRzIgzfTotGsXnrxSuNt6hlx5zm7B0 6uyUxL3pDvnjud42NM+WbGO+DV8+X9MV2P/zrTlN37w4desmyvBzjfuBj96iRFWN5IaSY7UZgAiAB gszf8JbQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxtLl-0002ZX-ID; Tue, 21 Jul 2020 14:34:33 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5FE973011C6; Tue, 21 Jul 2020 16:34:32 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 24B9C25E22790; Tue, 21 Jul 2020 16:34:32 +0200 (CEST) Date: Tue, 21 Jul 2020 16:34:32 +0200 From: peterz@infradead.org To: Marco Elver Cc: paulmck@kernel.org, will@kernel.org, arnd@arndb.de, mark.rutland@arm.com, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 3/8] kcsan: Skew delay to be longer for certain access types Message-ID: <20200721143432.GM119549@hirez.programming.kicks-ass.net> References: <20200721103016.3287832-1-elver@google.com> <20200721103016.3287832-4-elver@google.com> <20200721140523.GA10769@hirez.programming.kicks-ass.net> <20200721142654.GA3396394@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721142654.GA3396394@elver.google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 04:26:54PM +0200, Marco Elver wrote: > I'll rewrite the commit message: > > For compound instrumentation and assert accesses, skew the > watchpoint delay to be longer if randomized. This is useful to > improve race detection for such accesses. > > For compound accesses we should increase the delay as we've > aggregated both read and write instrumentation. By giving up 1 > call into the runtime, we're less likely to set up a watchpoint > and thus less likely to detect a race. We can balance this by > increasing the watchpoint delay. Aah, makes sense now. Thanks!