Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932485AbWEIMoO (ORCPT ); Tue, 9 May 2006 08:44:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932488AbWEIMoO (ORCPT ); Tue, 9 May 2006 08:44:14 -0400 Received: from mta1.cl.cam.ac.uk ([128.232.0.15]:53121 "EHLO mta1.cl.cam.ac.uk") by vger.kernel.org with ESMTP id S932485AbWEIMoN (ORCPT ); Tue, 9 May 2006 08:44:13 -0400 Date: Tue, 9 May 2006 13:43:59 +0100 From: Christian Limpach To: Herbert Xu Cc: Chris Wright , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, netdev@vger.kernel.org, ian.pratt@xensource.com Subject: Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver. Message-ID: <20060509124359.GA5407@cl.cam.ac.uk> References: <20060509085201.446830000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 34 On Tue, May 09, 2006 at 09:55:33PM +1000, Herbert Xu wrote: > Hi Chris: > > Chris Wright wrote: > > > > +/** Send a packet on a net device to encourage switches to learn the > > + * MAC. We send a fake ARP request. > > + * > > + * @param dev device > > + * @return 0 on success, error code otherwise > > + */ > > +static int send_fake_arp(struct net_device *dev) > > I think we talked about this before. I don't see why Xen is so special > that it needs its own gratuitous arp routine embedded in the driver. > If this is needed at all (presumably for migration) then it should be > performed by the management scripts which can send grat ARP packets just > as easily. There's at least two reasons why having it in the driver is preferable: - synchronizing sending the fake ARP request with when the device is operational -- you really want to make this well synchronized to keep unreachability as short as possible, especially when doing live migration - anybody but the guest might not know (all) the MAC addresses for which to send a fake ARP request christian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/