Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp802797ybh; Tue, 21 Jul 2020 08:16:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcgu4M4JhigsGZGxmijifuWMcpfYKTDSmP8umCXc+htWEd96vJmAnREBZpZgZL5MuTiVgQ X-Received: by 2002:a17:906:c30b:: with SMTP id s11mr26325188ejz.263.1595344580171; Tue, 21 Jul 2020 08:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595344580; cv=none; d=google.com; s=arc-20160816; b=Oyd1poTl16h9HZBy26yzHFCYS8vzoXsj6rpJqZtajNPCHVSafwSS0nb+vp/H8Zcx1S AVdQSNx/d90G9QNpXmZPJ2G5atazBgCHJcu9ppIOFR4l8Vc5ibSetvIRG3Iz+/8KfvZf mmf3ya4IFPR11Z2vADSqjNohzu6rDB1fzBecqwh8wAeM5xSgpxev+PhE3XdHMZFFWBHG i/URpUkm5VW5eBmO+UnnQHifuu/Aq+tQZJIqaqS2QFMtgOFs4noL6/oDDPeDlM2pkJN0 Sua2QdIL80n28uCk4eJ3UG+21Zn2KRLGWqB+H5dgYmszqnW/Mh2iabSjnrRuBjf/lBeG 7Zxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=vq0hkATSqNgqKrb4Mg6LOe5yBfHuHqQ3A5BsUOXlR9k=; b=MdGrmvLsZh2EWsOibB7Ki1VIVoMPtoVptWvLvZKg0XAJ2GLzcmOwTFNL/g+Nb6bvaI xw6U3j5O6MvPnMNAdPXIBV5bdBzNcojclqSxDB2qEBx3XYr0hsiDjqTc6Wv1xU7aB6Ki 6S/Hp6uNMEZQYYRuARwyWyPDtgjqoZnoZpy/IggC2sulGjgeWJRBasYwVimhTPl3rkuJ pUqbwbrh6TR+7ddNSMMReJOBPeVDRkyabJbhPfb+Z/TBLEJmbumshPzcTafuq9Yo+WgN C0sBRVW2ulGKXlm8MH/pStT35Y5Q5InbodUWjAhzQ/kPW1xikkVHvoxablIEUo+fiXFc JTdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mf6si12371611ejb.660.2020.07.21.08.15.57; Tue, 21 Jul 2020 08:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729732AbgGUPNf (ORCPT + 99 others); Tue, 21 Jul 2020 11:13:35 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8349 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726436AbgGUPNf (ORCPT ); Tue, 21 Jul 2020 11:13:35 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B5C1DEAAEC10087F6974; Tue, 21 Jul 2020 23:13:29 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Jul 2020 23:13:18 +0800 From: Wei Yongjun To: Ben Skeggs , David Airlie , "Daniel Vetter" , Lyude Paul , Dave Airlie CC: Wei Yongjun , , , , , Hulk Robot Subject: [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak Date: Tue, 21 Jul 2020 15:17:01 +0000 Message-ID: <20200721151701.51412-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c index f17fb6d56757..4971a1042415 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c @@ -706,6 +706,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = { .open = nv50_crc_debugfs_flip_threshold_open, .read = seq_read, .write = nv50_crc_debugfs_flip_threshold_set, + .release = single_release, }; int nv50_head_crc_late_register(struct nv50_head *head)