Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200721001505.GD19262@shao2-debian>
In-Reply-To: <20200721001505.GD19262@shao2-debian>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Tue, 21 Jul 2020 18:59:31 +0300
Message-ID: <CAOQ4uxgq39EDS_k3eDTngEAm8cxHPa7qrkUSW8Rk6qS9cxC18w@mail.gmail.com>
Subject: Re: [fsnotify] c738fbabb0: will-it-scale.per_process_ops -9.5% regression
To:     kernel test robot <rong.a.chen@intel.com>
Cc:     Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
        lkp@lists.01.org
Content-Type: multipart/mixed; boundary="0000000000002d923105aaf5b690"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--0000000000002d923105aaf5b690
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 21, 2020 at 3:15 AM kernel test robot <rong.a.chen@intel.com> wrote:
>
> Greeting,
>
> FYI, we noticed a -9.5% regression of will-it-scale.per_process_ops due to commit:
>
>
> commit: c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a ("fsnotify: fold fsnotify() call into fsnotify_parent()")

Strange, that's a pretty dumb patch moving some inlined code from one
function to
another (assuming there are no fsnotify marks in this test).

Unless I am missing something the only thing that changes slightly is
an extra d_inode(file->f_path.dentry) deference.
I can get rid of it.

Is it possible to ask for a re-test with fix patch (attached)?

Thanks,
Amir.

--0000000000002d923105aaf5b690
Content-Type: text/plain; charset="US-ASCII"; 
	name="fsnotify-pass-inode-to-fsnotify_parent.patch.txt"
Content-Disposition: attachment; 
	filename="fsnotify-pass-inode-to-fsnotify_parent.patch.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_kcw4gz9c0>
X-Attachment-Id: f_kcw4gz9c0

RnJvbSAyNmRjM2QyYmZmNjIzNzY4Y2JiZDBjODA1M2RkZDYzOTBmZDgyOGQyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWlyIEdvbGRzdGVpbiA8YW1pcjczaWxAZ21haWwuY29tPgpE
YXRlOiBUdWUsIDIxIEp1bCAyMDIwIDE4OjUyOjE4ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gZnNu
b3RpZnk6IHBhc3MgaW5vZGUgdG8gZnNub3RpZnlfcGFyZW50KCkKCldlIGNhbiBnZXQgaW5vZGUg
YnkgZGVyZWZlcmVuY2VpbmcgZGVudHJ5LT5kX2lub2RlLCBidXQgdGhhdCBtYXkgaGF2ZQpwZXJm
b3JtYW5jZSBpbXBhY3QgaW4gdGhlIGZhc3QgcGF0aCBvZiBub24gd2F0Y2hlZCBmaWxlLgoKS2Vy
bmVsIHRlc3Qgcm9ib3QgcmVwb3J0ZWQgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIGluIGNvbmN1
cnJlbnQgb3Blbgp3b3JrbG9hZCwgc28gbWF5YmUgdGhhdCBjYW4gZml4IGl0LgoKUmVwb3J0ZWQt
Ynk6IGtlcm5lbCB0ZXN0IHJvYm90IDxyb25nLmEuY2hlbkBpbnRlbC5jb20+CkZpeGVzOiBjNzM4
ZmJhYmIwZmYgKCJmc25vdGlmeTogZm9sZCBmc25vdGlmeSgpIGNhbGwgaW50byBmc25vdGlmeV9w
YXJlbnQoKSIpClNpZ25lZC1vZmYtYnk6IEFtaXIgR29sZHN0ZWluIDxhbWlyNzNpbEBnbWFpbC5j
b20+Ci0tLQogaW5jbHVkZS9saW51eC9mc25vdGlmeS5oIHwgMTEgKysrKysrLS0tLS0KIDEgZmls
ZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
aW5jbHVkZS9saW51eC9mc25vdGlmeS5oIGIvaW5jbHVkZS9saW51eC9mc25vdGlmeS5oCmluZGV4
IDMxNmM5YjgyMDUxNy4uZDQ5ZTUzMThhYWQ5IDEwMDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L2Zz
bm90aWZ5LmgKKysrIGIvaW5jbHVkZS9saW51eC9mc25vdGlmeS5oCkBAIC00NiwxMCArNDYsOSBA
QCBzdGF0aWMgaW5saW5lIHZvaWQgZnNub3RpZnlfZGlyZW50KHN0cnVjdCBpbm9kZSAqZGlyLCBz
dHJ1Y3QgZGVudHJ5ICpkZW50cnksCiAKIC8qIE5vdGlmeSB0aGlzIGRlbnRyeSdzIHBhcmVudCBh
Ym91dCBhIGNoaWxkJ3MgZXZlbnRzLiAqLwogc3RhdGljIGlubGluZSBpbnQgZnNub3RpZnlfcGFy
ZW50KHN0cnVjdCBkZW50cnkgKmRlbnRyeSwgX191MzIgbWFzaywKLQkJCQkgIGNvbnN0IHZvaWQg
KmRhdGEsIGludCBkYXRhX3R5cGUpCisJCQkJICBjb25zdCB2b2lkICpkYXRhLCBpbnQgZGF0YV90
eXBlLAorCQkJCSAgc3RydWN0IGlub2RlICppbm9kZSkKIHsKLQlzdHJ1Y3QgaW5vZGUgKmlub2Rl
ID0gZF9pbm9kZShkZW50cnkpOwotCiAJaWYgKFNfSVNESVIoaW5vZGUtPmlfbW9kZSkpCiAJCW1h
c2sgfD0gRlNfSVNESVI7CiAKQEAgLTY4LDcgKzY3LDggQEAgc3RhdGljIGlubGluZSBpbnQgZnNu
b3RpZnlfcGFyZW50KHN0cnVjdCBkZW50cnkgKmRlbnRyeSwgX191MzIgbWFzaywKICAqLwogc3Rh
dGljIGlubGluZSB2b2lkIGZzbm90aWZ5X2RlbnRyeShzdHJ1Y3QgZGVudHJ5ICpkZW50cnksIF9f
dTMyIG1hc2spCiB7Ci0JZnNub3RpZnlfcGFyZW50KGRlbnRyeSwgbWFzaywgZF9pbm9kZShkZW50
cnkpLCBGU05PVElGWV9FVkVOVF9JTk9ERSk7CisJZnNub3RpZnlfcGFyZW50KGRlbnRyeSwgbWFz
aywgZF9pbm9kZShkZW50cnkpLCBGU05PVElGWV9FVkVOVF9JTk9ERSwKKwkJCWRfaW5vZGUoZGVu
dHJ5KSk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgaW50IGZzbm90aWZ5X2ZpbGUoc3RydWN0IGZpbGUg
KmZpbGUsIF9fdTMyIG1hc2spCkBAIC03OCw3ICs3OCw4IEBAIHN0YXRpYyBpbmxpbmUgaW50IGZz
bm90aWZ5X2ZpbGUoc3RydWN0IGZpbGUgKmZpbGUsIF9fdTMyIG1hc2spCiAJaWYgKGZpbGUtPmZf
bW9kZSAmIEZNT0RFX05PTk9USUZZKQogCQlyZXR1cm4gMDsKIAotCXJldHVybiBmc25vdGlmeV9w
YXJlbnQocGF0aC0+ZGVudHJ5LCBtYXNrLCBwYXRoLCBGU05PVElGWV9FVkVOVF9QQVRIKTsKKwly
ZXR1cm4gZnNub3RpZnlfcGFyZW50KHBhdGgtPmRlbnRyeSwgbWFzaywgcGF0aCwgRlNOT1RJRllf
RVZFTlRfUEFUSCwKKwkJCSAgICAgICBmaWxlX2lub2RlKGZpbGUpKTsKIH0KIAogLyogU2ltcGxl
IGNhbGwgc2l0ZSBmb3IgYWNjZXNzIGRlY2lzaW9ucyAqLwotLSAKMi4xNy4xCgo=
--0000000000002d923105aaf5b690--