Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp842244ybh; Tue, 21 Jul 2020 09:10:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydn2cOFo5xQt5J1bE+man9Lz4ibIiWnmFul0TdZB1lowM1P5xNENulADTfa9k9i7pP+NGg X-Received: by 2002:a17:906:fb81:: with SMTP id lr1mr25358989ejb.104.1595347837122; Tue, 21 Jul 2020 09:10:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595347837; cv=none; d=google.com; s=arc-20160816; b=mELLIOeXEXnJlEe1+mv2nmwhogwZqMiYgKLhTZzho+zqGdD1hLSbyEBFQr73EEXml1 WKf3CziMJpdcBZxgGh7l8qWc3fyY49jPfJSXK5rEBxfoNdjpRUZzSFwG3Ze6ISZBYZZc C+ypVyaAum2QaUgF/93WvO3ijwkHQ6dsgCywEDJ7MaM9PcDlg++BkMVZG4/zExArFqd1 0Wb/RmS7hjUZuazrZXvT15McAKJ1/Eo3InOcLo4RafZ23EGocFbTU5+HVnXBQhNBfrrT 4hoR/4zCEKDooBozLghsPVyLEbLzN5L0NiADjiWakxFgRkoNL/2sHpui9LuPzkhBtnN1 5Qyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JGXo1HLmj0B/GHBmTJocAxawqfuB0THi+fafWm8sJoM=; b=uOIrizrBU9+Hwn9Lg6/maCxSECj+qX+++nWZBZC07yFlGqxLsOggSAlDNq2us9Hi4q yHhu+YIw0Bdpl322HNdeRXQazkVpy4Z/u6IK3CfOXBBeQeRD6BSy9Zcp7WCQeAtD8kUY dTU46sChE3toNNHdHalCuyvoVKhb/9aW63PJQ/hLnzMR8Si6nB6ngPoNDFfNEVLDU1lM 66VsPdmR0nc6DIj/agzLebseBScY46y0/MjWvu99XDJD3XezSwpoBzSpP6mgL+9GOBQs ++aidnYOopwX2TdfUIxXwsSZ1YEH9CPYY9RbCGDGV16HqvifPln8KBTJwkoW1Zk6qZqz yPxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SgGhE5dG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c3si12699200edy.147.2020.07.21.09.10.12; Tue, 21 Jul 2020 09:10:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SgGhE5dG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbgGUQIE (ORCPT + 99 others); Tue, 21 Jul 2020 12:08:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgGUQID (ORCPT ); Tue, 21 Jul 2020 12:08:03 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FBA0C061794; Tue, 21 Jul 2020 09:08:03 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id gc15so1594765pjb.0; Tue, 21 Jul 2020 09:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JGXo1HLmj0B/GHBmTJocAxawqfuB0THi+fafWm8sJoM=; b=SgGhE5dGd1GGv7R6MekmRlLAzrwTBb7Yt/cmaO/QHOjnZtnqP+30V+zBneRksbOrpR ICMM5jJrYJXKZvGMrWeoz4QTskzVcERx3qLv1Dy2Zob2qcZz8/1OARoznA+S+m+C2u0R 0gU01M+jBrxABByQvuxJ4Nkot6y8BLA/5zefqyPkwZS/FaeAVIC0EFxpIC7K9BvcSDRp GRyQa4xJQlT0VBQxDIKKDp1zietiJdPxXeZOZEdStcRCOEqk4JGqeW3D6b2Bt9+eO848 Wu4B+nwfXEkOT7dD31NpKLQu9EkxbOP/quN1dC0ZHP7gtpI/ki5cBaNrAEBzYLBqGb24 SzWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JGXo1HLmj0B/GHBmTJocAxawqfuB0THi+fafWm8sJoM=; b=TVNI16TXVbynWpz8FKpv2szINOPsHevR3z5tlcZ/Iq4CEfKfxoQmQd3M61IfG9j9N0 Mz/VPFONib4IAncIjzYCUz4Ld7Cu3H0YIR8UsFdvOyeUoKOVwJkk+HbBUVhO7V0mU4el ge32JtAUzRSkw7LYvfwD56mhGzfACAgPI0On+SSbF5CZRSfszwwlv1DrbigUzqb0wDfB 6WxiuZSQQ8qlqmML/M3fkdDURN/LPKaI7WvoYblmn/zRgUDHtFHyPQ/LCHDTXBITTFun 1wNgxiS9zISNjTuULPYmYgQzbwY5uyr3xL2A8YwmgoLyG0fGzfqt3EOjtcD2UJOkKhO9 pznA== X-Gm-Message-State: AOAM5326Nhy4F/G+D2Ja3NBas76nkwY7HH2uNqp7zBdurIcqYu9B3Zs0 HvHjdJDk26dOuRuHnzMzLFZ2kudJOSLwxkquHMI= X-Received: by 2002:a17:90b:3547:: with SMTP id lt7mr5481243pjb.181.1595347682901; Tue, 21 Jul 2020 09:08:02 -0700 (PDT) MIME-Version: 1.0 References: <20200721145046.773419-1-abanoubsameh@protonmail.com> <20200721145046.773419-2-abanoubsameh@protonmail.com> In-Reply-To: <20200721145046.773419-2-abanoubsameh@protonmail.com> From: Andy Shevchenko Date: Tue, 21 Jul 2020 19:07:48 +0300 Message-ID: Subject: Re: [PATCH 2/2] gpio: gpio-pch.c: fixed coding style issue To: Abanoub Sameh Cc: Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Abanoub Sameh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 5:51 PM Abanoub Sameh wrote: > > Added a lined between a declaration and other statements according to the > kenel coding style. Besides the typo in the word 'kernel' the subject is not okay. I fixed this locally this time. I also highly recommend to read https://chris.beams.io/posts/git-commit/. -- With Best Regards, Andy Shevchenko