Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbWEIOtp (ORCPT ); Tue, 9 May 2006 10:49:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751757AbWEIOtp (ORCPT ); Tue, 9 May 2006 10:49:45 -0400 Received: from dvhart.com ([64.146.134.43]:63202 "EHLO dvhart.com") by vger.kernel.org with ESMTP id S1751462AbWEIOto (ORCPT ); Tue, 9 May 2006 10:49:44 -0400 Message-ID: <4460AC01.5020503@mbligh.org> Date: Tue, 09 May 2006 07:49:37 -0700 From: "Martin J. Bligh" User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Chris Wright Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com Subject: Re: [RFC PATCH 00/35] Xen i386 paravirtualization support References: <20060509084945.373541000@sous-sol.org> In-Reply-To: <20060509084945.373541000@sous-sol.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 553 Lines: 18 Congrats on getting this thrashed out. A few comments, most of which are boring style nits, but nonetheless ... will try to take a proper look later. General comment: Why is this style used: HYPERVISOR_foo_bar ? ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest of the kernel style. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/