Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp901613ybh; Tue, 21 Jul 2020 10:34:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxs/aI62IyLlDyIW9WCPRVDqQ7q36154+zRM7+MaZUAcXFfsDoPhqpGuz2aGL9Q12mFq7Z X-Received: by 2002:a17:906:b2c8:: with SMTP id cf8mr26739320ejb.132.1595352889996; Tue, 21 Jul 2020 10:34:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595352889; cv=none; d=google.com; s=arc-20160816; b=CLsQAWTC+mUkQCFrFC8cgWdbFyk1lKKStPkBb81RI6OPBkautpRlyIZxBJCvUTd+BV GNMvg3jenN2fV9m8cICuWn22QSf8eP/I1p8DMtygcBI5cnNWKKwY/ztIIH+q3ePM5+ui /m0A4kx6M5D7AHijoQKygYDBwpNhvpF68GhsJusotR9XfGTiRUCGukwNpUMdxQZszS3h /6n+H111EcMi52S6JNutvxQZy2/lXoBLFHbuqL7rjO25+Ua6NeeuLDYpZaPRsEzl+8s3 7tXd1cG9AON4Ox1bNlNBWjCsyiaguuxiLISYZO+6GD4N6PlO91PdeBbs3Ath9u1SVwP7 oiJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=yANElEvBVGh2PATQ0vu+U5TVpOlCzAWTm213BUhq6KM=; b=WxJjxfBlaJq6Ni6GfF+8Y137HQ7GYpm5QnEnB2JVdTrOjYfyXVFFSfSWX6yaK+42GW 3GwFK38+E7WMzjcGUvVJoHzjefKXDKkemxH7QBMLSNaV1APiM3kiZ9HVVl7S8luXQ7PI 3P4O/DY/3a23Rf5Fg7ntJPDGmlelyemM1bBcXjNyIH05/LUAvOc2GyiG/vEdUESk8cuj q3zzfLeD0vvH6EqkS63zEUV4WbgtC+j8q/2AfleZB5B5KkLFO2fC/d5m66feNh+pqYiU RRBlVwMFZd5ataN3lmn9Q1WHiewzNN2tVTfRseshGRQnTzXAI0m1qXD9/ZQA4qE4EvuV 3UBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oFkLMOqs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si12798889ejf.367.2020.07.21.10.34.26; Tue, 21 Jul 2020 10:34:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oFkLMOqs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730560AbgGURdn (ORCPT + 99 others); Tue, 21 Jul 2020 13:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgGURdm (ORCPT ); Tue, 21 Jul 2020 13:33:42 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCB48C061794; Tue, 21 Jul 2020 10:33:41 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id y3so4642815wrl.4; Tue, 21 Jul 2020 10:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yANElEvBVGh2PATQ0vu+U5TVpOlCzAWTm213BUhq6KM=; b=oFkLMOqswXk0gyGHz8+O16IeTZTVASJlz+20NuF59sdo4qe3zVBU5aHSffL1TnJsjb y/dX3ulmFjlvJWV5ppJjfd8cK5GS5WlXUIdde06b3VbNkiK54j0tcM9FxxI4v4ZUQM5F ckQlsmAiWVuFs44HhJnuV1qDUNHiSLcqbOcDY+FzaPqnzSsd41eciTT7hkRiLQbjFWnI oealHUagXyg937PrOCW+9D+/NDINjDzNKqEJIhrRcVFrM4877N/KBXBOgX4UPfElByOa FHvbUjK07n4caNoM5Ga0Kiu5sQDJZ5TLh1KOlfKHTXwrzjJGW8ZfbU//nqXXHUXgXf6/ 1Uyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yANElEvBVGh2PATQ0vu+U5TVpOlCzAWTm213BUhq6KM=; b=dAhi7LT8xNzTrh6S3F50AC71ygp3RRNJ/wqdAmLlabjPnI0V0GKxoyP7Kk12pVXKHO Ik9jdlGgn4vrHEKXNtoHowzPsgym6jCOeHkOCi2fvsX0wMPo3R7EtjQ3xcEfaViYlwJr Z3gubvIC3FJmBlEmX16hpi7uLDxOyo9GY6uYO1R8JNWrUrCoLlo7NwJms01dAtuW0KGF zdLwmoosZv4hEqx1EGxOkDzqpGulElnRDCdAlLgAtQCyKCd86teHb86XQPp9W2YjMTXX TA6p/MKAy5QxsUxlV2pPRIV4MuOweFVYEApDIjCPHsrP70NP7loIuI83zhbu7MOL90q9 amrw== X-Gm-Message-State: AOAM5325jWWC1OjKV8Cz7cKlbkbnqMg2Co/AcREaLES5rA2K/v9foRRD dsiSo55mJsKkAVgNx0dmC7dBqHaU X-Received: by 2002:adf:efc9:: with SMTP id i9mr29232791wrp.77.1595352820575; Tue, 21 Jul 2020 10:33:40 -0700 (PDT) Received: from [10.67.50.75] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id y17sm22494397wrh.63.2020.07.21.10.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2020 10:33:39 -0700 (PDT) Subject: Re: [PATCH v2 3/7] bdc: Fix bug causing crash after multiple disconnects To: Al Cooper , linux-kernel@vger.kernel.org Cc: Sasi Kumar , devicetree@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Rob Herring References: <20200721144326.7976-1-alcooperx@gmail.com> <20200721144326.7976-4-alcooperx@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOwU0EVxvH8AEQAOqv6agYuT4x3DgFIJNv9i0e S443rCudGwmg+CbjXGA4RUe1bNdPHYgbbIaN8PFkXfb4jqg64SyU66FXJJJO+DmPK/t7dRNA 3eMB1h0GbAHlLzsAzD0DKk1ARbjIusnc02aRQNsAUfceqH5fAMfs2hgXBa0ZUJ4bLly5zNbr r0t/fqZsyI2rGQT9h1D5OYn4oF3KXpSpo+orJD93PEDeseho1EpmMfsVH7PxjVUlNVzmZ+tc IDw24CDSXf0xxnaojoicQi7kzKpUrJodfhNXUnX2JAm/d0f9GR7zClpQMezJ2hYAX7BvBajb Wbtzwi34s8lWGI121VjtQNt64mSqsK0iQAE6OYk0uuQbmMaxbBTT63+04rTPBO+gRAWZNDmQ b2cTLjrOmdaiPGClSlKx1RhatzW7j1gnUbpfUl91Xzrp6/Rr9BgAZydBE/iu57KWsdMaqu84 JzO9UBGomh9eyBWBkrBt+Fe1qN78kM7JO6i3/QI56NA4SflV+N4PPgI8TjDVaxgrfUTV0gVa cr9gDE5VgnSeSiOleChM1jOByZu0JTShOkT6AcSVW0kCz3fUrd4e5sS3J3uJezSvXjYDZ53k +0GS/Hy//7PSvDbNVretLkDWL24Sgxu/v8i3JiYIxe+F5Br8QpkwNa1tm7FK4jOd95xvYADl BUI1EZMCPI7zABEBAAHCwagEGBECAAkFAlcbx/ACGwICKQkQYVeZFbVjdg7BXSAEGQECAAYF Alcbx/AACgkQh9CWnEQHBwSJBw//Z5n6IO19mVzMy/ZLU/vu8flv0Aa0kwk5qvDyvuvfiDTd WQzq2PLs+obX0y1ffntluhvP+8yLzg7h5O6/skOfOV26ZYD9FeV3PIgR3QYF26p2Ocwa3B/k P6ENkk2pRL2hh6jaA1Bsi0P34iqC2UzzLq+exctXPa07ioknTIJ09BT31lQ36Udg7NIKalnj 5UbkRjqApZ+Rp0RAP9jFtq1n/gjvZGyEfuuo/G+EVCaiCt3Vp/cWxDYf2qsX6JxkwmUNswuL C3duQ0AOMNYrT6Pn+Vf0kMboZ5UJEzgnSe2/5m8v6TUc9ZbC5I517niyC4+4DY8E2m2V2LS9 es9uKpA0yNcd4PfEf8bp29/30MEfBWOf80b1yaubrP5y7yLzplcGRZMF3PgBfi0iGo6kM/V2 13iD/wQ45QTV0WTXaHVbklOdRDXDHIpT69hFJ6hAKnnM7AhqZ70Qi31UHkma9i/TeLLzYYXz zhLHGIYaR04dFT8sSKTwTSqvm8rmDzMpN54/NeDSoSJitDuIE8givW/oGQFb0HGAF70qLgp0 2XiUazRyRU4E4LuhNHGsUxoHOc80B3l+u3jM6xqJht2ZyMZndbAG4LyVA2g9hq2JbpX8BlsF skzW1kbzIoIVXT5EhelxYEGqLFsZFdDhCy8tjePOWK069lKuuFSssaZ3C4edHtkZ8gCfWWtA 8dMsqeOIg9Trx7ZBCDOZGNAAnjYQmSb2eYOAti3PX3Ex7vI8ZhJCzsNNBEjPuBIQEAC/6NPW 6EfQ91ZNU7e/oKWK91kOoYGFTjfdOatp3RKANidHUMSTUcN7J2mxww80AQHKjr3Yu2InXwVX SotMMR4UrkQX7jqabqXV5G+88bj0Lkr3gi6qmVkUPgnNkIBe0gaoM523ujYKLreal2OQ3GoJ PS6hTRoSUM1BhwLCLIWqdX9AdT6FMlDXhCJ1ffA/F3f3nTN5oTvZ0aVF0SvQb7eIhGVFxrlb WS0+dpyulr9hGdU4kzoqmZX9T/r8WCwcfXipmmz3Zt8o2pYWPMq9Utby9IEgPwultaP06MHY nhda1jfzGB5ZKco/XEaXNvNYADtAD91dRtNGMwRHWMotIGiWwhEJ6vFc9bw1xcR88oYBs+7p gbFSpmMGYAPA66wdDKGj9+cLhkd0SXGht9AJyaRA5AWB85yNmqcXXLkzzh2chIpSEawRsw8B rQIZXc5QaAcBN2dzGN9UzqQArtWaTTjMrGesYhN+aVpMHNCmJuISQORhX5lkjeg54oplt6Zn QyIsOCH3MfG95ha0TgWwyFtdxOdY/UY2zv5wGivZ3WeS0TtQf/BcGre2y85rAohFziWOzTaS BKZKDaBFHwnGcJi61Pnjkz82hena8OmsnsBIucsz4N0wE+hVd6AbDYN8ZcFNIDyt7+oGD1+c PfqLz2df6qjXzq27BBUboklbGUObNwADBQ//V45Z51Q4fRl/6/+oY5q+FPbRLDPlUF2lV6mb hymkpqIzi1Aj/2FUKOyImGjbLAkuBQj3uMqy+BSSXyQLG3sg8pDDe8AJwXDpG2fQTyTzQm6l OnaMCzosvALk2EOPJryMkOCI52+hk67cSFA0HjgTbkAv4Mssd52y/5VZR28a+LW+mJIZDurI Y14UIe50G99xYxjuD1lNdTa/Yv6qFfEAqNdjEBKNuOEUQOlTLndOsvxOOPa1mRUk8Bqm9BUt LHk3GDb8bfDwdos1/h2QPEi+eI+O/bm8YX7qE7uZ13bRWBY+S4+cd+Cyj8ezKYAJo9B+0g4a RVhdhc3AtW44lvZo1h2iml9twMLfewKkGV3oG35CcF9mOd7n6vDad3teeNpYd/5qYhkopQrG k2oRBqxyvpSLrJepsyaIpfrt5NNaH7yTCtGXcxlGf2jzGdei6H4xQPjDcVq2Ra5GJohnb/ix uOc0pWciL80ohtpSspLlWoPiIowiKJu/D/Y0bQdatUOZcGadkywCZc/dg5hcAYNYchc8AwA4 2dp6w8SlIsm1yIGafWlNnfvqbRBglSTnxFuKqVggiz2zk+1wa/oP+B96lm7N4/3Aw6uy7lWC HvsHIcv4lxCWkFXkwsuWqzEKK6kxVpRDoEQPDj+Oy/ZJ5fYuMbkdHrlegwoQ64LrqdmiVVPC TwQYEQIADwIbDAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2Do+FAJ956xSz2XpDHql+Wg/2qv3b G10n8gCguORqNGMsVRxrlLs7/himep7MrCc= Message-ID: Date: Tue, 21 Jul 2020 10:33:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721144326.7976-4-alcooperx@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/20 7:43 AM, Al Cooper wrote: > From: Sasi Kumar > > Multiple connects/disconnects can cause a crash on the second > disconnect. The driver had a problem where it would try to send > endpoint commands after it was disconnected which is not allowed > by the hardware. The fix is to only allow the endpoint commands > when the endpoint is connected. This will also fix issues that > showed up when using configfs to create gadgets. > > Signed-off-by: Sasi Kumar > Signed-off-by: Al Cooper Acked-by: Florian Fainelli -- Florian