Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp902134ybh; Tue, 21 Jul 2020 10:35:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw031fC0Iu82ThG0JSQ9+Jvgspd77s/rWKwCjX2bDy8bwV7bl4Q6nMKULYrsih+Xx9jvHrZ X-Received: by 2002:a05:6402:1d14:: with SMTP id dg20mr27457845edb.23.1595352937070; Tue, 21 Jul 2020 10:35:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595352937; cv=none; d=google.com; s=arc-20160816; b=IkPJnDxTJdVOxPIdud1xl4K1rdt7CIb10SxU/9q/3+Ttj8EwlwdyFs14aIQSpgvd11 GXXin1kedeaxeUkOpwCGTiOrZaUvZMsUXwh5MUHjym1GUTUYsE4d5X0ZZy3eigYZRs+9 bNTAlTIgAwDNKNSWJiuhRVsC0wVd62zw0SlS8iBAoVn/ENHYDaeBQCjjtWAlhQ3/9Rn9 KL93srcUip7GOhthzw3ny2t2SH8Zpr1Y4lO6yZqaOKAOsdbNzTy59GM+r7FFQfpIAxQi wZtDWESCAVNfHTRrar4EhtxybAC/CjzSFCRd/xJUL7odNi5miLBa7qkuvvDZmjafo8Sn smfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=u+vPDohjPAMyT5Kj/W2yFnkdATZ6hNyJda+UlZtVUIo=; b=dwWg6mdlHrn2huroNN81guKQ03aTem3doKNiwtMWlEkWCoV/asN67aTfxeIvZrZair Wrs+QV4vZb5dP4//eKtahxSm2AACI2tIdxyhdvx/NW0XrctbkfvdpjLlKWKSSG0l9lHh x95PD5FKL5mr7o4zLx3jRVsfMIT1uQTpzKzIx79ONV7/UDo/P2ttOcQPxqypX8FxYUPf /ANN0KF7VNnhpXbli9BKfwr8ptc5bSUEju5Eq3KX5RBNR2Ap8z31WzNR+dHQGu58A4+x qU8Hx3X6vlykCaGj3rHphBG18iRtvsu/RCrjKP2IDOvjzkLbW46v5e2J2q0gd+wkDCi1 T4Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="i2/xKI63"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si12868402edx.408.2020.07.21.10.35.14; Tue, 21 Jul 2020 10:35:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="i2/xKI63"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729107AbgGURdH (ORCPT + 99 others); Tue, 21 Jul 2020 13:33:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgGURdG (ORCPT ); Tue, 21 Jul 2020 13:33:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F25C22065D; Tue, 21 Jul 2020 17:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595352786; bh=hIE7IQDtbAmiYNYeSMqGBiJWFu506qsD/cuqjgAsj8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i2/xKI63nCEey1Gp95d+3e6gHvSwy2mqdUlfpbjfiD+/uSWX6BzbjT+CmTRRhsUTG HrFFKO44zl6hok/FWX9Pzk+4+q8s/UbXXDGxuIpl40OTWUBybdXF9PuP3PwMcPyQRf R+wJl4UjWiOjepxcEE5AnnODKr8YxdXEmOryJaRE= Date: Tue, 21 Jul 2020 19:33:13 +0200 From: Greg Kroah-Hartman To: B K Karthik Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tty: serial: fsl_lpuart.c: prevent a bad shift operation Message-ID: <20200721173313.GA2461958@kroah.com> References: <20200721171311.xlt256fq2qmw4e6p@pesu.pes.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721171311.xlt256fq2qmw4e6p@pesu.pes.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 10:43:11PM +0530, B K Karthik wrote: > prevent a bad shift operation by verifying that > sport->rx_dma_rng_buf_len is non zero. > > Signed-off-by: B K Karthik > --- > drivers/tty/serial/fsl_lpuart.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) What about setting the "Reported-by:" to the person who reported this problem? And cc:ing them to see if they agree with your change? thanks, greg k-h