Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp902958ybh; Tue, 21 Jul 2020 10:37:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjFiUOJkaRiVNJeotrermo8flPJN2iYe/rz0L+kusDohH+g5Uz9ED3rirr3bWrSc137jvg X-Received: by 2002:a17:906:2296:: with SMTP id p22mr25730524eja.510.1595353021924; Tue, 21 Jul 2020 10:37:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595353021; cv=none; d=google.com; s=arc-20160816; b=aEBY0OWH/2KbP0eZTWZfG3UbkdSVBwN8QGTyPIwLXxxm3MuKxAjexP+LwuxihqC7W+ mQxJ5oWQE9demLjt1FYUtEGHRpcmSBWr4zCSRYs2flBcB8I2upJjrkhnIgqyJUS1WoBs ++84BuQM90SgCizD1SHZBIVLOi7tA1RnLBxgkdAXUeptdNZu2xVItf4TQI4UX9Rsb9AE nSO1c2iPymtWQICctMpEU2fqm+4hxE3COQ/untlu7S+GNYvI8+978DER925A5gq4+cVq wsBlU1kr4XZH5G/gjFYz0+InkbesPhHc905zuLYb0Wo6E07XAqcAOnS8iMr5hxRP9gKy v+yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LORYIrVTVPx8RgFZS1Z6r0354F2GnyZdbII8Eg/Zk/Q=; b=EkZrl98hazQvz1EFXrfkIplau1sMhb7jjbEzK/IF+4Ux3/zDKWLz4qKKdiismjg9EX 7PO93WJM2KiCHczBDJfbs4m0OPFszDUCOybE6VbQ5N1w6xmS0/mv+0R6EluqwEyqlgCj CTwt2pZUUwmLkHLIKZ0t+wKR4+gon925b9G2oOK8vZ6/GoIYn5BmoFter4dEVfdWsNdE smwGRKkWqU/dhynm05EDk4QIimZDnAGkXrFNfvp2KhhOR6+34YqUVo6frPnsJXVk5txo NmKTq7hrZUAlCga8VT6kepSaQg1sIKh8eAR/+iwcPXPY3+PIQUac8mBqCrDlSbmfAB6Y 5u2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nao2wzN7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bf28si13473281edb.312.2020.07.21.10.36.38; Tue, 21 Jul 2020 10:37:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nao2wzN7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730590AbgGURds (ORCPT + 99 others); Tue, 21 Jul 2020 13:33:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:60694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgGURdr (ORCPT ); Tue, 21 Jul 2020 13:33:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94E4920717; Tue, 21 Jul 2020 17:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595352827; bh=4NcPcN8rD2FoQUOIdZkD4QjVcEtKOHW0B/nnoztGEQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nao2wzN7EM8zNqJbM5TI1LMgHb6Fpl6nlRLTOZ0jNCU9YBZDerIoBVudR3fCB8oUf 10QS/abDvmhlHg1ZYH34Ci1iAMz1eFBg0YXL/5jJdZOsxCJOil9Uq0xR0h3xtAvNse OGB6R2W3FH+F/Lc3yP9Z/BwlTjU1Xx3ZLJcqORpQ= Date: Tue, 21 Jul 2020 19:33:55 +0200 From: Greg Kroah-Hartman To: B K Karthik Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart.c: fix a parentheses coding style issue Message-ID: <20200721173355.GB2461958@kroah.com> References: <20200721171412.xfpzswsrjn7savco@pesu.pes.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721171412.xfpzswsrjn7savco@pesu.pes.edu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 10:44:12PM +0530, B K Karthik wrote: > add parentheses to expression to improve > code readability. > > Signed-off-by: B K Karthik > --- > drivers/tty/serial/fsl_lpuart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 0cc64279cd2d..3108f5ab57fa 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -1167,7 +1167,7 @@ static inline int lpuart_start_rx_dma(struct lpuart_port *sport) > * Calculate length of one DMA buffer size to keep latency below > * 10ms at any baud rate. > */ > - sport->rx_dma_rng_buf_len = (DMA_RX_TIMEOUT * baud / bits / 1000) * 2; > + sport->rx_dma_rng_buf_len = (((DMA_RX_TIMEOUT * baud) / bits) / 1000) * 2; No, what is there is more readable, don't force people to try to remember the order of operations. I totally disagree with checkpatch here. thanks, greg k-h