Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp904644ybh; Tue, 21 Jul 2020 10:39:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNhn7FdvNkXupC9wHngkexnurTkd0PQMz3bvaGwlGkgJUR/LQXrJUsG8PTnQFhsVy+D2X2 X-Received: by 2002:aa7:dc46:: with SMTP id g6mr26320019edu.194.1595353187441; Tue, 21 Jul 2020 10:39:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595353187; cv=none; d=google.com; s=arc-20160816; b=q5noT0/5UjArY2/q9wRUa8l7V18G/eK6v+TZ/Jbet5Y2MqGacr+lpVrddsgEjTIztH EAQ6oD8TKDSt484N3uVQWhnOtQnjUCaMhRzYiYKQjzndeRas4GiGRoUP7jsVd2Jenpsd wXdX+QBwU8cZq80q8fhTa8p/1CbpV40zzWyHfHkdY895H2N02OM/sKYEk2EsfTqLYRfK L/NqhAGJPEjZ0GBS9zLeQ4CJSSiEcLif1J2VUI6FoshzNek0ucYsKsStjC1rz9GrTWdB lexz9PQGq8fwHJETUJZp9bbp7AH4/FEZvsDiQSzJDyC2SDdTxjbzqbtucRTM27qpWanH bBww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=vaXrNgM/Q0iRugUhTD5mw4YtXW2NAohGuCSxa3oPxW4=; b=JRPVr7wMwwxl97ZuiKztOLtyZu94Kv64Lul2VqbTzCZkg4zcKkmvcMFynJNLIJrwwg hr5io3tVnDbv5ngvPnBwn/LH7l7wKHLW+m07esVsZSknlIwd2sSOP5hqubVzMCziJRQK u7DB1NT/lHT+9iyG6b/sqt9+mSnkK9qmfTzwnEockhs9zM//XId26yc9YZhcmxjvbhgS StmpVXbBoAY+JgfWWk54WeEwbDQMEqb8i+4w7Y+jo0/HA2+Kqx9usWHWkmntpHQn1Req eu2uwa1qy00KVj/TW7FPdpu+bNK4wzDJMnJ0l5kEP0kV9OTNgXyE64hFuU47fk8AbtbC 16KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si12543084ejj.468.2020.07.21.10.39.24; Tue, 21 Jul 2020 10:39:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbgGURjB (ORCPT + 99 others); Tue, 21 Jul 2020 13:39:01 -0400 Received: from mga17.intel.com ([192.55.52.151]:25532 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbgGURjA (ORCPT ); Tue, 21 Jul 2020 13:39:00 -0400 IronPort-SDR: anAe2UelXwPsWSmqBnlTWjkR2lUgobtVTxoIIVNU+Y8Z8/57RFjrENJMuDDF1sJ6lJDOjmyZey cw3N/0+T+yEw== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="130274915" X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="130274915" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 10:38:59 -0700 IronPort-SDR: XvL32KkZWfZL1I/VkQvfzzL0KHkKuXFuc9S1LyZ3pvvElEcL8Y0s3oRofbP5f2az8MibeUoUXm nPu9Ok+1pdDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,379,1589266800"; d="scan'208";a="432076873" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by orsmga004.jf.intel.com with ESMTP; 21 Jul 2020 10:38:59 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id C01D6301BF5; Tue, 21 Jul 2020 10:38:59 -0700 (PDT) Date: Tue, 21 Jul 2020 10:38:59 -0700 From: Andi Kleen To: Peter Zijlstra Cc: kan.liang@linux.intel.com, acme@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, eranian@google.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH V6 09/14] perf/x86/intel: Support TopDown metrics on Ice Lake Message-ID: <20200721173859.GG1180481@tassilo.jf.intel.com> References: <20200717140554.22863-1-kan.liang@linux.intel.com> <20200717140554.22863-10-kan.liang@linux.intel.com> <20200721124042.GX10769@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721124042.GX10769@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Also, that for_each_set_bit() loop, trying to find the events to > update... > > Can't we, instead, make the SLOTS update advance 5 running counters in > cpuc and feed the events off of that? The original patches implemented this through a perf transaction and a cache. I think what you're suggesting is similar to the old cache. -Andi