Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp927888ybh; Tue, 21 Jul 2020 11:16:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydNUeiU34U1EC3xfHuxUuWCWd6aC5fxcL7Nhf7KHVxB0Bf8P1vrEr8Pse/UVq9qwVuxtZb X-Received: by 2002:a17:906:dc12:: with SMTP id yy18mr24897856ejb.295.1595355382391; Tue, 21 Jul 2020 11:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595355382; cv=none; d=google.com; s=arc-20160816; b=HBM5mLRd4PHZZkGl8ptSlsa8t1AtfT7syMxe/aWSkFkFWVX8KVxBpdaATA4Pb0aabZ ZOWTVzFI62anT0BaWAA5vP3OvJC2UYf84Z0KtBEB8VuZRsWH55YWU46Vwx2UQcq/Wfjx s6zQc1J49/h5LWLppWWN92XTUJW+xM9HOxinW6pQos8Y9qvihO+0BMIL8l1IrjdtRWBQ B9TXFlJowLZkhPBV3HSqPWKLePv1dM2fz4JUS5G9DCXH77XGl9aaB8Xja8kM+JcUpuUS 6mvN621OL9AeemsRhbnFAinonvEgDzQhwQPhI2ofszHUJQr6x6RUfKGSX8vENi1GuhQ7 pK/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KVVjAkfV64YN+ezW1WM+0vgwvcTru6dPfbG6aGenKT0=; b=Oc8EDKXs8GtlXEAdI3ccMe+udmvWTm2einoxU6pAxayo0ULwjSdbORRqNmQ9IEaJUz J+crQT9UCvV0hK261EzT5Nj6cl88uv6vsG6/HOfp70l0EqZlCCxZQMc6hyvYjFgdn6o+ 6t+U4oeXkTmH8B+jTbJmRKhGIpxHVYPNCoYuYZwd8E/jXDscvUHxJITK1CCy3WbKW4PZ B8jbiHvGTXthPEwwYRZmUWzjL4KNzAs2u6tmP9mqAMa8NxNKaLV7Gc/PDPM1fmV9Hkt+ Iw+3Krc0DjhpjpIubUT8XdTPp3BGFGJavgfpnuRDyiHMDId9ZxQH7ti7GpTxzfYpkA31 bfdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kryo-se.20150623.gappssmtp.com header.s=20150623 header.b=ntLBN0rv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si1441390ejb.293.2020.07.21.11.15.55; Tue, 21 Jul 2020 11:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kryo-se.20150623.gappssmtp.com header.s=20150623 header.b=ntLBN0rv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbgGUSPT (ORCPT + 99 others); Tue, 21 Jul 2020 14:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgGUSPQ (ORCPT ); Tue, 21 Jul 2020 14:15:16 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B8CBC061794 for ; Tue, 21 Jul 2020 11:15:16 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id z6so4937688iow.6 for ; Tue, 21 Jul 2020 11:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kryo-se.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KVVjAkfV64YN+ezW1WM+0vgwvcTru6dPfbG6aGenKT0=; b=ntLBN0rv0yoHIQrjDgVhIvFKkRwg+qM35RkR6fj4PRMEEJpltk9LVVY6yGguLoR0K9 2JOn5virYAQ8jtWOhvP2RJ7yXsZAzJJcnTrsi76cqMqIKle9CyAgzKrmJYhnl3W80Ofh yTujC6GqoRvcPH9ZzX+O4EK/HMyYcBc0QW97+rL1HwLkqu05WgfyolB805OyY0zYTsJq Wp499ujZ3q0VMxpwaHbNo9OrJrPqw/PG6abWAgdKIL/Ogscu5Or3BLU4z+UI58WkQSkd twar/kG6hnVA9Bv3brUAEGqB9P2RC+AAC1Rs3gBwKuS7ps5TBRMdUoA3k5s82vjG4/cG 2stA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KVVjAkfV64YN+ezW1WM+0vgwvcTru6dPfbG6aGenKT0=; b=TjVKkRZcmKZjwqOX24Rz/BzDWycL624fYLYn7+0r48rVHvMIfFd+1PSJxtlPxFgoCo NRAjj5Jj1vEOFtyor252k9A55XRANY/8mLHJ6WLrmODpiMJoHq3kfy0yCsCXjJOnqbub P0w2UGbZegI2vWxaJRkjGspTxh4DrueuCu682kTMIacY53+sd137Hn8D76HnCQ8uMRls QRnsAglACIPc4gITp8yjfY+AejOFI6S5B16eDjT+PaTowO/wIzVkBdjGMn/R3QYeI4Gw Mrv4KYE8iSZQP9W9FELXTrV/5SAZ03NE0XClCKkSdFOD88D5/o+d2NK8I34nyNm+in10 ZiSg== X-Gm-Message-State: AOAM533FdfBtWLCnIT08R3hMusK2eCWnYHkBq0tyoQc3vDfg34i+nr6F hb1vXtILlCzbJoTXKEfJfNWYXw2aHaXCx2KFGFjnPg== X-Received: by 2002:a05:6602:148f:: with SMTP id a15mr29521465iow.26.1595355315409; Tue, 21 Jul 2020 11:15:15 -0700 (PDT) MIME-Version: 1.0 References: <20200717185118.3640219-1-erik@kryo.se> <20200721072350.GC3634@localhost> In-Reply-To: <20200721072350.GC3634@localhost> From: Erik Ekman Date: Tue, 21 Jul 2020 20:15:04 +0200 Message-ID: Subject: Re: [PATCH] USB: serial: qcserial: add EM7305 QDL product ID To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020 at 09:23, Johan Hovold wrote: > > On Fri, Jul 17, 2020 at 08:51:18PM +0200, Erik Ekman wrote: > > When running qmi-firmware-update on the Sierra Wireless EM7305 in a Toshiba > > laptop, it changed product ID to 0x9062 when entering QDL mode: > > > > usb 2-4: new high-speed USB device number 78 using xhci_hcd > > usb 2-4: New USB device found, idVendor=1199, idProduct=9062, bcdDevice= 0.00 > > usb 2-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > > usb 2-4: Product: EM7305 > > usb 2-4: Manufacturer: Sierra Wireless, Incorporated > > > > The upgrade could complete after running > > # echo 1199 9062 > /sys/bus/usb-serial/drivers/qcserial/new_id > > > > qcserial 2-4:1.0: Qualcomm USB modem converter detected > > usb 2-4: Qualcomm USB modem converter now attached to ttyUSB0 > > > > Signed-off-by: Erik Ekman > > Applied, thanks. > > Would you mind posting the output of "usb-devices" (or "lsusb -v") for > this device for completeness? > (resend as plain text) from usb-devices: T: Bus=02 Lev=01 Prnt=01 Port=03 Cnt=03 Dev#= 30 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=1199 ProdID=9062 Rev=00.00 S: Manufacturer=Sierra Wireless, Incorporated S: Product=EM7305 C: #Ifs= 1 Cfg#= 1 Atr=80 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) and with the driver it instead ends with: I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=qcserial as expected. Cheers /Erik > > Johan