Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751783AbWEIPL6 (ORCPT ); Tue, 9 May 2006 11:11:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751782AbWEIPL6 (ORCPT ); Tue, 9 May 2006 11:11:58 -0400 Received: from mtagate3.uk.ibm.com ([195.212.29.136]:52960 "EHLO mtagate3.uk.ibm.com") by vger.kernel.org with ESMTP id S1751400AbWEIPL5 (ORCPT ); Tue, 9 May 2006 11:11:57 -0400 In-Reply-To: <20060509093614.GB26953@infradead.org> Subject: Re: [RFC] [PATCH 3/6] Kprobes: New interfaces for user-space probes Sensitivity: To: Christoph Hellwig Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , suparna@in.ibm.com X-Mailer: Lotus Notes Release 6.5.1IBM February 19, 2004 Message-ID: From: Richard J Moore Date: Tue, 9 May 2006 16:11:36 +0100 X-MIMETrack: Serialize by Router on D06ML065/06/M/IBM(Release 6.53HF247 | January 6, 2005) at 09/05/2006 16:12:49 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 37 Christoph Hellwig wrote on 09/05/2006 10:36:14: > On Tue, May 09, 2006 at 12:35:08PM +0530, Prasanna S Panchamukhi wrote: > > This patch provides two interfaces to insert and remove > > user space probes. Each probe is uniquely identified by > > inode and offset within that executable/library file. > > Insertion of a probe involves getting the code page for > > a given offset, mapping it into the memory and then inserting > > the breakpoint at the given offset. Also the probe is added > > to the uprobe_table hash list. A uprobe_module data structure > > is allocated for every probed application/library image on disk. > > Removal of a probe involves getting the code page for a given > > offset, mapping that page into the memory and then replacing > > the breakpoint instruction with a the original opcode. > > This patch also provides aggregate probe handler feature, > > where user can define multiple handlers per probe. > > This introduces interfaces that aren't used anywhere in the following > patches. That is completely not acceptable. Please provide a proper > userspace interface to this functionality, e.g. something based on the > RPN code from Richard's dprobes. > Christoph, what are you asking for here? Surely not the RPN interpreter. I thought everyone agreed that that was massive bloatware and that a binary interface viz kprobes was a much better implementation. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/