Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp956697ybh; Tue, 21 Jul 2020 12:03:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlJbsfn9eaLhzZN+8xfQmpcZ/EKl8/5zeKMzbgGBKDWTV6G7UOY3mDED9jP4xPo+LS8bmM X-Received: by 2002:a05:6402:319b:: with SMTP id di27mr1923929edb.133.1595358190494; Tue, 21 Jul 2020 12:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595358190; cv=none; d=google.com; s=arc-20160816; b=liZOg3SeGrpgcInRXd/VBZgr7YwF/A75TpfKTrW1L91a2SCRrD/oBAKEddZGAijEgQ LfwEELbwyEj6MQFI0jXcnyuvrHllXHfz/sE4D6vyv9jK7PXGshnVplWui5NEqqSkTxC0 5gMGJl6FI+D3YfQJeYkT51wBnCLDB02ReGrETdPv1Sl9XitmF7mhFELd+5fHnrrBZ5M6 psBD/9VYMs6dy7WCAUgCYKGz98ZWQzRm3fsgYnbY/LsWtRZz2K3TKqrryyXXugsPo3vs tPRVRL8gpVFNkCULEGlIrYYBeDtdgWjGR2ydtHajwWS2F6KkbIV0YPhvzaU6MAJ8BtDO 96Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z7r+tykWJeqyUt+0w32i8HpBG73ZF426jmYt8FWFXXg=; b=qZwpciy5L4FQBwmS9gRNzBBiVgw4SFRVsalRKP0Ko4RM+Ge7eq7+8DyOfZj3WokT71 e3ioBC8s+M9m2jv85riviZa2k+kwxg+BqW6AjlTNBUnX+lmGOPecUuJ16Zvew45rsqhK idgApUVpYZ2cnr+IMIpF+qEq0wCe8MfOanmyNwjgNZd8PjtUKwwbDVOk9My1jkX1iseB ri3KP1L6Hi29R22FO2q3gMpWhvNb+fL0w1rXADP3FSiOCCDCdplu+1fbg/TNSC2o1XqB O5NsSyrgy/o556BrVuc7SsfC9K/iYHDEeJha0JcUYcYseQ9FuBGerAvdPNTDBFmJFwwA JgzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K2nZxYuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id md1si12478563ejb.749.2020.07.21.12.02.46; Tue, 21 Jul 2020 12:03:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K2nZxYuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbgGUTAi (ORCPT + 99 others); Tue, 21 Jul 2020 15:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbgGUTAi (ORCPT ); Tue, 21 Jul 2020 15:00:38 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA8BC061794 for ; Tue, 21 Jul 2020 12:00:38 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id j20so11169280pfe.5 for ; Tue, 21 Jul 2020 12:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=z7r+tykWJeqyUt+0w32i8HpBG73ZF426jmYt8FWFXXg=; b=K2nZxYuSsZMrLPLzyUJFpDo78L0fWs1qa1pyFS0dED7D85EPDvugXZNiC6I4kYNyaj QVuNzYcQ9C1wAQ9KfL95/gpg1xghQUSwychQJx9ETTXmZ5CtgqSOEgLlvXQgzzQft6d5 NXH7njx4hhVgj3kjD8v4NwD7xU/MdKbe/sm7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=z7r+tykWJeqyUt+0w32i8HpBG73ZF426jmYt8FWFXXg=; b=OtY682vPdII64EC5uGoMIK7fXrPdR/JZfJcwucxeiMRXSuFC8vwUkCAWXx8Lf66eFW TfyGGhfKFwC4KrpC37C5KGbJAiamLrhvJ5V46TGwMfyVltbSWM94WEVPM0eAag/GQEtK Inwy8RrS9uPw8Gjaqgv1l2kwIcvrWxLd/33UlNI3GFxe10eIIoGQD/2eYLE2VbrwrquF QnX54pFrxAnm6Qi+CR+AYKW8MYLWMlcuAjFw0xMo14w/OsmpavkTECdjaJyFxNXgTU9L 0g5YWEhkr0eJPpoHjZK/6zzqulpeBXsFralo40rD5Q9NttPjmor5lWZzB7hZjyGK9FvU e15A== X-Gm-Message-State: AOAM531K45PYDkGaRAjKd2Dv6uK54NbQFSweEXi+jjzWbhhv6fP2tL5w iaf7OLI+oW2c8s9jPQLYh7nMTp1rTHo= X-Received: by 2002:a63:df03:: with SMTP id u3mr22870077pgg.84.1595358037787; Tue, 21 Jul 2020 12:00:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z9sm18970158pgh.94.2020.07.21.12.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 12:00:36 -0700 (PDT) Date: Tue, 21 Jul 2020 12:00:36 -0700 From: Kees Cook To: Paul Menzel Cc: Andrew Morton , LKML , amd-gfx@lists.freedesktop.org, Duncan <1i5t5.duncan@cox.net>, Anthony Ruhier , Vinicius , Thorsten Leemhuis Subject: Re: [Regression] hangs caused by commit 3202fa62fb (slub: relocate freelist pointer to middle of object) Message-ID: <202007211156.D8BEDEA247@keescook> References: <15cbac6d-1f96-2ba9-cb54-08af6682f56d@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15cbac6d-1f96-2ba9-cb54-08af6682f56d@molgen.mpg.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 04:55:12PM +0200, Paul Menzel wrote: > No idea, if you are aware of it yet, but three people verified that commit > 3202fa62fb (slub: relocate freelist pointer to middle of object) causes a > regression on AMD hardware [1]. Hi, thanks for emailing; I don't get bugzilla notifications, so I hadn't seen this yet. > It’d be great, if you took a look, and advised if this commit (and > follow-ups) should be reverted, until the issue is analyzed. There have been a number of fixes to that commit (which I see are mentioned in a quick skim of the bug), but they've mostly been around additional slab debugging features. If it's causing a problem outside of that, my instinct would be there might be a use-after-free happening, but I'll go read the bug more closely now, and comment there (or here, if needed). Thanks! -- Kees Cook