Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp969703ybh;
        Tue, 21 Jul 2020 12:22:12 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxuwC2TNUQAtSjnpX2VT4iavPg/3PYwXzuHedGpK9MvuC1Er2Q0edZO9gLgCGEAxWXaaLQm
X-Received: by 2002:a05:6402:1c86:: with SMTP id cy6mr27004215edb.30.1595359332606;
        Tue, 21 Jul 2020 12:22:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1595359332; cv=none;
        d=google.com; s=arc-20160816;
        b=bizJjoaZ8pSJbE7nUgfqG6duqC9bB0a2giDyVyts2shyv0+lbdOxAW6beuDFywfTIE
         7VJ0v6N2E4CId4Jy/kr72XgSgBTWZ/Tbra+v4jlLUvMXjtZhm0MneTSsO8Gs4hs9l8C2
         Wv1AVNSBJ2ti7YSx2yPlQ0Nr+fjFXkpQrCMx6nNl9EQe/UOypzfEZOu1vVu3Vfcs26ts
         OruwruizdCzEkS3JfpxXzglFa/k19G6D5yr+G7Fed/Lcsfr6PGp8ZyyAKi8jpkeREiOL
         h5ZAAUGgQL2DdPnaA5ejFadSGQgGhfGN/MAB+Z1/T1i/oLXTcYcLjCcmzTCDjVDBmayN
         B6Fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=QNObktcUVGBoRq+APRBDo9YNWygmzGeUOkD0EbOwytY=;
        b=tIbcxKa1zL6nWBDFsQM7QuQWXO66wMk2m63vNgmf0E8YxaAOTf9iIVCC5lyOiW4kCB
         BPH9EgrDaHJpq0jFeTP3IShC0bX52b1Iuc/Z21QEF/Dl4g6MNoOaajQiZrOV8MqbgA4m
         o1lbQrIAm2gbaww1m85sJ4yL7P4uox4T9ybTgduDNGrPuJl9EviKzHLadLdTZP6TV1TM
         1E4t7gasjqI5MmaJZSBzf6eOynNVNugxLbb7AEMGhJvbum9B3X6axnBF7lPqH6IoTn6i
         CYlsJGq9ur/884Vs5KvpRVqeRl/87trMuVADMchN4LJ+OcygjCgj1Mui917bCAeTC8Sy
         DIpg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=t7QKyQb8;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id be27si13011878edb.50.2020.07.21.12.21.48;
        Tue, 21 Jul 2020 12:22:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=t7QKyQb8;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730664AbgGUTVa (ORCPT <rfc822;thunderbird.krnldev@gmail.com>
        + 99 others); Tue, 21 Jul 2020 15:21:30 -0400
Received: from mail.kernel.org ([198.145.29.99]:58888 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730250AbgGUTVa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Jul 2020 15:21:30 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 6F3B1206F2;
        Tue, 21 Jul 2020 19:21:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1595359289;
        bh=uvcuFv0R6bqByYEk1y2UFO10PzRWHHXQclqrGDwva6Q=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=t7QKyQb8s6wv3ahZjUOMbWYGDUR3vmzeNZrTzR5ncfMPPccXMI0Ij9jPtgbZbnV78
         1T93wL1AeCGIZG8zN3KHjcoJ3HZMiGNyGyZgq+7LGuAVVh64iru1o+VYnASx+jYyIu
         aFHGOelzKORJ61nNURYKYwZHH/Bx0uW2vn6M3OLc=
Date:   Tue, 21 Jul 2020 12:21:27 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Chi Song <Song.Chi@microsoft.com>
Cc:     Stephen Hemminger <stephen@networkplumber.org>,
        David Miller <davem@davemloft.net>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX
 indirection table
Message-ID: <20200721122127.3ce422f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <PS1P15301MB028211A9D09DA5601EBEBEA298780@PS1P15301MB0282.APCP153.PROD.OUTLOOK.COM>
References: <PS1P15301MB028211A9D09DA5601EBEBEA298780@PS1P15301MB0282.APCP153.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote:
> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, add
> device attributes to show the content of TX indirection tables.
> 
> Signed-off-by: Chi Song <chisong@microsoft.com>

Sorry for waiting until v6 but sysfs feel like a very strange place to
expose this. Especially under the netdev, not the bus device.

This looks like device specific state, perhaps ethtool -d is a more
appropriate place?