Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp978579ybh; Tue, 21 Jul 2020 12:37:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWSc8LupCNtnmlJohf0k2FWGhsU3iIS1lFOr3crjNEuLymbNWOpPOjc0GPbZtmc9AzUieH X-Received: by 2002:aa7:c816:: with SMTP id a22mr27645949edt.28.1595360247983; Tue, 21 Jul 2020 12:37:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595360247; cv=none; d=google.com; s=arc-20160816; b=q+6Va2VWt+fZCBWhfsnBALm26ojddyYaSGxKLR6hQDOoiTTNhZxQ0tbO8uSiwcT3k0 3Jg9r1peXIgYQGoEREKyVg7niN9l8NIatVWXLr+y9eLAvUTkazDf6ipbJ0OFUtvbbXPx sw0FK25bxpMfDVvMnQnHAG+6Lrb5EdvXGY49Ea5e7EjwUQJohqDTEkWdryqckv4Yo+IE m31Ft9/jje7V+kZyQBJQaKDAA3fY2kdenyWd1v7kHfQuXfmq5QJLpJuQ+PleTCqXL0AT h8u2bdba9CM67iCtOncpoI28kYFky51BjePZUXni3LTwoPRti9Uf5+f6AAI7V8qyv6SZ QmSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Fxu1ZU20Y/S/zgHj//3BPz0PVPjxCVp0vsB9qgjUbGI=; b=KFiXrPpQCzm0M3Zc8Hp8KJMSprt0o+5PhHOO7WQfT2SVX5I05xgyhZf0Xt3BBadmG9 ZNyn+BObIuYS0SxCytyF8aff0gKfzd8VDiX4AajDr5PQjuvd2nN9zFmgwjCfDfHQUyNh 8JT1tRyfEbpbIvT9mMkqNsqen7yrGDWnQXxnPEQaTQf8tTGSeD2t+lF54LQRmodEhxlh SXPsojmQkt6K5O1ivlvA0QvpBzMRdLzvDy9abUJQ1esVrkPCabMxzhD89TO6Yp+O7Bk7 lZKCo4mLpLF03IPiERsNjICP1bjpXqZV9V89m7LnGNz1/HqHsciw9tC76oGSq1IQBSBb VqqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iv3E74EO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si13185946edn.472.2020.07.21.12.37.05; Tue, 21 Jul 2020 12:37:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iv3E74EO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730901AbgGUTgY (ORCPT + 99 others); Tue, 21 Jul 2020 15:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730877AbgGUTgW (ORCPT ); Tue, 21 Jul 2020 15:36:22 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BAE8C061794; Tue, 21 Jul 2020 12:36:22 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id q7so25388536ljm.1; Tue, 21 Jul 2020 12:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fxu1ZU20Y/S/zgHj//3BPz0PVPjxCVp0vsB9qgjUbGI=; b=iv3E74EOrsjDcGJCRYWmYjvJE4JFVdHo+q1h8lzkAM5lpp+BLV658uHJuUCpkY5ZZa YgDSskaCqdxo4qh9LpkGF2xrBTegOtDhAiGS8xPkEOp7a2YbpnQembVOf+awjHQ9jD2v qEB+GUylavs6YAaamlVplaE11oGpmTPtnjAlKHApYpzCYhBfi0fQRLsBG8XAdc4lQq8l Nte4CzV6vVT2FFKtr+u+cNqqJI4fY4coAKfp8WwvlptZwtYe9flsd0O83JEaCrJYxV4h lvyrOTl4GnSgukCGGjhs2NCuYtpfyEquCrEtiU+UiMQH+w8Vs0AmZ2FOz/Bp1sdrHZty TCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fxu1ZU20Y/S/zgHj//3BPz0PVPjxCVp0vsB9qgjUbGI=; b=L6upCamnpM48+r06fHDBIZjUDctox7eXm3fUtuzevPwUxtlfSuWRoy1Act79Suzgee Io+1DotVLvDQPjd7TRwbcZnxhXf8lSiG2G47BfqVQsqZnaIuTn9zwX+JLrXnBiGb6S+d id48jenFcAvfLEd/gKI4OV3Wu7V13k2orWLB9cedknLx+PVxKxJw9WluPzs7eAtBaK/U V5sDtwi6Ypn9q7O+1OeM7y6IRObSIWoNShe2v+CVTJBykRs499HwQyaPS8Lk9MRMXSdi Elka8m2AEmY8C3V7LPiIjjgAmzYoZnKdnnGZQqoZd4fHcF1gHVEJt1y5clzZlJj7K+Rp s00Q== X-Gm-Message-State: AOAM530XPDsRl9CzVW9MQl+BySnJdI2ZtrwIuPoy/7qIwf8yIrEdyFsT +B2noPu1kM2e/cdP5wC8Z1aNJSRemS1HeBqJKTQ= X-Received: by 2002:a2e:9bc3:: with SMTP id w3mr13974528ljj.121.1595360180907; Tue, 21 Jul 2020 12:36:20 -0700 (PDT) MIME-Version: 1.0 References: <20200715031353.14692-1-yuehaibing@huawei.com> <20200717123059.29624-1-yuehaibing@huawei.com> In-Reply-To: <20200717123059.29624-1-yuehaibing@huawei.com> From: Alexei Starovoitov Date: Tue, 21 Jul 2020 12:36:09 -0700 Message-ID: Subject: Re: [PATCH v2] tools/bpftool: Fix error handing in do_skeleton() To: YueHaibing Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Quentin Monnet , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 5:31 AM YueHaibing wrote: > > Fix pass 0 to PTR_ERR, also dump more err info using > libbpf_strerror. > > Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside skeleton") > Signed-off-by: YueHaibing > Reviewed-by: Quentin Monnet Applied. Thanks